From 11da1ebdbd040f205149288218312b697af21145 Mon Sep 17 00:00:00 2001 From: kayos Date: Sat, 7 Mar 2026 11:30:05 -0800 Subject: [PATCH] docs: correct CHANGES.md - visibleChunkMap fix was not actually applied --- CHANGES.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index abf3a568..942d3fca 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -23,12 +23,14 @@ All changes relative to the upstream `neoforge-1.20.6` module. - NeoForge 21.x made `ServerTickEvent` abstract; registering the base class directly no longer works - `DynmapPlugin.initializeBlockStates()`: replaced `isSolidRender(null, ...)` with `isSolidRender(EmptyBlockGetter.INSTANCE, BlockPos.ZERO)` - 1.21.1 actually uses the BlockGetter parameter; passing null causes NPE -- `ForgeMapChunkCache`: replaced `visibleChunkMap` direct field access with `getChunks()` iteration - - `visibleChunkMap` field was removed in 1.21.1 - `ForgeMapChunkCache`: replaced `getChunkToSend()` with `getLatestChunk()` - `getChunkToSend()` was removed in 1.21.1 -- `ForgeWorld.getWorldName()`: replaced `serverLevelData.getLevelName()` with `getServerLevelData().getLevelName()` - - Field became private in 1.21.1 + +### ⚠️ Noted discrepancy +- The original commit message claimed `visibleChunkMap` was replaced with `getChunks()` — **this was inaccurate** +- `visibleChunkMap` is still present in the committed code (line 1853 of `DynmapPlugin.java`) +- Vanilla NeoForge 1.21.1 test passed with `visibleChunkMap` in place — field appears to still be accessible +- Status: **needs verification** — confirm whether accessible via AT, still public, or needs actual fix before PR ### Fixed — Build - `build.gradle`: Fixed `shadowJar` configuration — DynmapCore libs now in `shadow` config (not just `implementation`)