From 7643c6521e881c99fb912b19faecbc4a6e2168fa Mon Sep 17 00:00:00 2001 From: Adam Tunnic Date: Fri, 12 Feb 2021 12:17:05 -0500 Subject: [PATCH 1/3] Update gibberish.txt --- .github/workflows/gibberish.txt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/gibberish.txt b/.github/workflows/gibberish.txt index f7c3e850..03d05ddd 100644 --- a/.github/workflows/gibberish.txt +++ b/.github/workflows/gibberish.txt @@ -4,20 +4,17 @@ dynmap Dynmap's APIs APL -Bukket Dynmap Dynmap's DynmapCore DynmapCoreAPI JRuby -MacOS +macOS Minecraft PRs PaperMC WorldGuard www -corresponiding -depdendencies reflow runtime theose @@ -53,3 +50,4 @@ reddit subreddit gg pqBpw +JDBC From 134dbf34fc0a331a97eaeced710bb52355fe4f83 Mon Sep 17 00:00:00 2001 From: Adam Tunnic Date: Fri, 12 Feb 2021 12:19:44 -0500 Subject: [PATCH 2/3] Update README.md --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index b2fbe1e3..1b058598 100644 --- a/README.md +++ b/README.md @@ -71,16 +71,16 @@ that code being subject to the APL v2. - Do not include any code that unconditionally adds to Dynmap's hosting requirements - for example, support for a database can be added, but the use of the database (which likely depends on a database server being deployed and configured by the user) cannot become an unconditional requirement in order to run Dynmap. Features can add the option to exploit new or additional technologies, but cannot add unconditionally to the minimum requirements on the supported -platforms (which is what is needed to run the corresponiding MC server, plus the Dynmap plugin or mod) +platforms (which is what is needed to run the corresponding MC server, plus the Dynmap plugin or mod) - Dynmap is built and supports running on Java 8 - it can run on newer versions, but any contributed code and dependencies MUST support being compiled and run using just Java 8. -- Don't introduce other language depdendencies - Java only: no Kotlin, Scala, JRuby, whatever. They just add runtime dependencies that most of the platforms lack, +- Don't introduce other language dependencies - Java only: no Kotlin, Scala, JRuby, whatever. They just add runtime dependencies that most of the platforms lack, and language skills above and beyond the Java language requirements the code base already mandates, which just creates obstacles to other people contributing. - Similarly, do not update existing libraries and dependencies - these are often tied to the versions on various platforms, and updates will likely break runtime - Do not include code specific to other plugins or mods. Dynmap has APIs for the purpose of avoiding the problem of working with other mods - there are many 'Dynmap-XXX' mods and plugins which use the APIs to provide support for other mods and plugins (WorldGuard, Nucleus, Citizens, dozens of others). Maintaining interfaces in Dynmap particular to dozens of mods on multiple versions of multiple platforms is unmanageable, so we don't do it. The ONLY exception currently -are security mods - although, even for those, leverage of platform-standard security interfaces is always preferred (e.g. Sponge or Bukket standard permissions) +are security mods - although, even for those, leverage of platform-standard security interfaces is always preferred (e.g. Sponge or Bukkit standard permissions) # Porting, Supporting Other Platforms, Customized Dynmap Builds While Dynmap is open source, subject to the Apache Public License, v2, the Dynmap team does have specific policies and requirements for anyone that would From b54ed3a0b690ac7f138c70485f37dfa6e45e3527 Mon Sep 17 00:00:00 2001 From: Adam Tunnic Date: Fri, 12 Feb 2021 12:22:12 -0500 Subject: [PATCH 3/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 38cb3334..f943524c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -26,16 +26,16 @@ that code being subject to the APL v2. - Do not include any code that unconditionally adds to Dynmap's hosting requirements - for example, support for a database can be added, but the use of the database (which likely depends on a database server being deployed and configured by the user) cannot become an unconditional requirement in order to run Dynmap. Features can add the option to exploit new or additional technologies, but cannot add unconditionally to the minimum requirements on the supported -platforms (which is what is needed to run the corresponiding MC server, plus the Dynmap plugin or mod) +platforms (which is what is needed to run the corresponding MC server, plus the Dynmap plugin or mod) - Dynmap is built and supports running on Java 8 - it can run on newer versions, but any contributed code and dependencies MUST support being compiled and run using just Java 8. -- Don't introduce other language depdendencies - Java only: no Kotlin, Scala, JRuby, whatever. They just add runtime dependencies that most of the platforms lack, +- Don't introduce other language dependencies - Java only: no Kotlin, Scala, JRuby, whatever. They just add runtime dependencies that most of the platforms lack, and language skills above and beyond the Java language requirements the code base already mandates, which just creates obstacles to other people contributing. - Similarly, do not update existing libraries and dependencies - these are often tied to the versions on various platforms, and updates will likely break runtime - Do not include code specific to other plugins or mods. Dynmap has APIs for the purpose of avoiding the problem of working with other mods - there are many 'Dynmap-XXX' mods and plugins which use the APIs to provide support for other mods and plugins (WorldGuard, Nucleus, Citizens, dozens of others). Maintaining interfaces in Dynmap particular to dozens of mods on multiple versions of multiple platforms is unmanageable, so we don't do it. The ONLY exception currently -are security mods - although, even for those, leverage of platform-standard security interfaces is always preferred (e.g. Sponge or Bukket standard permissions) +are security mods - although, even for those, leverage of platform-standard security interfaces is always preferred (e.g. Sponge or Bukkit standard permissions) ## Porting, Supporting Other Platforms, Customized Dynmap Builds While Dynmap is open source, subject to the Apache Public License, v2, the Dynmap team does have specific policies and requirements for anyone that would