From 0c8eeb20f89a460b2ff14eab8c3b3eb53b3bc489 Mon Sep 17 00:00:00 2001
From: ganfra <francoisg@element.io>
Date: Tue, 24 Jan 2023 17:41:56 +0100
Subject: [PATCH] Clean

---
 .../androidutils/ExampleInstrumentedTest.kt   | 40 -------------------
 .../androidutils/ui/DimensionConverter.kt     |  2 +-
 .../libraries/androidutils/ExampleUnitTest.kt | 33 ---------------
 .../core/extensions/BasicExtensions.kt        |  1 -
 4 files changed, 1 insertion(+), 75 deletions(-)
 delete mode 100644 libraries/androidutils/src/androidTest/java/io/element/android/libraries/androidutils/ExampleInstrumentedTest.kt
 delete mode 100644 libraries/androidutils/src/test/java/io/element/android/libraries/androidutils/ExampleUnitTest.kt

diff --git a/libraries/androidutils/src/androidTest/java/io/element/android/libraries/androidutils/ExampleInstrumentedTest.kt b/libraries/androidutils/src/androidTest/java/io/element/android/libraries/androidutils/ExampleInstrumentedTest.kt
deleted file mode 100644
index ce92608bfb..0000000000
--- a/libraries/androidutils/src/androidTest/java/io/element/android/libraries/androidutils/ExampleInstrumentedTest.kt
+++ /dev/null
@@ -1,40 +0,0 @@
-/*
- * Copyright (c) 2023 New Vector Ltd
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package io.element.android.libraries.androidutils
-
-import androidx.test.platform.app.InstrumentationRegistry
-import androidx.test.ext.junit.runners.AndroidJUnit4
-
-import org.junit.Test
-import org.junit.runner.RunWith
-
-import org.junit.Assert.*
-
-/**
- * Instrumented test, which will execute on an Android device.
- *
- * See [testing documentation](http://d.android.com/tools/testing).
- */
-@RunWith(AndroidJUnit4::class)
-class ExampleInstrumentedTest {
-    @Test
-    fun useAppContext() {
-        // Context of the app under test.
-        val appContext = InstrumentationRegistry.getInstrumentation().targetContext
-        assertEquals("io.element.android.libraries.androidutils.test", appContext.packageName)
-    }
-}
diff --git a/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/ui/DimensionConverter.kt b/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/ui/DimensionConverter.kt
index 71fb1c7070..beead850b3 100644
--- a/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/ui/DimensionConverter.kt
+++ b/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/ui/DimensionConverter.kt
@@ -19,7 +19,7 @@ import android.content.res.Resources
 import android.util.TypedValue
 import androidx.annotation.Px
 
-class DimensionConverter(val resources: Resources) {
+class DimensionConverter(private val resources: Resources) {
 
     @Px
     fun dpToPx(dp: Int): Int {
diff --git a/libraries/androidutils/src/test/java/io/element/android/libraries/androidutils/ExampleUnitTest.kt b/libraries/androidutils/src/test/java/io/element/android/libraries/androidutils/ExampleUnitTest.kt
deleted file mode 100644
index 489e18e717..0000000000
--- a/libraries/androidutils/src/test/java/io/element/android/libraries/androidutils/ExampleUnitTest.kt
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Copyright (c) 2023 New Vector Ltd
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package io.element.android.libraries.androidutils
-
-import org.junit.Test
-
-import org.junit.Assert.*
-
-/**
- * Example local unit test, which will execute on the development machine (host).
- *
- * See [testing documentation](http://d.android.com/tools/testing).
- */
-class ExampleUnitTest {
-    @Test
-    fun addition_isCorrect() {
-        assertEquals(4, 2 + 2)
-    }
-}
diff --git a/libraries/core/src/main/kotlin/io/element/android/libraries/core/extensions/BasicExtensions.kt b/libraries/core/src/main/kotlin/io/element/android/libraries/core/extensions/BasicExtensions.kt
index e5b9d3d06f..b845a5efeb 100644
--- a/libraries/core/src/main/kotlin/io/element/android/libraries/core/extensions/BasicExtensions.kt
+++ b/libraries/core/src/main/kotlin/io/element/android/libraries/core/extensions/BasicExtensions.kt
@@ -16,7 +16,6 @@
 
 package io.element.android.libraries.core.extensions
 
-
 fun Boolean.toOnOff() = if (this) "ON" else "OFF"
 
 inline fun <T> T.ooi(block: (T) -> Unit): T = also(block)