From 2d274a9b3486c242630bfa5bb227e37353ba2fdf Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Thu, 12 Sep 2024 14:48:07 +0200
Subject: [PATCH] Add unit test on RoomDescriptionMapper

---
 .../roomdirectory/RoomDescriptionMapper.kt    | 14 +++--
 .../RoomDescriptionMapperTest.kt              | 60 +++++++++++++++++++
 2 files changed, 69 insertions(+), 5 deletions(-)
 create mode 100644 libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapperTest.kt

diff --git a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapper.kt b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapper.kt
index e91242f165..267de74ba7 100644
--- a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapper.kt
+++ b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapper.kt
@@ -21,13 +21,17 @@ class RoomDescriptionMapper {
             topic = roomDescription.topic,
             avatarUrl = roomDescription.avatarUrl,
             alias = roomDescription.alias?.let(::RoomAlias),
-            joinRule = when (roomDescription.joinRule) {
-                PublicRoomJoinRule.PUBLIC -> RoomDescription.JoinRule.PUBLIC
-                PublicRoomJoinRule.KNOCK -> RoomDescription.JoinRule.KNOCK
-                null -> RoomDescription.JoinRule.UNKNOWN
-            },
+            joinRule = roomDescription.joinRule.map(),
             isWorldReadable = roomDescription.isWorldReadable,
             numberOfMembers = roomDescription.joinedMembers.toLong(),
         )
     }
 }
+
+internal fun PublicRoomJoinRule?.map(): RoomDescription.JoinRule {
+    return when (this) {
+        PublicRoomJoinRule.PUBLIC -> RoomDescription.JoinRule.PUBLIC
+        PublicRoomJoinRule.KNOCK -> RoomDescription.JoinRule.KNOCK
+        null -> RoomDescription.JoinRule.UNKNOWN
+    }
+}
diff --git a/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapperTest.kt b/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapperTest.kt
new file mode 100644
index 0000000000..307cc33b54
--- /dev/null
+++ b/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomdirectory/RoomDescriptionMapperTest.kt
@@ -0,0 +1,60 @@
+/*
+ * Copyright 2024 New Vector Ltd.
+ *
+ * SPDX-License-Identifier: AGPL-3.0-only
+ * Please see LICENSE in the repository root for full details.
+ */
+
+package io.element.android.libraries.matrix.impl.roomdirectory
+
+import com.google.common.truth.Truth.assertThat
+import io.element.android.libraries.matrix.api.roomdirectory.RoomDescription
+import io.element.android.libraries.matrix.test.A_ROOM_ALIAS
+import io.element.android.libraries.matrix.test.A_ROOM_ID
+import io.element.android.libraries.matrix.test.roomdirectory.aRoomDescription
+import org.junit.Test
+import org.matrix.rustcomponents.sdk.PublicRoomJoinRule
+import org.matrix.rustcomponents.sdk.RoomDescription as RustRoomDescription
+
+class RoomDescriptionMapperTest {
+    @Test
+    fun map() {
+        assertThat(RoomDescriptionMapper().map(aRustRoomDescription())).isEqualTo(
+            aRoomDescription(
+                roomId = A_ROOM_ID,
+                name = "name",
+                topic = "topic",
+                alias = A_ROOM_ALIAS,
+                avatarUrl = "avatarUrl",
+                joinRule = RoomDescription.JoinRule.PUBLIC,
+                isWorldReadable = true,
+                joinedMembers = 2L
+            )
+        )
+    }
+
+    @Test
+    fun mapWithNullAlias() {
+        assertThat(RoomDescriptionMapper().map(aRustRoomDescription().copy(alias = null)).alias).isNull()
+    }
+
+    @Test
+    fun `map join rule`() {
+        assertThat(PublicRoomJoinRule.PUBLIC.map()).isEqualTo(RoomDescription.JoinRule.PUBLIC)
+        assertThat(PublicRoomJoinRule.KNOCK.map()).isEqualTo(RoomDescription.JoinRule.KNOCK)
+        assertThat(null.map()).isEqualTo(RoomDescription.JoinRule.UNKNOWN)
+    }
+}
+
+internal fun aRustRoomDescription(): RustRoomDescription {
+    return RustRoomDescription(
+        roomId = A_ROOM_ID.value,
+        name = "name",
+        topic = "topic",
+        alias = A_ROOM_ALIAS.value,
+        avatarUrl = "avatarUrl",
+        joinRule = PublicRoomJoinRule.PUBLIC,
+        isWorldReadable = true,
+        joinedMembers = 2u
+    )
+}