Remove FeatureFlag.IncomingShare

app/src/main/AndroidManifest.xml

@@ -147,14 +147,6 @@
                 <data android:host="user" />
                 <data android:host="room" />
             </intent-filter>
-        </activity>
-
-        <!-- Using an activity-alias for incoming share intent, in order
-        to be able to disable the feature programmatically -->
-        <activity-alias
-            android:name=".ShareActivity"
-            android:exported="true"
-            android:targetActivity=".MainActivity">
             <!-- Incoming share simple -->
             <intent-filter>
                 <action android:name="android.intent.action.SEND" />
@@ -171,7 +163,7 @@
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.OPENABLE" />
             </intent-filter>
-        </activity-alias>
+        </activity>
 
         <provider
             android:name="androidx.core.content.FileProvider"

appnav/build.gradle.kts

@@ -63,7 +63,6 @@ dependencies {
     testImplementation(projects.features.networkmonitor.test)
     testImplementation(projects.tests.testutils)
     testImplementation(projects.features.rageshake.test)
-    testImplementation(projects.features.share.test)
     testImplementation(projects.services.appnavstate.test)
     testImplementation(projects.services.analytics.test)
     testImplementation(libs.test.appyx.junit)

appnav/src/main/kotlin/io/element/android/appnav/root/RootPresenter.kt

@@ -14,7 +14,6 @@ import androidx.compose.runtime.getValue
 import im.vector.app.features.analytics.plan.SuperProperties
 import io.element.android.features.rageshake.api.crash.CrashDetectionState
 import io.element.android.features.rageshake.api.detection.RageshakeDetectionState
-import io.element.android.features.share.api.ShareService
 import io.element.android.libraries.architecture.Presenter
 import io.element.android.libraries.matrix.api.SdkMetadata
 import io.element.android.services.analytics.api.AnalyticsService
@@ -26,7 +25,6 @@ class RootPresenter @Inject constructor(
     private val rageshakeDetectionPresenter: Presenter<RageshakeDetectionState>,
     private val appErrorStateService: AppErrorStateService,
     private val analyticsService: AnalyticsService,
-    private val shareService: ShareService,
     private val sdkMetadata: SdkMetadata,
 ) : Presenter<RootState> {
     @Composable
@@ -45,10 +43,6 @@ class RootPresenter @Inject constructor(
             )
         }
 
-        LaunchedEffect(Unit) {
-            shareService.observeFeatureFlag(this)
-        }
-
         return RootState(
             rageshakeDetectionState = rageshakeDetectionState,
             crashDetectionState = crashDetectionState,

appnav/src/test/kotlin/io/element/android/appnav/RootPresenterTest.kt

@@ -14,16 +14,12 @@ import com.google.common.truth.Truth.assertThat
 import io.element.android.appnav.root.RootPresenter
 import io.element.android.features.rageshake.api.crash.aCrashDetectionState
 import io.element.android.features.rageshake.api.detection.aRageshakeDetectionState
-import io.element.android.features.share.api.ShareService
-import io.element.android.features.share.test.FakeShareService
 import io.element.android.libraries.matrix.test.FakeSdkMetadata
 import io.element.android.services.analytics.test.FakeAnalyticsService
 import io.element.android.services.apperror.api.AppErrorState
 import io.element.android.services.apperror.api.AppErrorStateService
 import io.element.android.services.apperror.impl.DefaultAppErrorStateService
 import io.element.android.tests.testutils.WarmUpRule
-import io.element.android.tests.testutils.lambda.lambdaRecorder
-import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.test.runTest
 import org.junit.Rule
 import org.junit.Test
@@ -43,22 +39,6 @@ class RootPresenterTest {
         }
     }
 
-    @Test
-    fun `present - check that share service is invoked`() = runTest {
-        val lambda = lambdaRecorder<CoroutineScope, Unit> { _ -> }
-        val presenter = createRootPresenter(
-            shareService = FakeShareService {
-                lambda(it)
-            }
-        )
-        moleculeFlow(RecompositionMode.Immediate) {
-            presenter.present()
-        }.test {
-            skipItems(1)
-            lambda.assertions().isCalledOnce()
-        }
-    }
-
     @Test
     fun `present - passes app error state`() = runTest {
         val presenter = createRootPresenter(
@@ -82,14 +62,12 @@ class RootPresenterTest {
 
     private fun createRootPresenter(
         appErrorService: AppErrorStateService = DefaultAppErrorStateService(),
-        shareService: ShareService = FakeShareService {},
     ): RootPresenter {
         return RootPresenter(
             crashDetectionPresenter = { aCrashDetectionState() },
             rageshakeDetectionPresenter = { aRageshakeDetectionState() },
             appErrorStateService = appErrorService,
             analyticsService = FakeAnalyticsService(),
-            shareService = shareService,
             sdkMetadata = FakeSdkMetadata("sha")
         )
     }

features/share/api/src/main/kotlin/io/element/android/features/share/api/ShareService.kt

@@ -1,14 +0,0 @@
-/*
- * Copyright 2024 New Vector Ltd.
- *
- * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
- * Please see LICENSE files in the repository root for full details.
- */
-
-package io.element.android.features.share.api
-
-import kotlinx.coroutines.CoroutineScope
-
-interface ShareService {
-    fun observeFeatureFlag(coroutineScope: CoroutineScope)
-}

features/share/impl/src/main/kotlin/io/element/android/features/share/impl/DefaultShareService.kt

@@ -1,74 +0,0 @@
-/*
- * Copyright 2024 New Vector Ltd.
- *
- * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
- * Please see LICENSE files in the repository root for full details.
- */
-
-package io.element.android.features.share.impl
-
-import android.content.ComponentName
-import android.content.Context
-import android.content.pm.PackageManager
-import com.squareup.anvil.annotations.ContributesBinding
-import io.element.android.features.share.api.ShareService
-import io.element.android.libraries.di.AppScope
-import io.element.android.libraries.di.ApplicationContext
-import io.element.android.libraries.featureflag.api.FeatureFlagService
-import io.element.android.libraries.featureflag.api.FeatureFlags
-import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.flow.launchIn
-import kotlinx.coroutines.flow.onEach
-import timber.log.Timber
-import javax.inject.Inject
-
-@ContributesBinding(AppScope::class)
-class DefaultShareService @Inject constructor(
-    private val featureFlagService: FeatureFlagService,
-    @ApplicationContext private val context: Context,
-) : ShareService {
-    override fun observeFeatureFlag(coroutineScope: CoroutineScope) {
-        val shareActivityComponent = getShareActivityComponent()
-            ?: return Unit.also {
-                Timber.w("ShareActivity not found")
-            }
-        featureFlagService.isFeatureEnabledFlow(FeatureFlags.IncomingShare)
-            .onEach { enabled ->
-                shareActivityComponent.enableOrDisable(enabled)
-            }
-            .launchIn(coroutineScope)
-    }
-
-    private fun getShareActivityComponent(): ComponentName? {
-        return context.packageManager
-            .getPackageInfo(
-                context.packageName,
-                PackageManager.GET_ACTIVITIES or PackageManager.MATCH_DISABLED_COMPONENTS
-            )
-            .activities
-            ?.firstOrNull { it.name.endsWith(".ShareActivity") }
-            ?.let { shareActivityInfo ->
-                ComponentName(
-                    shareActivityInfo.packageName,
-                    shareActivityInfo.name,
-                )
-            }
-    }
-
-    private fun ComponentName.enableOrDisable(enabled: Boolean) {
-        val state = if (enabled) {
-            PackageManager.COMPONENT_ENABLED_STATE_DEFAULT
-        } else {
-            PackageManager.COMPONENT_ENABLED_STATE_DISABLED
-        }
-        try {
-            context.packageManager.setComponentEnabledSetting(
-                this,
-                state,
-                PackageManager.DONT_KILL_APP,
-            )
-        } catch (e: Exception) {
-            Timber.e(e, "Failed to enable or disable the component")
-        }
-    }
-}

features/share/test/build.gradle.kts

@@ -1,19 +0,0 @@
-/*
- * Copyright 2024 New Vector Ltd.
- *
- * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
- * Please see LICENSE files in the repository root for full details.
- */
-plugins {
-    id("io.element.android-library")
-}
-
-android {
-    namespace = "io.element.android.features.share.test"
-}
-
-dependencies {
-    implementation(projects.features.share.api)
-    implementation(libs.coroutines.core)
-    implementation(projects.tests.testutils)
-}

features/share/test/src/main/kotlin/io/element/android/features/share/test/FakeShareService.kt

@@ -1,20 +0,0 @@
-/*
- * Copyright 2024 New Vector Ltd.
- *
- * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
- * Please see LICENSE files in the repository root for full details.
- */
-
-package io.element.android.features.share.test
-
-import io.element.android.features.share.api.ShareService
-import io.element.android.tests.testutils.lambda.lambdaError
-import kotlinx.coroutines.CoroutineScope
-
-class FakeShareService(
-    private val observeFeatureFlagLambda: (CoroutineScope) -> Unit = { lambdaError() }
-) : ShareService {
-    override fun observeFeatureFlag(coroutineScope: CoroutineScope) {
-        observeFeatureFlagLambda(coroutineScope)
-    }
-}

libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlags.kt

@@ -82,13 +82,6 @@ enum class FeatureFlags(
         defaultValue = { OnBoardingConfig.CAN_LOGIN_WITH_QR_CODE },
         isFinished = false,
     ),
-    IncomingShare(
-        key = "feature.incomingShare",
-        title = "Incoming Share support",
-        description = "Allow the application to receive data from other applications",
-        defaultValue = { true },
-        isFinished = false,
-    ),
     PinnedEvents(
         key = "feature.pinnedEvents",
         title = "Pinned Events",