From 8f81317f45cd6064b481dfaab7d538b96453290d Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Wed, 22 Oct 2025 10:18:44 +0200 Subject: [PATCH] Fix tests. --- .../DefaultBugReporterUrlProviderTest.kt | 25 +++++++++++++------ 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporterUrlProviderTest.kt b/features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporterUrlProviderTest.kt index fb7464adf7..32e38075d8 100644 --- a/features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporterUrlProviderTest.kt +++ b/features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporterUrlProviderTest.kt @@ -11,16 +11,19 @@ import app.cash.turbine.test import com.google.common.truth.Truth.assertThat import io.element.android.appconfig.RageshakeConfig import io.element.android.features.enterprise.api.BugReportUrl +import io.element.android.features.enterprise.api.EnterpriseService import io.element.android.features.enterprise.test.FakeEnterpriseService +import io.element.android.libraries.sessionstorage.api.SessionStore +import io.element.android.libraries.sessionstorage.test.InMemorySessionStore import kotlinx.coroutines.test.runTest import okhttp3.HttpUrl.Companion.toHttpUrl import org.junit.Test class DefaultBugReporterUrlProviderTest { @Test - fun `provide return values when there is an rageshake app name`() = runTest { + fun `provide returns values when there is an rageshake app name`() = runTest { val enterpriseService = FakeEnterpriseService() - val sut = DefaultBugReporterUrlProvider( + val sut = createDefaultBugReporterUrlProvider( bugReportAppNameProvider = { "rageshakeAppName" }, enterpriseService = enterpriseService, ) @@ -36,15 +39,21 @@ class DefaultBugReporterUrlProviderTest { } @Test - fun `provide return null when there is no rageshake app name`() = runTest { - val enterpriseService = FakeEnterpriseService() - val sut = DefaultBugReporterUrlProvider( - bugReportAppNameProvider = { "" }, - enterpriseService = enterpriseService, - ) + fun `provide returns null when there is no rageshake app name`() = runTest { + val sut = createDefaultBugReporterUrlProvider() sut.provide().test { assertThat(awaitItem()).isNull() awaitComplete() } } } + +private fun createDefaultBugReporterUrlProvider( + bugReportAppNameProvider: BugReportAppNameProvider = BugReportAppNameProvider { "" }, + enterpriseService: EnterpriseService = FakeEnterpriseService(), + sessionStore: SessionStore = InMemorySessionStore(), +) = DefaultBugReporterUrlProvider( + bugReportAppNameProvider = bugReportAppNameProvider, + enterpriseService = enterpriseService, + sessionStore = sessionStore, +)