Use @TestParameter instead of doing the work manually.

This commit is contained in:
Benoit Marty 2026-04-15 08:39:14 +02:00
parent 4cc9c77264
commit 937973570a

View file

@ -11,6 +11,9 @@
package io.element.android.features.space.impl.root package io.element.android.features.space.impl.root
import com.google.common.truth.Truth.assertThat import com.google.common.truth.Truth.assertThat
import com.google.testing.junit.testparameterinjector.KotlinTestParameters.namedTestValues
import com.google.testing.junit.testparameterinjector.TestParameter
import com.google.testing.junit.testparameterinjector.TestParameterInjector
import io.element.android.features.invite.api.SeenInvitesStore import io.element.android.features.invite.api.SeenInvitesStore
import io.element.android.features.invite.api.acceptdecline.AcceptDeclineInviteEvents import io.element.android.features.invite.api.acceptdecline.AcceptDeclineInviteEvents
import io.element.android.features.invite.api.acceptdecline.AcceptDeclineInviteState import io.element.android.features.invite.api.acceptdecline.AcceptDeclineInviteState
@ -49,8 +52,10 @@ import kotlinx.coroutines.test.TestScope
import kotlinx.coroutines.test.advanceUntilIdle import kotlinx.coroutines.test.advanceUntilIdle
import kotlinx.coroutines.test.runTest import kotlinx.coroutines.test.runTest
import org.junit.Test import org.junit.Test
import org.junit.runner.RunWith
import im.vector.app.features.analytics.plan.JoinedRoom as AnalyticsJoinedRoom import im.vector.app.features.analytics.plan.JoinedRoom as AnalyticsJoinedRoom
@RunWith(TestParameterInjector::class)
class SpacePresenterTest { class SpacePresenterTest {
@Test @Test
fun `present - initial state`() = runTest { fun `present - initial state`() = runTest {
@ -259,21 +264,11 @@ class SpacePresenterTest {
} }
@Test @Test
fun `present - accept invite is transmitted to acceptDeclineInviteState`() { fun `present - invite action is transmitted to acceptDeclineInviteState`(
`invite action is transmitted to acceptDeclineInviteState`( @TestParameter acceptInvite: Boolean = namedTestValues(
acceptInvite = true, "accept" to true,
) "decline" to false,
} ),
@Test
fun `present - decline invite is transmitted to acceptDeclineInviteState`() {
`invite action is transmitted to acceptDeclineInviteState`(
acceptInvite = false,
)
}
private fun `invite action is transmitted to acceptDeclineInviteState`(
acceptInvite: Boolean,
) = runTest { ) = runTest {
val eventRecorder = EventsRecorder<AcceptDeclineInviteEvents>() val eventRecorder = EventsRecorder<AcceptDeclineInviteEvents>()
val anInvitedRoom = aSpaceRoom( val anInvitedRoom = aSpaceRoom(