Sulkta-Coop/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Try to improve Danger rule for PNGs to ignore screenshots (#234)

Browse source
This commit is contained in:
Jorge Martin Espinosa 2023-03-20 15:09:50 +01:00 • committed by GitHub
parent 73b79cadd0
commit 93a77d94c1
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tools/danger/dangerfile.js
View file

@ -107,7 +107,9 @@ if (hasChangedViews) {
}
// Check for pngs on resources
const hasPngs = editedFiles.filter(file => file.toLowerCase().endsWith(".png")).length > 0
const hasPngs = editedFiles.filter(file => {
file.toLowerCase().endsWith(".png") && !file.includes("snapshots/images/") // Exclude screenshots
}).length > 0
if (hasPngs) {
warn("You seem to have made changes to some images. Please consider using an vector drawable.")
}