Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MediaViewer: add Share action as a main action.

Browse source
This commit is contained in:
Benoit Marty 2026-04-21 16:14:07 +02:00
parent 54efb46294
commit 97ae775df5
2 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerView.kt
View file

@ -214,6 +214,9 @@ fun MediaViewerView(
data = currentData,
canShowInfo = state.canShowInfo,
onBackClick = onBackClick,
onShareClick = {
state.eventSink(MediaViewerEvent.Share(currentData))
},
onInfoClick = {
state.eventSink(MediaViewerEvent.OpenInfo(currentData))
},
@ -457,6 +460,7 @@ private fun MediaViewerTopBar(
data: MediaViewerPageData.MediaViewerData,
canShowInfo: Boolean,
onBackClick: () -> Unit,
onShareClick: () -> Unit,
onInfoClick: () -> Unit,
eventSink: (MediaViewerEvent) -> Unit,
) {
@ -514,6 +518,15 @@ private fun MediaViewerTopBar(
)
}
}
IconButton(
onClick = onShareClick,
enabled = actionsEnabled,
) {
Icon(
imageVector = CompoundIcons.ShareAndroid(),
contentDescription = stringResource(id = CommonStrings.action_share),
)
}
if (canShowInfo) {
IconButton(
onClick = onInfoClick,

12
libraries/mediaviewer/impl/src/test/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerViewTest.kt
View file

@ -86,6 +86,18 @@ class MediaViewerViewTest {
)
}
@Test
fun `clicking on top action share emits expected Event`() {
val data = aMediaViewerPageData(
downloadedMedia = AsyncData.Success(aLocalMedia(uri = mockMediaUrl)),
)
testMenuAction(
data,
CommonStrings.action_share,
MediaViewerEvent.Share(data),
)
}
private fun testMenuAction(
data: MediaViewerPageData.MediaViewerData,
contentDescriptionRes: Int,