Sulkta-Coop/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add Konsist test to use isNull() instead of isEqualTo(null), and fix existing issue.

Browse source
This commit is contained in:
Benoit Marty 2023-12-04 15:30:57 +01:00
parent 9e731f40ca
commit abd90acd8c
5 changed files with 19 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
features/call/src/test/kotlin/io/element/android/features/call/MapWebkitPermissionsTest.kt
View file

@ -41,5 +41,4 @@ class MapWebkitPermissionsTest {
val permission = mapWebkitPermissions(arrayOf(PermissionRequest.RESOURCE_PROTECTED_MEDIA_ID))
assertThat(permission).isEmpty()
}
}

4
features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/components/reactionsummary/ReactionSummaryPresenterTests.kt
View file

@ -53,7 +53,7 @@ class ReactionSummaryPresenterTests {
presenter.present()
}.test {
val initialState = awaitItem()
assertThat(initialState.target).isEqualTo(null)
assertThat(initialState.target).isNull()
initialState.eventSink(summaryEvent)
assertThat(awaitItem().target).isNotNull()
@ -69,7 +69,7 @@ class ReactionSummaryPresenterTests {
presenter.present()
}.test {
val initialState = awaitItem()
assertThat(initialState.target).isEqualTo(null)
assertThat(initialState.target).isNull()
initialState.eventSink(summaryEvent)
val reactions = awaitItem().target?.reactions

2
features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/model/InReplyToMetadataKtTest.kt
View file

@ -284,7 +284,7 @@ class InReplyToMetadataKtTest {
).metadata()
}.test {
awaitItem().let {
assertThat(it).isEqualTo(null)
assertThat(it).isNull()
}
}
}

8
features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/voicemessages/timeline/DefaultVoiceMessagePlayerTest.kt
View file

@ -149,7 +149,7 @@ class DefaultVoiceMessagePlayerTest {
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(0)
assertThat(it.duration).isEqualTo(null)
assertThat(it.duration).isNull()
}
matchReadyState(1_000L)
player2.play()
@ -177,7 +177,7 @@ class DefaultVoiceMessagePlayerTest {
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(0)
assertThat(it.duration).isEqualTo(null)
assertThat(it.duration).isNull()
}
matchReadyState(1_000L)
player1.play()
@ -238,7 +238,7 @@ class DefaultVoiceMessagePlayerTest {
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(2000)
assertThat(it.duration).isEqualTo(null)
assertThat(it.duration).isNull()
}
assertThat(player.prepare().isSuccess).isTrue()
awaitItem().let {
@ -300,7 +300,7 @@ private suspend fun TurbineTestContext<VoiceMessagePlayer.State>.matchInitialSta
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
assertThat(it.currentPosition).isEqualTo(0)
assertThat(it.duration).isEqualTo(null)
assertThat(it.duration).isNull()
}
}

12
tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt
View file

@ -98,4 +98,16 @@ class KonsistTestTest {
functionDeclaration.text.contains("isEqualTo(empty")
}
}
@Test
fun `use isNull() instead of isEqualTo(null)`() {
Konsist
.scopeFromTest()
.functions()
// Exclude self
.withoutName("use isNull() instead of isEqualTo(null)")
.assertFalse { functionDeclaration ->
functionDeclaration.text.contains("isEqualTo(null)")
}
}
}