From afdfe28ef40d559c6635d604d68df02336fe2ec2 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Thu, 23 Oct 2025 15:23:11 +0200 Subject: [PATCH] Remove dependency on `AppNavigationStateService` from `DefaultUnifiedPushCurrentUserPushConfigProvider` --- .../libraries/push/impl/DefaultPushService.kt | 2 +- .../libraries/push/impl/test/TestPush.kt | 6 +-- .../push/impl/DefaultPushServiceTest.kt | 10 ++-- .../push/impl/test/DefaultTestPushTest.kt | 4 +- .../libraries/push/impl/test/FakeTestPush.kt | 6 +-- .../{CurrentUserPushConfig.kt => Config.kt} | 2 +- .../pushproviders/api/PushProvider.kt | 2 +- .../firebase/FirebasePushProvider.kt | 6 +-- .../firebase/FirebasePushProviderTest.kt | 8 +-- .../pushproviders/test/FakePushProvider.kt | 8 +-- .../libraries/pushproviders/test/Fixtures.kt | 6 +-- .../unifiedpush/build.gradle.kts | 2 - ...nifiedPushCurrentUserPushConfigProvider.kt | 37 ------------- .../unifiedpush/UnifiedPushProvider.kt | 8 +-- .../UnifiedPushSessionPushConfigProvider.kt | 34 ++++++++++++ .../UnifiedPushMatrixGatewayTest.kt | 12 +++-- ...edPushCurrentUserPushConfigProviderTest.kt | 52 +++---------------- .../unifiedpush/UnifiedPushProviderTest.kt | 16 +++--- ...nifiedPushCurrentUserPushConfigProvider.kt | 20 ------- ...akeUnifiedPushSessionPushConfigProvider.kt | 21 ++++++++ .../UnifiedPushMatrixGatewayTestTest.kt | 22 ++++---- 21 files changed, 124 insertions(+), 160 deletions(-) rename libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/{CurrentUserPushConfig.kt => Config.kt} (89%) delete mode 100644 libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushCurrentUserPushConfigProvider.kt create mode 100644 libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushSessionPushConfigProvider.kt delete mode 100644 libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushCurrentUserPushConfigProvider.kt create mode 100644 libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushSessionPushConfigProvider.kt diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/DefaultPushService.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/DefaultPushService.kt index 9cae53a848..d0a5e6b60f 100644 --- a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/DefaultPushService.kt +++ b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/DefaultPushService.kt @@ -99,7 +99,7 @@ class DefaultPushService( override suspend fun testPush(sessionId: SessionId): Boolean { val pushProvider = getCurrentPushProvider(sessionId) ?: return false - val config = pushProvider.getCurrentUserPushConfig() ?: return false + val config = pushProvider.getPushConfig(sessionId) ?: return false testPush.execute(config) return true } diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/test/TestPush.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/test/TestPush.kt index 72b76ee33d..98997c8b79 100644 --- a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/test/TestPush.kt +++ b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/test/TestPush.kt @@ -13,17 +13,17 @@ import io.element.android.appconfig.PushConfig import io.element.android.libraries.matrix.api.core.EventId import io.element.android.libraries.matrix.api.core.RoomId import io.element.android.libraries.push.impl.pushgateway.PushGatewayNotifyRequest -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config interface TestPush { - suspend fun execute(config: CurrentUserPushConfig) + suspend fun execute(config: Config) } @ContributesBinding(AppScope::class) class DefaultTestPush( private val pushGatewayNotifyRequest: PushGatewayNotifyRequest, ) : TestPush { - override suspend fun execute(config: CurrentUserPushConfig) { + override suspend fun execute(config: Config) { pushGatewayNotifyRequest.execute( PushGatewayNotifyRequest.Params( url = config.url, diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/DefaultPushServiceTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/DefaultPushServiceTest.kt index 03a039ab71..62567d3977 100644 --- a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/DefaultPushServiceTest.kt +++ b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/DefaultPushServiceTest.kt @@ -25,11 +25,11 @@ import io.element.android.libraries.push.impl.store.PushDataStore import io.element.android.libraries.push.impl.test.FakeTestPush import io.element.android.libraries.push.impl.test.TestPush import io.element.android.libraries.push.test.FakeGetCurrentPushProvider -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config import io.element.android.libraries.pushproviders.api.Distributor import io.element.android.libraries.pushproviders.api.PushProvider import io.element.android.libraries.pushproviders.test.FakePushProvider -import io.element.android.libraries.pushproviders.test.aCurrentUserPushConfig +import io.element.android.libraries.pushproviders.test.aSessionPushConfig import io.element.android.libraries.pushstore.api.UserPushStoreFactory import io.element.android.libraries.pushstore.api.clientsecret.PushClientSecretStore import io.element.android.libraries.pushstore.test.userpushstore.FakeUserPushStore @@ -62,10 +62,10 @@ class DefaultPushServiceTest { @Test fun `test push ok`() = runTest { - val aConfig = aCurrentUserPushConfig() - val testPushResult = lambdaRecorder { } + val aConfig = aSessionPushConfig() + val testPushResult = lambdaRecorder { } val aPushProvider = FakePushProvider( - currentUserPushConfig = aConfig + config = aConfig ) val defaultPushService = createDefaultPushService( pushProviders = setOf(aPushProvider), diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/DefaultTestPushTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/DefaultTestPushTest.kt index c3231097a0..3d8bc7e403 100644 --- a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/DefaultTestPushTest.kt +++ b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/DefaultTestPushTest.kt @@ -9,7 +9,7 @@ package io.element.android.libraries.push.impl.test import io.element.android.appconfig.PushConfig import io.element.android.libraries.push.impl.pushgateway.PushGatewayNotifyRequest -import io.element.android.libraries.pushproviders.test.aCurrentUserPushConfig +import io.element.android.libraries.pushproviders.test.aSessionPushConfig import io.element.android.tests.testutils.lambda.lambdaRecorder import io.element.android.tests.testutils.lambda.value import kotlinx.coroutines.test.runTest @@ -24,7 +24,7 @@ class DefaultTestPushTest { executeResult = executeResult, ) ) - val aConfig = aCurrentUserPushConfig() + val aConfig = aSessionPushConfig() defaultTestPush.execute(aConfig) executeResult.assertions() .isCalledOnce() diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/FakeTestPush.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/FakeTestPush.kt index f09832cc3b..d1867d3ff6 100644 --- a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/FakeTestPush.kt +++ b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/test/FakeTestPush.kt @@ -7,13 +7,13 @@ package io.element.android.libraries.push.impl.test -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config import io.element.android.tests.testutils.lambda.lambdaError class FakeTestPush( - private val executeResult: (CurrentUserPushConfig) -> Unit = { lambdaError() } + private val executeResult: (Config) -> Unit = { lambdaError() } ) : TestPush { - override suspend fun execute(config: CurrentUserPushConfig) { + override suspend fun execute(config: Config) { executeResult(config) } } diff --git a/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/CurrentUserPushConfig.kt b/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/Config.kt similarity index 89% rename from libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/CurrentUserPushConfig.kt rename to libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/Config.kt index 0d3bf0241f..a208b33d9c 100644 --- a/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/CurrentUserPushConfig.kt +++ b/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/Config.kt @@ -7,7 +7,7 @@ package io.element.android.libraries.pushproviders.api -data class CurrentUserPushConfig( +data class Config( val url: String, val pushKey: String, ) diff --git a/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/PushProvider.kt b/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/PushProvider.kt index 38a7135b75..e1142846ae 100644 --- a/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/PushProvider.kt +++ b/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/PushProvider.kt @@ -59,7 +59,7 @@ interface PushProvider { */ suspend fun onSessionDeleted(sessionId: SessionId) - suspend fun getCurrentUserPushConfig(): CurrentUserPushConfig? + suspend fun getPushConfig(sessionId: SessionId): Config? fun canRotateToken(): Boolean diff --git a/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProvider.kt b/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProvider.kt index 4f8c99cd3e..6df0bda642 100644 --- a/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProvider.kt +++ b/libraries/pushproviders/firebase/src/main/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProvider.kt @@ -13,7 +13,7 @@ import dev.zacsweers.metro.Inject import io.element.android.libraries.core.log.logger.LoggerTag import io.element.android.libraries.matrix.api.MatrixClient import io.element.android.libraries.matrix.api.core.SessionId -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config import io.element.android.libraries.pushproviders.api.Distributor import io.element.android.libraries.pushproviders.api.PushProvider import io.element.android.libraries.pushproviders.api.PusherSubscriber @@ -74,9 +74,9 @@ class FirebasePushProvider( */ override suspend fun onSessionDeleted(sessionId: SessionId) = Unit - override suspend fun getCurrentUserPushConfig(): CurrentUserPushConfig? { + override suspend fun getPushConfig(sessionId: SessionId): Config? { return firebaseStore.getFcmToken()?.let { fcmToken -> - CurrentUserPushConfig( + Config( url = firebaseGatewayProvider.getFirebaseGateway(), pushKey = fcmToken ) diff --git a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProviderTest.kt b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProviderTest.kt index 53ed52be07..642addf9c8 100644 --- a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProviderTest.kt +++ b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProviderTest.kt @@ -13,7 +13,7 @@ import io.element.android.libraries.matrix.test.AN_EXCEPTION import io.element.android.libraries.matrix.test.A_SESSION_ID import io.element.android.libraries.matrix.test.FakeMatrixClient import io.element.android.libraries.push.test.FakePusherSubscriber -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config import io.element.android.libraries.pushproviders.api.Distributor import io.element.android.libraries.pushproviders.api.PusherSubscriber import io.element.android.tests.testutils.lambda.lambdaRecorder @@ -152,7 +152,7 @@ class FirebasePushProviderTest { token = null ) ) - val result = firebasePushProvider.getCurrentUserPushConfig() + val result = firebasePushProvider.getPushConfig(A_SESSION_ID) assertThat(result).isNull() } @@ -163,8 +163,8 @@ class FirebasePushProviderTest { token = "aToken" ), ) - val result = firebasePushProvider.getCurrentUserPushConfig() - assertThat(result).isEqualTo(CurrentUserPushConfig(A_FIREBASE_GATEWAY, "aToken")) + val result = firebasePushProvider.getPushConfig(A_SESSION_ID) + assertThat(result).isEqualTo(Config(A_FIREBASE_GATEWAY, "aToken")) } @Test diff --git a/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/FakePushProvider.kt b/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/FakePushProvider.kt index afb4d833d4..55b3b754f9 100644 --- a/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/FakePushProvider.kt +++ b/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/FakePushProvider.kt @@ -9,7 +9,7 @@ package io.element.android.libraries.pushproviders.test import io.element.android.libraries.matrix.api.MatrixClient import io.element.android.libraries.matrix.api.core.SessionId -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config import io.element.android.libraries.pushproviders.api.Distributor import io.element.android.libraries.pushproviders.api.PushProvider import io.element.android.tests.testutils.lambda.lambdaError @@ -21,7 +21,7 @@ class FakePushProvider( private val distributors: List = listOf(Distributor("aDistributorValue", "aDistributorName")), private val currentDistributorValue: () -> String? = { lambdaError() }, private val currentDistributor: () -> Distributor? = { distributors.firstOrNull() }, - private val currentUserPushConfig: CurrentUserPushConfig? = null, + private val config: Config? = null, private val registerWithResult: (MatrixClient, Distributor) -> Result = { _, _ -> lambdaError() }, private val unregisterWithResult: (MatrixClient) -> Result = { lambdaError() }, private val onSessionDeletedLambda: (SessionId) -> Unit = { lambdaError() }, @@ -50,8 +50,8 @@ class FakePushProvider( onSessionDeletedLambda(sessionId) } - override suspend fun getCurrentUserPushConfig(): CurrentUserPushConfig? { - return currentUserPushConfig + override suspend fun getPushConfig(sessionId: SessionId): Config? { + return config } override fun canRotateToken(): Boolean { diff --git a/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/Fixtures.kt b/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/Fixtures.kt index cd3b95d672..698c8ed6cc 100644 --- a/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/Fixtures.kt +++ b/libraries/pushproviders/test/src/main/kotlin/io/element/android/libraries/pushproviders/test/Fixtures.kt @@ -7,12 +7,12 @@ package io.element.android.libraries.pushproviders.test -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config -fun aCurrentUserPushConfig( +fun aSessionPushConfig( url: String = "aUrl", pushKey: String = "aPushKey", -) = CurrentUserPushConfig( +) = Config( url = url, pushKey = pushKey, ) diff --git a/libraries/pushproviders/unifiedpush/build.gradle.kts b/libraries/pushproviders/unifiedpush/build.gradle.kts index e416ccf8bf..b6066c76ed 100644 --- a/libraries/pushproviders/unifiedpush/build.gradle.kts +++ b/libraries/pushproviders/unifiedpush/build.gradle.kts @@ -30,7 +30,6 @@ dependencies { implementation(projects.libraries.pushproviders.api) implementation(projects.libraries.architecture) implementation(projects.libraries.core) - implementation(projects.services.appnavstate.api) implementation(projects.services.toolbox.api) implementation(projects.libraries.network) @@ -53,5 +52,4 @@ dependencies { testImplementation(projects.libraries.pushstore.test) testImplementation(projects.libraries.troubleshoot.test) testImplementation(projects.services.toolbox.test) - testImplementation(projects.services.appnavstate.test) } diff --git a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushCurrentUserPushConfigProvider.kt b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushCurrentUserPushConfigProvider.kt deleted file mode 100644 index e66975b40c..0000000000 --- a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushCurrentUserPushConfigProvider.kt +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright 2024 New Vector Ltd. - * - * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial - * Please see LICENSE files in the repository root for full details. - */ - -package io.element.android.libraries.pushproviders.unifiedpush - -import dev.zacsweers.metro.AppScope -import dev.zacsweers.metro.ContributesBinding -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig -import io.element.android.libraries.pushstore.api.clientsecret.PushClientSecret -import io.element.android.services.appnavstate.api.AppNavigationStateService -import io.element.android.services.appnavstate.api.currentSessionId - -interface UnifiedPushCurrentUserPushConfigProvider { - suspend fun provide(): CurrentUserPushConfig? -} - -@ContributesBinding(AppScope::class) -class DefaultUnifiedPushCurrentUserPushConfigProvider( - private val pushClientSecret: PushClientSecret, - private val unifiedPushStore: UnifiedPushStore, - private val appNavigationStateService: AppNavigationStateService, -) : UnifiedPushCurrentUserPushConfigProvider { - override suspend fun provide(): CurrentUserPushConfig? { - val currentSession = appNavigationStateService.appNavigationState.value.navigationState.currentSessionId() ?: return null - val clientSecret = pushClientSecret.getSecretForUser(currentSession) - val url = unifiedPushStore.getPushGateway(clientSecret) ?: return null - val pushKey = unifiedPushStore.getEndpoint(clientSecret) ?: return null - return CurrentUserPushConfig( - url = url, - pushKey = pushKey, - ) - } -} diff --git a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProvider.kt b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProvider.kt index 92d7c9ebc3..e7321bad5f 100644 --- a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProvider.kt +++ b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProvider.kt @@ -12,7 +12,7 @@ import dev.zacsweers.metro.ContributesIntoSet import dev.zacsweers.metro.Inject import io.element.android.libraries.matrix.api.MatrixClient import io.element.android.libraries.matrix.api.core.SessionId -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config import io.element.android.libraries.pushproviders.api.Distributor import io.element.android.libraries.pushproviders.api.PushProvider import io.element.android.libraries.pushstore.api.clientsecret.PushClientSecret @@ -25,7 +25,7 @@ class UnifiedPushProvider( private val unRegisterUnifiedPushUseCase: UnregisterUnifiedPushUseCase, private val pushClientSecret: PushClientSecret, private val unifiedPushStore: UnifiedPushStore, - private val unifiedPushCurrentUserPushConfigProvider: UnifiedPushCurrentUserPushConfigProvider, + private val unifiedPushSessionPushConfigProvider: UnifiedPushSessionPushConfigProvider, ) : PushProvider { override val index = UnifiedPushConfig.INDEX override val name = UnifiedPushConfig.NAME @@ -62,8 +62,8 @@ class UnifiedPushProvider( unRegisterUnifiedPushUseCase.cleanup(clientSecret) } - override suspend fun getCurrentUserPushConfig(): CurrentUserPushConfig? { - return unifiedPushCurrentUserPushConfigProvider.provide() + override suspend fun getPushConfig(sessionId: SessionId): Config? { + return unifiedPushSessionPushConfigProvider.provide(sessionId) } override fun canRotateToken(): Boolean = false diff --git a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushSessionPushConfigProvider.kt b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushSessionPushConfigProvider.kt new file mode 100644 index 0000000000..dfd4adc954 --- /dev/null +++ b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushSessionPushConfigProvider.kt @@ -0,0 +1,34 @@ +/* + * Copyright 2024 New Vector Ltd. + * + * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial + * Please see LICENSE files in the repository root for full details. + */ + +package io.element.android.libraries.pushproviders.unifiedpush + +import dev.zacsweers.metro.AppScope +import dev.zacsweers.metro.ContributesBinding +import io.element.android.libraries.matrix.api.core.SessionId +import io.element.android.libraries.pushproviders.api.Config +import io.element.android.libraries.pushstore.api.clientsecret.PushClientSecret + +interface UnifiedPushSessionPushConfigProvider { + suspend fun provide(sessionId: SessionId): Config? +} + +@ContributesBinding(AppScope::class) +class DefaultUnifiedPushPushConfigProvider( + private val pushClientSecret: PushClientSecret, + private val unifiedPushStore: UnifiedPushStore, +) : UnifiedPushSessionPushConfigProvider { + override suspend fun provide(sessionId: SessionId): Config? { + val clientSecret = pushClientSecret.getSecretForUser(sessionId) + val url = unifiedPushStore.getPushGateway(clientSecret) ?: return null + val pushKey = unifiedPushStore.getEndpoint(clientSecret) ?: return null + return Config( + url = url, + pushKey = pushKey, + ) + } +} diff --git a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTest.kt b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTest.kt index 7a22e92222..ff32dd51b7 100644 --- a/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTest.kt +++ b/libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTest.kt @@ -7,13 +7,14 @@ package io.element.android.libraries.pushproviders.unifiedpush.troubleshoot -import dev.zacsweers.metro.AppScope import dev.zacsweers.metro.ContributesIntoSet import dev.zacsweers.metro.Inject import io.element.android.libraries.core.coroutine.CoroutineDispatchers +import io.element.android.libraries.di.SessionScope +import io.element.android.libraries.matrix.api.core.SessionId import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushApiFactory import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushConfig -import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushCurrentUserPushConfigProvider +import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushSessionPushConfigProvider import io.element.android.libraries.troubleshoot.api.test.NotificationTroubleshootTest import io.element.android.libraries.troubleshoot.api.test.NotificationTroubleshootTestDelegate import io.element.android.libraries.troubleshoot.api.test.NotificationTroubleshootTestState @@ -22,12 +23,13 @@ import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.flow.StateFlow import kotlinx.coroutines.launch -@ContributesIntoSet(AppScope::class) +@ContributesIntoSet(SessionScope::class) @Inject class UnifiedPushMatrixGatewayTest( + private val sessionId: SessionId, private val unifiedPushApiFactory: UnifiedPushApiFactory, private val coroutineDispatchers: CoroutineDispatchers, - private val unifiedPushCurrentUserPushConfigProvider: UnifiedPushCurrentUserPushConfigProvider, + private val unifiedPushSessionPushConfigProvider: UnifiedPushSessionPushConfigProvider, ) : NotificationTroubleshootTest { override val order = 450 private val delegate = NotificationTroubleshootTestDelegate( @@ -44,7 +46,7 @@ class UnifiedPushMatrixGatewayTest( override suspend fun run(coroutineScope: CoroutineScope) { delegate.start() - val config = unifiedPushCurrentUserPushConfigProvider.provide() + val config = unifiedPushSessionPushConfigProvider.provide(sessionId) if (config == null) { delegate.updateState( description = "No current push provider", diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushCurrentUserPushConfigProviderTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushCurrentUserPushConfigProviderTest.kt index deabff4488..2c15b47dd1 100644 --- a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushCurrentUserPushConfigProviderTest.kt +++ b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushCurrentUserPushConfigProviderTest.kt @@ -10,36 +10,16 @@ package io.element.android.libraries.pushproviders.unifiedpush import com.google.common.truth.Truth.assertThat import io.element.android.libraries.matrix.test.A_SECRET import io.element.android.libraries.matrix.test.A_SESSION_ID -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig +import io.element.android.libraries.pushproviders.api.Config import io.element.android.libraries.pushstore.api.clientsecret.PushClientSecret import io.element.android.libraries.pushstore.test.userpushstore.clientsecret.FakePushClientSecret -import io.element.android.services.appnavstate.api.AppNavigationState -import io.element.android.services.appnavstate.api.AppNavigationStateService -import io.element.android.services.appnavstate.api.NavigationState -import io.element.android.services.appnavstate.test.FakeAppNavigationStateService -import kotlinx.coroutines.flow.MutableStateFlow import kotlinx.coroutines.test.runTest import org.junit.Test class DefaultUnifiedPushCurrentUserPushConfigProviderTest { - @Test - fun `getCurrentUserPushConfig no session`() = runTest { - val sut = createDefaultUnifiedPushCurrentUserPushConfigProvider() - val result = sut.provide() - assertThat(result).isNull() - } - @Test fun `getCurrentUserPushConfig no push gateway`() = runTest { val sut = createDefaultUnifiedPushCurrentUserPushConfigProvider( - appNavigationStateService = FakeAppNavigationStateService( - appNavigationState = MutableStateFlow( - AppNavigationState( - navigationState = NavigationState.Session(owner = "owner", sessionId = A_SESSION_ID), - isInForeground = true - ) - ) - ), pushClientSecret = FakePushClientSecret( getSecretForUserResult = { A_SECRET } ), @@ -47,21 +27,13 @@ class DefaultUnifiedPushCurrentUserPushConfigProviderTest { getPushGatewayResult = { null } ), ) - val result = sut.provide() + val result = sut.provide(A_SESSION_ID) assertThat(result).isNull() } @Test fun `getCurrentUserPushConfig no push key`() = runTest { val sut = createDefaultUnifiedPushCurrentUserPushConfigProvider( - appNavigationStateService = FakeAppNavigationStateService( - appNavigationState = MutableStateFlow( - AppNavigationState( - navigationState = NavigationState.Session(owner = "owner", sessionId = A_SESSION_ID), - isInForeground = true - ) - ) - ), pushClientSecret = FakePushClientSecret( getSecretForUserResult = { A_SECRET } ), @@ -70,21 +42,13 @@ class DefaultUnifiedPushCurrentUserPushConfigProviderTest { getEndpointResult = { null } ), ) - val result = sut.provide() + val result = sut.provide(A_SESSION_ID) assertThat(result).isNull() } @Test fun `getCurrentUserPushConfig ok`() = runTest { val sut = createDefaultUnifiedPushCurrentUserPushConfigProvider( - appNavigationStateService = FakeAppNavigationStateService( - appNavigationState = MutableStateFlow( - AppNavigationState( - navigationState = NavigationState.Session(owner = "owner", sessionId = A_SESSION_ID), - isInForeground = true - ) - ) - ), pushClientSecret = FakePushClientSecret( getSecretForUserResult = { A_SECRET } ), @@ -93,19 +57,17 @@ class DefaultUnifiedPushCurrentUserPushConfigProviderTest { getEndpointResult = { "aEndpoint" } ), ) - val result = sut.provide() - assertThat(result).isEqualTo(CurrentUserPushConfig("aPushGateway", "aEndpoint")) + val result = sut.provide(A_SESSION_ID) + assertThat(result).isEqualTo(Config("aPushGateway", "aEndpoint")) } private fun createDefaultUnifiedPushCurrentUserPushConfigProvider( pushClientSecret: PushClientSecret = FakePushClientSecret(), unifiedPushStore: UnifiedPushStore = FakeUnifiedPushStore(), - appNavigationStateService: AppNavigationStateService = FakeAppNavigationStateService(), - ): DefaultUnifiedPushCurrentUserPushConfigProvider { - return DefaultUnifiedPushCurrentUserPushConfigProvider( + ): DefaultUnifiedPushPushConfigProvider { + return DefaultUnifiedPushPushConfigProvider( pushClientSecret = pushClientSecret, unifiedPushStore = unifiedPushStore, - appNavigationStateService = appNavigationStateService, ) } } diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProviderTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProviderTest.kt index 5e48728322..61be1496a6 100644 --- a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProviderTest.kt +++ b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushProviderTest.kt @@ -16,9 +16,9 @@ import io.element.android.libraries.matrix.test.A_SECRET import io.element.android.libraries.matrix.test.A_SESSION_ID import io.element.android.libraries.matrix.test.FakeMatrixClient import io.element.android.libraries.pushproviders.api.Distributor -import io.element.android.libraries.pushproviders.test.aCurrentUserPushConfig -import io.element.android.libraries.pushproviders.unifiedpush.troubleshoot.FakeUnifiedPushCurrentUserPushConfigProvider +import io.element.android.libraries.pushproviders.test.aSessionPushConfig import io.element.android.libraries.pushproviders.unifiedpush.troubleshoot.FakeUnifiedPushDistributorProvider +import io.element.android.libraries.pushproviders.unifiedpush.troubleshoot.FakeUnifiedPushSessionPushConfigProvider import io.element.android.libraries.pushstore.api.clientsecret.PushClientSecret import io.element.android.libraries.pushstore.test.userpushstore.clientsecret.FakePushClientSecret import io.element.android.tests.testutils.lambda.lambdaRecorder @@ -211,13 +211,13 @@ class UnifiedPushProviderTest { @Test fun `getCurrentUserPushConfig invokes the provider methods`() = runTest { - val currentUserPushConfig = aCurrentUserPushConfig() + val currentUserPushConfig = aSessionPushConfig() val unifiedPushProvider = createUnifiedPushProvider( - unifiedPushCurrentUserPushConfigProvider = FakeUnifiedPushCurrentUserPushConfigProvider( - currentUserPushConfig = { currentUserPushConfig } + unifiedPushSessionPushConfigProvider = FakeUnifiedPushSessionPushConfigProvider( + config = { currentUserPushConfig } ) ) - val result = unifiedPushProvider.getCurrentUserPushConfig() + val result = unifiedPushProvider.getPushConfig(A_SESSION_ID) assertThat(result).isEqualTo(currentUserPushConfig) } @@ -248,7 +248,7 @@ class UnifiedPushProviderTest { unRegisterUnifiedPushUseCase: UnregisterUnifiedPushUseCase = FakeUnregisterUnifiedPushUseCase(), pushClientSecret: PushClientSecret = FakePushClientSecret(), unifiedPushStore: UnifiedPushStore = FakeUnifiedPushStore(), - unifiedPushCurrentUserPushConfigProvider: UnifiedPushCurrentUserPushConfigProvider = FakeUnifiedPushCurrentUserPushConfigProvider(), + unifiedPushSessionPushConfigProvider: UnifiedPushSessionPushConfigProvider = FakeUnifiedPushSessionPushConfigProvider(), ): UnifiedPushProvider { return UnifiedPushProvider( unifiedPushDistributorProvider = unifiedPushDistributorProvider, @@ -256,7 +256,7 @@ class UnifiedPushProviderTest { unRegisterUnifiedPushUseCase = unRegisterUnifiedPushUseCase, pushClientSecret = pushClientSecret, unifiedPushStore = unifiedPushStore, - unifiedPushCurrentUserPushConfigProvider = unifiedPushCurrentUserPushConfigProvider, + unifiedPushSessionPushConfigProvider = unifiedPushSessionPushConfigProvider, ) } } diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushCurrentUserPushConfigProvider.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushCurrentUserPushConfigProvider.kt deleted file mode 100644 index 92be615054..0000000000 --- a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushCurrentUserPushConfigProvider.kt +++ /dev/null @@ -1,20 +0,0 @@ -/* - * Copyright 2024 New Vector Ltd. - * - * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial - * Please see LICENSE files in the repository root for full details. - */ - -package io.element.android.libraries.pushproviders.unifiedpush.troubleshoot - -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig -import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushCurrentUserPushConfigProvider -import io.element.android.tests.testutils.lambda.lambdaError - -class FakeUnifiedPushCurrentUserPushConfigProvider( - private val currentUserPushConfig: () -> CurrentUserPushConfig? = { lambdaError() }, -) : UnifiedPushCurrentUserPushConfigProvider { - override suspend fun provide(): CurrentUserPushConfig? { - return currentUserPushConfig() - } -} diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushSessionPushConfigProvider.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushSessionPushConfigProvider.kt new file mode 100644 index 0000000000..bf54d95da2 --- /dev/null +++ b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/FakeUnifiedPushSessionPushConfigProvider.kt @@ -0,0 +1,21 @@ +/* + * Copyright 2024 New Vector Ltd. + * + * SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial + * Please see LICENSE files in the repository root for full details. + */ + +package io.element.android.libraries.pushproviders.unifiedpush.troubleshoot + +import io.element.android.libraries.matrix.api.core.SessionId +import io.element.android.libraries.pushproviders.api.Config +import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushSessionPushConfigProvider +import io.element.android.tests.testutils.lambda.lambdaError + +class FakeUnifiedPushSessionPushConfigProvider( + private val config: (SessionId) -> Config? = { lambdaError() }, +) : UnifiedPushSessionPushConfigProvider { + override suspend fun provide(sessionId: SessionId): Config? { + return config(sessionId) + } +} diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTestTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTestTest.kt index f4a0cf5da4..f1bd427abd 100644 --- a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTestTest.kt +++ b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/UnifiedPushMatrixGatewayTestTest.kt @@ -8,8 +8,10 @@ package io.element.android.libraries.pushproviders.unifiedpush.troubleshoot import com.google.common.truth.Truth.assertThat -import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig -import io.element.android.libraries.pushproviders.test.aCurrentUserPushConfig +import io.element.android.libraries.matrix.api.core.SessionId +import io.element.android.libraries.matrix.test.A_SESSION_ID +import io.element.android.libraries.pushproviders.api.Config +import io.element.android.libraries.pushproviders.test.aSessionPushConfig import io.element.android.libraries.pushproviders.unifiedpush.FakeUnifiedPushApiFactory import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushConfig import io.element.android.libraries.pushproviders.unifiedpush.invalidDiscoveryResponse @@ -27,7 +29,7 @@ class UnifiedPushMatrixGatewayTestTest { @Test fun `test UnifiedPushMatrixGatewayTest success`() = runTest { val sut = createUnifiedPushMatrixGatewayTest( - currentUserPushConfig = aCurrentUserPushConfig(), + config = aSessionPushConfig(), discoveryResponse = matrixDiscoveryResponse, ) sut.runAndTestState { @@ -41,7 +43,7 @@ class UnifiedPushMatrixGatewayTestTest { @Test fun `test UnifiedPushMatrixGatewayTest no config found`() = runTest { val sut = createUnifiedPushMatrixGatewayTest( - currentUserPushConfig = null, + config = null, discoveryResponse = matrixDiscoveryResponse, ) sut.runAndTestState { @@ -55,7 +57,7 @@ class UnifiedPushMatrixGatewayTestTest { @Test fun `test UnifiedPushMatrixGatewayTest not valid gateway`() = runTest { val sut = createUnifiedPushMatrixGatewayTest( - currentUserPushConfig = aCurrentUserPushConfig(), + config = aSessionPushConfig(), discoveryResponse = invalidDiscoveryResponse, ) sut.runAndTestState { @@ -72,7 +74,7 @@ class UnifiedPushMatrixGatewayTestTest { @Test fun `test UnifiedPushMatrixGatewayTest network error`() = runTest { val sut = createUnifiedPushMatrixGatewayTest( - currentUserPushConfig = aCurrentUserPushConfig(), + config = aSessionPushConfig(), discoveryResponse = { error("Network error") }, ) sut.runAndTestState { @@ -91,14 +93,16 @@ class UnifiedPushMatrixGatewayTestTest { } private fun TestScope.createUnifiedPushMatrixGatewayTest( - currentUserPushConfig: CurrentUserPushConfig? = null, + sessionId: SessionId = A_SESSION_ID, + config: Config? = null, discoveryResponse: () -> DiscoveryResponse = matrixDiscoveryResponse, ): UnifiedPushMatrixGatewayTest { return UnifiedPushMatrixGatewayTest( + sessionId = sessionId, unifiedPushApiFactory = FakeUnifiedPushApiFactory(discoveryResponse), coroutineDispatchers = testCoroutineDispatchers(), - unifiedPushCurrentUserPushConfigProvider = FakeUnifiedPushCurrentUserPushConfigProvider( - currentUserPushConfig = { currentUserPushConfig } + unifiedPushSessionPushConfigProvider = FakeUnifiedPushSessionPushConfigProvider( + config = { config } ), ) }