From cc5321f65a2f90565fbcab5d930b085bdba444c2 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Fri, 3 Nov 2023 16:27:37 +0100
Subject: [PATCH] Use AsyncView in NotificationSettingsView

---
 .../notifications/NotificationSettingsView.kt | 23 +++++++------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsView.kt b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsView.kt
index a1d248c1fd..ac027bfb95 100644
--- a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsView.kt
+++ b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsView.kt
@@ -24,9 +24,8 @@ import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.PreviewParameter
 import androidx.lifecycle.Lifecycle
 import io.element.android.libraries.androidutils.system.startNotificationSettingsIntent
-import io.element.android.libraries.architecture.Async
 import io.element.android.libraries.designsystem.atomic.molecules.DialogLikeBannerMolecule
-import io.element.android.libraries.designsystem.components.ProgressDialog
+import io.element.android.libraries.designsystem.components.async.AsyncView
 import io.element.android.libraries.designsystem.components.dialogs.ErrorDialog
 import io.element.android.libraries.designsystem.components.preferences.PreferenceCategory
 import io.element.android.libraries.designsystem.components.preferences.PreferencePage
@@ -79,19 +78,13 @@ fun NotificationSettingsView(
 //                onCallsNotificationsChanged = { state.eventSink(NotificationSettingsEvents.SetCallNotificationsEnabled(it)) },
             )
         }
-        when (state.changeNotificationSettingAction) {
-            is Async.Loading -> {
-                ProgressDialog()
-            }
-            is Async.Failure -> {
-                ErrorDialog(
-                    title = stringResource(CommonStrings.dialog_title_error),
-                    content = stringResource(CommonStrings.screen_notification_settings_edit_failed_updating_default_mode),
-                    onDismiss = { state.eventSink(NotificationSettingsEvents.ClearNotificationChangeError) },
-                )
-            }
-            else -> Unit
-        }
+        val errorMessage = stringResource(CommonStrings.screen_notification_settings_edit_failed_updating_default_mode)
+        AsyncView(
+            async = state.changeNotificationSettingAction,
+            errorTransform = { errorMessage },
+            onErrorDismiss = { state.eventSink(NotificationSettingsEvents.ClearNotificationChangeError) },
+            onSuccess = {},
+        )
     }
 }