From ed7a36e768daa4a859de74b9160d9e22498893b5 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 26 Aug 2025 11:07:24 +0200 Subject: [PATCH] Improve code readability a bit. --- .../libraries/androidutils/media/VideoCompressorHelper.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/media/VideoCompressorHelper.kt b/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/media/VideoCompressorHelper.kt index fd1440b117..3ac32fd3a9 100644 --- a/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/media/VideoCompressorHelper.kt +++ b/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/media/VideoCompressorHelper.kt @@ -27,7 +27,7 @@ class VideoCompressorHelper( fun getOutputSize(inputSize: Size): Size { val resultMajor = min(inputSize.major(), maxSize) val aspectRatio = inputSize.major().toFloat() / inputSize.minor().toFloat() - return if (inputSize.width >= inputSize.height) { + return if (inputSize.isLandscape()) { Size(resultMajor, (resultMajor / aspectRatio).roundToInt()) } else { Size((resultMajor / aspectRatio).roundToInt(), resultMajor) @@ -46,5 +46,6 @@ class VideoCompressorHelper( } } -internal fun Size.major(): Int = if (width > height) width else height -internal fun Size.minor(): Int = if (width < height) width else height +private fun Size.isLandscape(): Boolean = width > height +private fun Size.major(): Int = if (isLandscape()) width else height +private fun Size.minor(): Int = if (isLandscape()) height else width