Sulkta-Coop/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix "Arrow is redundant when parameter list is empty"

Browse source 
And other issues that ktlint now reports
This commit is contained in:
Benoit Marty 2025-10-30 13:29:33 +01:00 • committed by Benoit Marty
parent ea616be814
commit eef0fbf4be
10 changed files with 41 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

30
libraries/voiceplayer/impl/src/test/kotlin/io/element/android/libraries/voiceplayer/impl/DefaultVoiceMessagePlayerTest.kt
View file

@ -114,7 +114,8 @@ class DefaultVoiceMessagePlayerTest {
assertThat(player1.prepare().isSuccess).isTrue()
matchReadyState(1_000L)
player1.play()
awaitItem().let { // it plays until the end.
awaitItem().let {
// it plays until the end.
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isTrue()
@ -127,14 +128,16 @@ class DefaultVoiceMessagePlayerTest {
player2.state.test {
matchInitialState()
assertThat(player2.prepare().isSuccess).isTrue()
awaitItem().let { // Additional spurious state due to MediaPlayer owner change.
awaitItem().let {
// Additional spurious state due to MediaPlayer owner change.
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isTrue()
assertThat(it.currentPosition).isEqualTo(1000)
assertThat(it.duration).isEqualTo(1000)
}
awaitItem().let { // Additional spurious state due to MediaPlayer owner change.
awaitItem().let {
// Additional spurious state due to MediaPlayer owner change.
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
@ -143,7 +146,8 @@ class DefaultVoiceMessagePlayerTest {
}
matchReadyState(1_000L)
player2.play()
awaitItem().let { // it plays until the end.
awaitItem().let {
// it plays until the end.
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isTrue()
@ -154,7 +158,8 @@ class DefaultVoiceMessagePlayerTest {
// Play player1 again.
player1.state.test {
awaitItem().let { // Last previous state/
awaitItem().let {
// Last previous state/
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isTrue()
@ -162,7 +167,8 @@ class DefaultVoiceMessagePlayerTest {
assertThat(it.duration).isEqualTo(1000)
}
assertThat(player1.prepare().isSuccess).isTrue()
awaitItem().let { // Additional spurious state due to MediaPlayer owner change.
awaitItem().let {
// Additional spurious state due to MediaPlayer owner change.
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isFalse()
@ -171,7 +177,8 @@ class DefaultVoiceMessagePlayerTest {
}
matchReadyState(1_000L)
player1.play()
awaitItem().let { // it played again until the end.
awaitItem().let {
// it played again until the end.
assertThat(it.isReady).isFalse()
assertThat(it.isPlaying).isFalse()
assertThat(it.isEnded).isTrue()
@ -189,7 +196,8 @@ class DefaultVoiceMessagePlayerTest {
assertThat(player.prepare().isSuccess).isTrue()
matchReadyState()
player.play()
skipItems(1) // skip play state
// skip play state
skipItems(1)
player.pause()
awaitItem().let {
assertThat(it.isPlaying).isFalse()
@ -206,9 +214,11 @@ class DefaultVoiceMessagePlayerTest {
assertThat(player.prepare().isSuccess).isTrue()
matchReadyState()
player.play()
skipItems(1) // skip play state
// skip play state
skipItems(1)
player.pause()
skipItems(1) // skip pause state
// skip pause state
skipItems(1)
player.play()
awaitItem().let {
assertThat(it.isPlaying).isTrue()