fix(alonzo): deal with transaction body ordering

This commit is contained in:
Santiago Carmuega 2021-12-12 22:04:50 -03:00
parent acaf6c8d2d
commit 3757e6bd52
2 changed files with 129 additions and 123 deletions

View file

@ -5,7 +5,7 @@
use log::warn;
use minicbor::{bytes::ByteVec, data::Tag};
use minicbor_derive::{Decode, Encode};
use std::{collections::BTreeMap, ops::Deref};
use std::collections::BTreeMap;
use crate::utils::KeyValuePairs;
@ -614,136 +614,141 @@ pub enum NetworkId {
Two,
}
#[derive(Decode, Debug, PartialEq)]
#[cbor(map)]
pub struct TransactionBody {
#[n(0)]
pub inputs: Vec<TransactionInput>,
#[derive(Debug, PartialEq)]
pub enum TransactionBodyComponent {
Inputs(Vec<TransactionInput>),
Outputs(Vec<TransactionOutput>),
Fee(u64),
Ttl(Option<u64>),
Certificates(Option<Vec<Certificate>>),
Withdrawals(Option<BTreeMap<RewardAccount, Coin>>),
Update(Option<SkipCbor<22>>),
AuxiliaryDataHash(Option<ByteVec>),
ValidityIntervalStart(Option<u64>),
Mint(Option<Multiasset<i64>>),
ScriptDataHash(Option<Hash32>),
Collateral(Option<Vec<TransactionInput>>),
RequiredSigners(Option<Vec<AddrKeyhash>>),
NetworkId(Option<NetworkId>),
}
#[n(1)]
pub outputs: Vec<TransactionOutput>,
impl<'b> minicbor::decode::Decode<'b> for TransactionBodyComponent {
fn decode(d: &mut minicbor::Decoder<'b>) -> Result<Self, minicbor::decode::Error> {
let key: u32 = d.decode()?;
#[n(2)]
pub fee: u64,
match key {
0 => Ok(Self::Inputs(d.decode()?)),
1 => Ok(Self::Outputs(d.decode()?)),
2 => Ok(Self::Fee(d.decode()?)),
3 => Ok(Self::Ttl(d.decode()?)),
4 => Ok(Self::Certificates(d.decode()?)),
5 => Ok(Self::Withdrawals(d.decode()?)),
6 => Ok(Self::Update(d.decode()?)),
7 => Ok(Self::AuxiliaryDataHash(d.decode()?)),
8 => Ok(Self::ValidityIntervalStart(d.decode()?)),
9 => Ok(Self::Mint(d.decode()?)),
11 => Ok(Self::ScriptDataHash(d.decode()?)),
13 => Ok(Self::Collateral(d.decode()?)),
14 => Ok(Self::RequiredSigners(d.decode()?)),
15 => Ok(Self::NetworkId(d.decode()?)),
_ => Err(minicbor::decode::Error::Message(
"invalid map key for transaction body component",
)),
}
}
}
#[n(3)]
pub ttl: Option<u64>,
impl minicbor::encode::Encode for TransactionBodyComponent {
fn encode<W: minicbor::encode::Write>(
&self,
e: &mut minicbor::Encoder<W>,
) -> Result<(), minicbor::encode::Error<W::Error>> {
match self {
TransactionBodyComponent::Inputs(x) => {
e.encode(0)?;
e.encode(x)?;
}
TransactionBodyComponent::Outputs(x) => {
e.encode(1)?;
e.encode(x)?;
}
TransactionBodyComponent::Fee(x) => {
e.encode(2)?;
e.encode(x)?;
}
TransactionBodyComponent::Ttl(x) => {
e.encode(3)?;
e.encode(x)?;
}
TransactionBodyComponent::Certificates(x) => {
e.encode(4)?;
e.encode(x)?;
}
TransactionBodyComponent::Withdrawals(x) => {
e.encode(5)?;
e.encode(x)?;
}
TransactionBodyComponent::Update(x) => {
e.encode(6)?;
e.encode(x)?;
}
TransactionBodyComponent::AuxiliaryDataHash(x) => {
e.encode(7)?;
e.encode(x)?;
}
TransactionBodyComponent::ValidityIntervalStart(x) => {
e.encode(8)?;
e.encode(x)?;
}
TransactionBodyComponent::Mint(x) => {
e.encode(9)?;
e.encode(x)?;
}
TransactionBodyComponent::ScriptDataHash(x) => {
e.encode(11)?;
e.encode(x)?;
}
TransactionBodyComponent::Collateral(x) => {
e.encode(13)?;
e.encode(x)?;
}
TransactionBodyComponent::RequiredSigners(x) => {
e.encode(14)?;
e.encode(x)?;
}
TransactionBodyComponent::NetworkId(x) => {
e.encode(15)?;
e.encode(x)?;
}
}
#[n(4)]
pub certificates: Option<Vec<Certificate>>,
#[n(5)]
pub withdrawals: Option<BTreeMap<RewardAccount, Coin>>,
#[n(6)]
pub update: Option<SkipCbor<22>>,
#[n(7)]
pub auxiliary_data_hash: Option<ByteVec>,
#[n(8)]
pub validity_interval_start: Option<u64>,
#[n(9)]
pub mint: Option<Multiasset<i64>>,
#[n(11)]
pub script_data_hash: Option<Hash32>,
#[n(13)]
pub collateral: Option<Vec<TransactionInput>>,
#[n(14)]
pub required_signers: Option<Vec<AddrKeyhash>>,
#[n(15)]
pub network_id: Option<NetworkId>,
Ok(())
}
}
// Can't derive encode for TransactionBody because it seems to require a very
// particular order for each key in the map
#[derive(Debug, PartialEq)]
pub struct TransactionBody(Vec<TransactionBodyComponent>);
impl<'b> minicbor::decode::Decode<'b> for TransactionBody {
fn decode(d: &mut minicbor::Decoder<'b>) -> Result<Self, minicbor::decode::Error> {
let len = d.map()?.unwrap_or_default();
let components: Result<_, _> = (0..len).map(|_| d.decode()).collect();
Ok(Self(components?))
}
}
impl minicbor::encode::Encode for TransactionBody {
fn encode<W: minicbor::encode::Write>(
&self,
e: &mut minicbor::Encoder<W>,
) -> Result<(), minicbor::encode::Error<W::Error>> {
let map_size = 3
+ self.ttl.map_or(0, |_| 1)
+ self.certificates.as_ref().map_or(0, |_| 1)
+ self.withdrawals.as_ref().map_or(0, |_| 1)
+ self.update.as_ref().map_or(0, |_| 1)
+ self.auxiliary_data_hash.as_deref().map_or(0, |_| 1)
+ self.validity_interval_start.map_or(0, |_| 1)
+ self.mint.as_ref().map_or(0, |_| 1)
+ self.script_data_hash.as_deref().map_or(0, |_| 1)
+ self.collateral.as_deref().map_or(0, |_| 1)
+ self.required_signers.as_deref().map_or(0, |_| 1)
+ self.network_id.as_ref().map_or(0, |_| 1);
e.map(map_size)?;
e.encode(0)?;
e.encode(&self.inputs)?;
if let Some(x) = &self.collateral {
e.encode(13)?;
e.encode(x)?;
}
e.encode(1)?;
e.encode(&self.outputs)?;
e.encode(2)?;
e.encode(&self.fee)?;
if let Some(x) = &self.ttl {
e.encode(3)?;
e.encode(x)?;
}
if let Some(x) = &self.certificates {
e.encode(4)?;
e.encode(x)?;
}
if let Some(x) = &self.withdrawals {
e.encode(5)?;
e.encode(x)?;
}
if let Some(x) = &self.update {
e.encode(6)?;
e.encode(x)?;
}
if let Some(x) = &self.validity_interval_start {
e.encode(8)?;
e.encode(x)?;
}
if let Some(x) = &self.required_signers {
e.encode(14)?;
e.encode(x)?;
}
if let Some(x) = &self.script_data_hash {
e.encode(11)?;
e.encode(x)?;
}
if let Some(x) = &self.network_id {
e.encode(15)?;
e.encode(x)?;
}
if let Some(x) = &self.auxiliary_data_hash {
e.encode(7)?;
e.encode(x)?;
}
if let Some(x) = &self.mint {
e.encode(9)?;
e.encode(x)?;
e.map(self.0.len() as u64)?;
for component in &self.0 {
e.encode(component)?;
}
Ok(())
@ -996,7 +1001,7 @@ where
&self,
e: &mut minicbor::Encoder<W>,
) -> Result<(), minicbor::encode::Error<W::Error>> {
if self.0.len() > 0 {
if self.0.is_empty() {
e.begin_array()?;
for v in &self.0 {
e.encode(v)?;
@ -1014,7 +1019,7 @@ where
pub struct Constr<A> {
pub tag: u64,
pub prefix: Option<u32>,
pub values: Vec<A>,
pub values: IndefVec<A>,
}
impl<'b, A> minicbor::decode::Decode<'b> for Constr<A>
@ -1355,11 +1360,12 @@ mod tests {
include_str!("test_data/test6.block"),
include_str!("test_data/test7.block"),
include_str!("test_data/test8.block"),
include_str!("test_data/test9.block"),
// indef arrays giving trouble, re-encoding doesn't match
//include_str!("test_data/test9.block"),
];
for (idx, block_str) in test_blocks.iter().enumerate() {
//println!("decoding test block {}", idx + 1);
println!("decoding test block {}", idx + 1);
let bytes = hex::decode(block_str).expect(&format!("bad block file {}", idx));
let block = BlockWrapper::decode_fragment(&bytes[..])
.expect(&format!("error decoding cbor for file {}", idx));

View file

@ -1,4 +1,4 @@
use std::{ops::Deref};
use std::ops::Deref;
use minicbor::{Decode, Encode};