From f5c096a8ae33f73bae5e95e934ca8978f35d13a9 Mon Sep 17 00:00:00 2001
From: Santiago Carmuega <santiago@carmuega.me>
Date: Thu, 24 Nov 2022 16:36:26 +0100
Subject: [PATCH] fix(addresses): Remove bad todo in bech32 logic (#207)

---
 pallas-addresses/src/lib.rs | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/pallas-addresses/src/lib.rs b/pallas-addresses/src/lib.rs
index 42d013c..215a3a5 100644
--- a/pallas-addresses/src/lib.rs
+++ b/pallas-addresses/src/lib.rs
@@ -38,6 +38,9 @@ pub enum Error {
     #[error("invalid operation for Byron address")]
     InvalidForByron,
 
+    #[error("invalid operation for address content")]
+    InvalidForContent,
+
     #[error("invalid CBOR for Byron address")]
     InvalidByronCbor,
 
@@ -192,8 +195,8 @@ impl ShelleyDelegationPart {
         match self {
             Self::Key(x) => Some(x),
             Self::Script(x) => Some(x),
-            Self::Pointer(_) => todo!(),
-            Self::Null => todo!(),
+            Self::Pointer(_) => None,
+            Self::Null => None,
         }
     }
 
@@ -215,8 +218,9 @@ impl ShelleyDelegationPart {
         let hrp = match self {
             Self::Key(_) => "stake_vkh",
             Self::Script(_) => "stake_shared_vkh",
-            _ => todo!(),
+            _ => return Err(Error::InvalidForContent),
         };
+
         let bytes = self.to_vec();
         encode_bech32(&bytes, hrp)
     }