Sulkta-Coop/straw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix NullPointerException in enqueue actions by using Application Context

Browse source 
Use getApplicationContext() instead of getContext() in ENQUEUE,
ENQUEUE_NEXT, START_HERE_ON_BACKGROUND, and START_HERE_ON_POPUP
entries to prevent NullPointerException when the fragment's activity
context becomes null during configuration changes (e.g. device rotation).

The fragment context can become null when the activity is destroyed
during rotation, but the async callback from fetchItemInfoIfSparse
still holds a reference to the now-detached fragment. Using
Application context ensures a stable, non-null context throughout
the async operation lifecycle.
This commit is contained in:
arjun 2026-03-28 14:22:24 +05:30
parent 515bb6e94d
commit 07a2ab29de
1 changed files with 21 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

36
app/src/main/java/org/schabi/newpipe/info_list/dialog/StreamDialogDefaultEntry.java
View file

@ -5,6 +5,7 @@ import static org.schabi.newpipe.util.SparseItemUtil.fetchItemInfoIfSparse;
import static org.schabi.newpipe.util.SparseItemUtil.fetchStreamInfoAndSaveToDatabase;
import static org.schabi.newpipe.util.SparseItemUtil.fetchUploaderUrlIfSparse;
import android.content.Context;
import android.net.Uri;
import androidx.annotation.NonNull;
@ -52,28 +53,33 @@ public enum StreamDialogDefaultEntry {
/**
* Enqueues the stream automatically to the current PlayerType.
*/
ENQUEUE(R.string.enqueue_stream, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.enqueueOnPlayer(fragment.getContext(), singlePlayQueue))
),
ENQUEUE(R.string.enqueue_stream, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.enqueueOnPlayer(ctx, singlePlayQueue));
}),
/**
* Enqueues the stream automatically to the current PlayerType
* after the currently playing stream.
*/
ENQUEUE_NEXT(R.string.enqueue_next_stream, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.enqueueNextOnPlayer(fragment.getContext(), singlePlayQueue))
),
ENQUEUE_NEXT(R.string.enqueue_next_stream, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.enqueueNextOnPlayer(ctx, singlePlayQueue));
}),
START_HERE_ON_BACKGROUND(R.string.start_here_on_background, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.playOnBackgroundPlayer(
fragment.getContext(), singlePlayQueue, true))),
START_HERE_ON_BACKGROUND(R.string.start_here_on_background, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.playOnBackgroundPlayer(ctx, singlePlayQueue, true));
}),
START_HERE_ON_POPUP(R.string.start_here_on_popup, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.playOnPopupPlayer(fragment.getContext(), singlePlayQueue, true))),
START_HERE_ON_POPUP(R.string.start_here_on_popup, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.playOnPopupPlayer(ctx, singlePlayQueue, true));
}),
SET_AS_PLAYLIST_THUMBNAIL(R.string.set_as_playlist_thumbnail, (fragment, item) -> {
throw new UnsupportedOperationException("This needs to be implemented manually "