Sulkta-Coop/straw
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add popup for NewPipe dropping support for Android 5

Browse source
This commit is contained in:
Stypox 2026-04-29 16:30:31 +02:00
parent 9360d2f61c
commit 6d52522523
No known key found for this signature in database
GPG key ID: 4BDF1B40A49FDD23
3 changed files with 34 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

30
app/src/main/java/org/schabi/newpipe/MainActivity.java
View file

@ -27,6 +27,7 @@ import android.content.Intent;
import android.content.IntentFilter;
import android.content.SharedPreferences;
import android.content.pm.PackageManager;
import android.os.Build;
import android.os.Bundle;
import android.os.Handler;
import android.os.Looper;
@ -203,6 +204,7 @@ public class MainActivity extends AppCompatActivity {
// We want every release build (nightly, nightly-refactor) to show the popup
if (!DEBUG) {
showKeepAndroidDialog();
showApi23RequirementDialog();
}
MigrationManager.showUserInfoIfPresent(this);
@ -1028,4 +1030,32 @@ public class MainActivity extends AppCompatActivity {
return kaoBaseUrl;
}
}
private void showApi23RequirementDialog() {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
return; // only show dialog on the devices that will stop being supported
}
final var prefs = PreferenceManager.getDefaultSharedPreferences(this);
final var shownKey = getString(R.string.api23_requirement_dialog_shown_key);
if (prefs.getBoolean(shownKey, false)) {
return; // dialog was already shown in the past, no need to show it again
}
final var dialog = new AlertDialog.Builder(this)
.setTitle(R.string.api23_requirement_dialog_title)
.setCancelable(false)
.setMessage(R.string.api23_requirement_dialog_message)
.setPositiveButton(android.R.string.ok, (d, w) -> prefs.edit()
.putBoolean(shownKey, true)
.apply())
.setNegativeButton(R.string.api23_requirement_dialog_blogpost, null)
.show();
// If we use setNegativeButton, dialog will close after pressing the button,
// but we want it to close only when positive button is pressed
final var blogpostUrl = "https://newpipe.net/blog/pinned/announcement/drop-android-5/";
dialog.getButton(AlertDialog.BUTTON_NEGATIVE)
.setOnClickListener(v -> ShareUtils.openUrlInBrowser(this, blogpostUrl));
}
}

1
app/src/main/res/values/settings_keys.xml
View file

@ -11,6 +11,7 @@
<!-- Key values -->
<string name="kao_last_checked_key">kao_last_checked</string>
<string name="api23_requirement_dialog_shown_key">api23_requirement_dialog_shown</string>
<string name="download_path_video_key">download_path</string>
<string name="download_path_audio_key">download_path_audio</string>

3
app/src/main/res/values/strings.xml
View file

@ -900,4 +900,7 @@
<string name="kao_dialog_warning">In August 2025, Google announced that as of September 2026, installing apps will require developer verification for all Android apps on certified devices, including those installed outside of the Play Store. Since the developers of NewPipe do not agree to this requirement, NewPipe will no longer work on certified Android devices after that time.</string>
<string name="kao_dialog_more_info">Details</string>
<string name="kao_solution">Solution</string>
<string name="api23_requirement_dialog_title">NewPipe is dropping support for Android 5</string>
<string name="api23_requirement_dialog_message">Unfortunately NewPipe depends on a few libraries that dropped support for Android 5.0 and 5.1. The next NewPipe release will therefore only work on devices with Android 6 or higher, sadly. Read more in the blogpost.</string>
<string name="api23_requirement_dialog_blogpost">Blogpost</string>
</resources>