straw/app
Stypox 5155b24ed6
Partial revert: fix VideoDetailFragment flickering
This partially reverts commit 92a07a3445, which was needed to fix ghost notifications. There I broke the "cycle" causing the useless notifications to popup in 2 different places (see points 3 and 4 of the commit description).
However, breaking the cycle in point 4 ("`PlayerHolder::tryBindIfNeeded()` is now used to passively try to bind, instead of `PlayerHolder::startService()`" was not correct, for the following reason.
I assumed that `ACTION_PLAYER_STARTED` was used for notifying that the player was instantiated anew, while it actually is used to notify that something is now ready for use: it could be the player, but it could also just be that the bottom sheet view was just added and thus the VideoDetailFragment needs to start the player.
Therefore, when handling `ACTION_PLAYER_STARTED` it is correct to start the player service and not just try to bind to it.
The other point in which I broke the cycle (point 3) should still prevent ghost notifications, although I could not test.
2026-01-27 23:44:25 +01:00
..
sampledata Larger channel cards in search results 2023-02-09 06:15:22 +05:30
schemas/org.schabi.newpipe.database.AppDatabase Migrate database logic to Kotlin 2025-11-03 16:14:29 +08:00
src Partial revert: fix VideoDetailFragment flickering 2026-01-27 23:44:25 +01:00
build.gradle.kts Run checkstyle with JDK 21 2026-01-22 17:41:08 +08:00
proguard-rules.pro Fix minify step of release build by ignoring two classes 2026-01-11 22:06:32 +01:00