prevent stake inclusion in AdvanceProposal

agora-specs/Sample/Proposal/Advance.hs

@@ -35,6 +35,7 @@ module Sample.Proposal.Advance (
   mkGATsWithWrongDatumBundle,
   mkMintGATsWithoutTagBundle,
   mkBadGovernorOutputDatumBundle,
+  mkUnexpectedOutputStakeBundles,
 ) where
 
 import Agora.Governor (
@@ -568,16 +569,19 @@ mkTestTree name pb val =
               (spend proposalRef)
 
     stake =
-      let idx = 0
-       in singleton $
-            testValidator
-              val.forStakeValidator
-              "stake"
-              agoraScripts.compiledStakeValidator
-              (getStakeInputDatumAt pb.stakeParameters idx)
-              stakeRedeemer
-              ( spend (mkStakeRef idx)
-              )
+      if pb.stakeParameters.numStake == 0
+        then mempty
+        else
+          let idx = 0
+           in singleton $
+                testValidator
+                  val.forStakeValidator
+                  "stake"
+                  agoraScripts.compiledStakeValidator
+                  (getStakeInputDatumAt pb.stakeParameters idx)
+                  stakeRedeemer
+                  ( spend (mkStakeRef idx)
+                  )
 
     governor =
       maybe [] singleton $
@@ -813,7 +817,7 @@ mkValidToNextStateBundle nCosigners nEffects authScript from =
                 }
           , stakeParameters =
               StakeParameters
-                { numStake = 1
+                { numStake = 0
                 , perStakeGTs =
                     compPerStakeGTsForDraft $
                       fromIntegral nCosigners
@@ -911,7 +915,7 @@ mkValidToFailedStateBundles nCosigners nEffects =
                   }
             , stakeParameters =
                 StakeParameters
-                  { numStake = 1
+                  { numStake = 0
                   , perStakeGTs =
                       compPerStakeGTsForDraft $
                         fromIntegral nCosigners
@@ -977,6 +981,22 @@ mkInvalidOutputStakeBundles nCosigners nEffects =
                   }
             }
 
+mkUnexpectedOutputStakeBundles :: Word -> Word -> [ParameterBundle]
+mkUnexpectedOutputStakeBundles nCosigners nEffects =
+  liftA2
+    mkBundle
+    [True, False]
+    [VotingReady, Locked]
+  where
+    mkBundle authScript from =
+      let template = mkValidToNextStateBundle nCosigners nEffects authScript from
+       in template
+            { stakeParameters =
+                template.stakeParameters
+                  { numStake = 1
+                  }
+            }
+
 -- * From Draft
 
 mkInsufficientCosignsBundle :: Word -> Word -> ParameterBundle

agora-specs/Spec/Proposal.hs

@@ -244,6 +244,16 @@ specs =
                                 , forGovernorValidator = Just True
                                 , forAuthorityTokenPolicy = Just True
                                 }
+                          , Advance.mkTestTree'
+                              "unexpected stake datum"
+                              (\b -> unwords ["from", show b.proposalParameters.fromStatus])
+                              (Advance.mkUnexpectedOutputStakeBundles cs es)
+                              Advance.Validity
+                                { forProposalValidator = False
+                                , forStakeValidator = True
+                                , forGovernorValidator = Just True
+                                , forAuthorityTokenPolicy = Just True
+                                }
                           , Advance.mkTestTree
                               "forget to mint GATs"
                               (Advance.mkNoGATMintedBundle cs es)