remove infinities in ProposalTime, fix test build

agora-test/Spec/Proposal.hs

@@ -16,10 +16,10 @@ import Agora.Proposal (
   ProposalId (ProposalId),
   ProposalRedeemer (Cosign),
   ProposalStatus (Draft),
-  ProposalVotes (ProposalVotes),
   ResultTag (ResultTag),
   cosigners,
   effects,
+  emptyVotesFor,
   proposalId,
   status,
   thresholds,
@@ -70,7 +70,12 @@ tests =
                   , status = Draft
                   , cosigners = [signer]
                   , thresholds = Shared.defaultProposalThresholds
-                  , votes = ProposalVotes AssocMap.empty
+                  , votes =
+                      emptyVotesFor $
+                        AssocMap.fromList
+                          [ (ResultTag 0, [])
+                          , (ResultTag 1, [])
+                          ]
                   }
               )
               (Cosign [signer2])

agora-test/Spec/Sample/Proposal.hs

@@ -43,7 +43,6 @@ import Agora.Proposal (
   ProposalDatum (..),
   ProposalId (..),
   ProposalStatus (..),
-  ProposalVotes (..),
   ResultTag (..),
   emptyVotesFor,
  )

agora-test/Spec/Sample/Shared.hs

@@ -129,5 +129,5 @@ defaultProposalThresholds =
   ProposalThresholds
     { countVoting = Tagged 1000
     , create = Tagged 1
-    , vote = Tagged 10
+    , startVoting = Tagged 10
     }

agora/Agora/Proposal/Scripts.hs

@@ -212,8 +212,7 @@ proposalValidator proposal =
 
               foldr1
                 (#&&)
-                [ pcon PTrue
+                [ ptraceIfFalse "Datum must be correct" correctDatum
-                , ptraceIfFalse "Datum must be correct" correctDatum
                 , ptraceIfFalse "Value should be correct" $
                     pdata txOutF.value #== pdata newValue
                 , ptraceIfFalse "Must be sent to Proposal's address" $

agora/Agora/Proposal/Time.hs

@@ -34,7 +34,6 @@ import Plutarch.Api.V1 (
   PExtended (PFinite),
   PInterval (PInterval),
   PLowerBound (PLowerBound),
-  PMaybeData (PDJust, PDNothing),
   PPOSIXTime,
   PPOSIXTimeRange,
   PUpperBound (PUpperBound),
@@ -71,8 +70,8 @@ import Prelude hiding ((+))
    We avoid 'PPOSIXTimeRange' where we can in order to save on operations.
 -}
 data ProposalTime = ProposalTime
-  { lowerBound :: Maybe POSIXTime
+  { lowerBound :: POSIXTime
-  , upperBound :: Maybe POSIXTime
+  , upperBound :: POSIXTime
   }
   deriving stock (Eq, Show, GHC.Generic)
 
@@ -111,8 +110,8 @@ newtype PProposalTime (s :: S)
       ( Term
           s
           ( PDataRecord
-              '[ "lowerBound" ':= PMaybeData PPOSIXTime
+              '[ "lowerBound" ':= PPOSIXTime
-               , "upperBound" ':= PMaybeData PPOSIXTime
+               , "upperBound" ':= PPOSIXTime
                ]
           )
       )
@@ -153,7 +152,11 @@ newtype PProposalTimingConfig (s :: S) = PProposalTimingConfig
 instance AdditiveSemigroup (Term s PPOSIXTime) where
   (punsafeCoerce @_ @_ @PInteger -> x) + (punsafeCoerce @_ @_ @PInteger -> y) = punsafeCoerce $ x + y
 
--- | Get the current proposal time, from the 'Plutus.V1.Ledger.Api.txInfoValidPeriod' field.
+{- | Get the current proposal time, from the 'Plutus.V1.Ledger.Api.txInfoValidPeriod' field.
+
+ If it's impossible to get a fully-bounded time, (e.g. either end of the 'PPOSIXTimeRange' is
+ an infinity) then we error out.
+-}
 currentProposalTime :: forall (s :: S). Term s (PPOSIXTimeRange :--> PProposalTime)
 currentProposalTime = phoistAcyclic $
   plam $ \iv -> P.do
@@ -165,17 +168,18 @@ currentProposalTime = phoistAcyclic $
     ubf <- pletFields @'["_0", "_1"] ub
     mkRecordConstr PProposalTime $
       #lowerBound
-        .= pdata
+        .= pmatch
-          ( pmatch lbf._0 $
+          lbf._0
-              \case
+          ( \case
-                PFinite d -> pcon (PDJust d)
+              PFinite ((pfield @"_0" #) -> d) -> d
-                _ -> pcon (PDNothing pdnil)
+              _ -> ptraceError "currentProposalTime: Can't get fully-bounded proposal time."
           )
         .& #upperBound
-        .= pdata
+        .= pmatch
-          ( pmatch ubf._0 $ \case
+          ubf._0
-              PFinite d -> pcon (PDJust d)
+          ( \case
-              _ -> pcon (PDNothing pdnil)
+              PFinite ((pfield @"_0" #) -> d) -> d
+              _ -> ptraceError "currentProposalTime: Can't get fully-bounded proposal time."
           )
 
 -- | Check if 'PProposalTime' is within two 'PPOSIXTime'. Inclusive.
@@ -193,12 +197,8 @@ proposalTimeWithin = phoistAcyclic $
     ptf <- pletFields @'["lowerBound", "upperBound"] proposalTime
     foldr1
       (#&&)
-      [ pmatch ptf.lowerBound $ \case
+      [ l #<= pfromData ptf.lowerBound
-          PDJust lb -> l #<= pfromData (pfield @"_0" # lb)
+      , pfromData ptf.upperBound #<= h
-          _ -> pcon PFalse
-      , pmatch ptf.upperBound $ \case
-          PDJust lb -> pfromData (pfield @"_0" # lb) #<= h
-          _ -> pcon PFalse
       ]
 
 -- | True if the 'PProposalTime' is in the draft period.