From 659b9d3d9c633aaf4876785fb24939b216dbe210 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 27 Jun 2023 13:34:55 +0200 Subject: [PATCH 1/4] Now that the composer as been removed, we do not need element resource module anymore. --- app/src/main/res/values-night/themes.xml | 2 +- app/src/main/res/values/themes.xml | 2 +- features/analytics/impl/build.gradle.kts | 1 - features/createroom/impl/build.gradle.kts | 1 - features/login/impl/build.gradle.kts | 1 - features/logout/impl/build.gradle.kts | 1 - features/onboarding/impl/build.gradle.kts | 1 - features/preferences/impl/build.gradle.kts | 1 - features/rageshake/impl/build.gradle.kts | 1 - features/roomdetails/impl/build.gradle.kts | 1 - features/roomlist/impl/build.gradle.kts | 1 - features/verifysession/impl/build.gradle.kts | 1 - libraries/designsystem/build.gradle.kts | 1 - libraries/elementresources/build.gradle.kts | 26 --- .../src/main/AndroidManifest.xml | 20 -- .../src/main/res/values/colors.xml | 177 ------------------ .../src/main/res/values/dimens.xml | 96 ---------- .../src/main/res/values/dimens_font.xml | 30 --- .../src/main/res/values/palette.xml | 63 ------- .../src/main/res/values/palette_mobile.xml | 72 ------- .../main/res/values/styles_bottom_sheet.xml | 28 --- .../src/main/res/values/styles_edit_text.xml | 33 ---- .../src/main/res/values/theme_light.xml | 136 -------------- libraries/permissions/impl/build.gradle.kts | 1 - libraries/textcomposer/build.gradle.kts | 1 - 25 files changed, 2 insertions(+), 696 deletions(-) delete mode 100644 libraries/elementresources/build.gradle.kts delete mode 100644 libraries/elementresources/src/main/AndroidManifest.xml delete mode 100644 libraries/elementresources/src/main/res/values/colors.xml delete mode 100644 libraries/elementresources/src/main/res/values/dimens.xml delete mode 100644 libraries/elementresources/src/main/res/values/dimens_font.xml delete mode 100644 libraries/elementresources/src/main/res/values/palette.xml delete mode 100644 libraries/elementresources/src/main/res/values/palette_mobile.xml delete mode 100644 libraries/elementresources/src/main/res/values/styles_bottom_sheet.xml delete mode 100644 libraries/elementresources/src/main/res/values/styles_edit_text.xml delete mode 100644 libraries/elementresources/src/main/res/values/theme_light.xml diff --git a/app/src/main/res/values-night/themes.xml b/app/src/main/res/values-night/themes.xml index 6763f9b016..e2b4f6f471 100644 --- a/app/src/main/res/values-night/themes.xml +++ b/app/src/main/res/values-night/themes.xml @@ -22,5 +22,5 @@ @style/Theme.ElementX - - - - diff --git a/libraries/elementresources/src/main/res/values/styles_edit_text.xml b/libraries/elementresources/src/main/res/values/styles_edit_text.xml deleted file mode 100644 index de97e1cde0..0000000000 --- a/libraries/elementresources/src/main/res/values/styles_edit_text.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - - diff --git a/libraries/elementresources/src/main/res/values/theme_light.xml b/libraries/elementresources/src/main/res/values/theme_light.xml deleted file mode 100644 index 04a6f79355..0000000000 --- a/libraries/elementresources/src/main/res/values/theme_light.xml +++ /dev/null @@ -1,136 +0,0 @@ - - - - - - - - diff --git a/libraries/permissions/impl/build.gradle.kts b/libraries/permissions/impl/build.gradle.kts index bd9b257fae..31a4e4bbb1 100644 --- a/libraries/permissions/impl/build.gradle.kts +++ b/libraries/permissions/impl/build.gradle.kts @@ -47,7 +47,6 @@ dependencies { implementation(projects.libraries.matrix.api) implementation(projects.libraries.matrixui) implementation(projects.libraries.designsystem) - implementation(projects.libraries.elementresources) implementation(projects.libraries.uiStrings) api(projects.libraries.permissions.api) diff --git a/libraries/textcomposer/build.gradle.kts b/libraries/textcomposer/build.gradle.kts index dee2abc5c6..76d7d00a03 100644 --- a/libraries/textcomposer/build.gradle.kts +++ b/libraries/textcomposer/build.gradle.kts @@ -25,7 +25,6 @@ android { } dependencies { - implementation(projects.libraries.elementresources) implementation(projects.libraries.uiStrings) implementation(projects.libraries.androidutils) implementation(projects.libraries.core) From 9264dd891e6a9ce94428adcde38bf7a9e82215fa Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 27 Jun 2023 13:38:55 +0200 Subject: [PATCH 2/4] More cleanup --- .../libraries/textcomposer/TextComposer.kt | 4 +-- .../color/selector_rich_text_menu_icon.xml | 24 ------------- .../src/main/res/drawable/ic_reply.xml | 36 ------------------- .../src/main/res/values/dimens.xml | 27 -------------- .../src/main/res/values/strings.xml | 24 ------------- 5 files changed, 2 insertions(+), 113 deletions(-) delete mode 100644 libraries/textcomposer/src/main/res/color/selector_rich_text_menu_icon.xml delete mode 100644 libraries/textcomposer/src/main/res/drawable/ic_reply.xml delete mode 100644 libraries/textcomposer/src/main/res/values/dimens.xml delete mode 100644 libraries/textcomposer/src/main/res/values/strings.xml diff --git a/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt b/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt index 0256d7e529..a642f566de 100644 --- a/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt +++ b/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt @@ -212,12 +212,12 @@ private fun EditingModeView( .padding(horizontal = 12.dp, vertical = 8.dp)) { Icon( resourceId = VectorIcons.Edit, - contentDescription = stringResource(R.string.editing), + contentDescription = stringResource(StringR.string.common_editing), tint = MaterialTheme.colorScheme.secondary, modifier = Modifier.size(16.dp), ) Text( - stringResource(R.string.editing), + stringResource(StringR.string.common_editing), style = ElementTextStyles.Regular.caption2, textAlign = TextAlign.Start, color = MaterialTheme.colorScheme.secondary, diff --git a/libraries/textcomposer/src/main/res/color/selector_rich_text_menu_icon.xml b/libraries/textcomposer/src/main/res/color/selector_rich_text_menu_icon.xml deleted file mode 100644 index 04f3b25ee9..0000000000 --- a/libraries/textcomposer/src/main/res/color/selector_rich_text_menu_icon.xml +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - - - - - diff --git a/libraries/textcomposer/src/main/res/drawable/ic_reply.xml b/libraries/textcomposer/src/main/res/drawable/ic_reply.xml deleted file mode 100644 index d23bd1c3ab..0000000000 --- a/libraries/textcomposer/src/main/res/drawable/ic_reply.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - diff --git a/libraries/textcomposer/src/main/res/values/dimens.xml b/libraries/textcomposer/src/main/res/values/dimens.xml deleted file mode 100644 index 297174eadb..0000000000 --- a/libraries/textcomposer/src/main/res/values/dimens.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - 56dp - 52dp - 1dp - 28dp - 14dp - 44dp - - diff --git a/libraries/textcomposer/src/main/res/values/strings.xml b/libraries/textcomposer/src/main/res/values/strings.xml deleted file mode 100644 index 5c8599f8d7..0000000000 --- a/libraries/textcomposer/src/main/res/values/strings.xml +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - Editing - Replying to %s - Quoting - - From 698d5174ffd6e42922f0b3cf3ed741f24c6f85df Mon Sep 17 00:00:00 2001 From: ElementBot Date: Tue, 27 Jun 2023 13:54:18 +0000 Subject: [PATCH 3/4] Update screenshots --- ...Group_SheetContentDarkPreview_0_null_2,NEXUS_5,1.0,en].png | 4 ++-- ...roup_SheetContentLightPreview_0_null_2,NEXUS_5,1.0,en].png | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentDarkPreview_0_null_2,NEXUS_5,1.0,en].png b/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentDarkPreview_0_null_2,NEXUS_5,1.0,en].png index a0389de72b..b5e7048dbe 100644 --- a/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentDarkPreview_0_null_2,NEXUS_5,1.0,en].png +++ b/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentDarkPreview_0_null_2,NEXUS_5,1.0,en].png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:14286b8d22070f428630ae1d4244da42f33d4aa4906fbcc09cae4a034ded7707 -size 33693 +oid sha256:defe10ab6c6e909675005322247dda4a8c8dbabaf3bc11b0299dc379ae483e8f +size 33487 diff --git a/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentLightPreview_0_null_2,NEXUS_5,1.0,en].png b/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentLightPreview_0_null_2,NEXUS_5,1.0,en].png index 55932b4fea..4f9e54b4ef 100644 --- a/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentLightPreview_0_null_2,NEXUS_5,1.0,en].png +++ b/tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.messages.impl.actionlist_null_DefaultGroup_SheetContentLightPreview_0_null_2,NEXUS_5,1.0,en].png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e30d0f0aff589c97e152b48d701a66ff323ab74aa1215af8dc1962bbff1a7204 -size 32867 +oid sha256:549c198a89aed0e8fd4b4b7589139897be88c99f347418df19017dea57e4c289 +size 32676 From 44e53b9526875fff50bdfadbe5f5605e74f42ad3 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 27 Jun 2023 16:11:32 +0200 Subject: [PATCH 4/4] StringR -> CommonStrings --- .../io/element/android/libraries/textcomposer/TextComposer.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt b/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt index 72aea4829d..759f7d1c76 100644 --- a/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt +++ b/libraries/textcomposer/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt @@ -212,12 +212,12 @@ private fun EditingModeView( .padding(horizontal = 12.dp, vertical = 8.dp)) { Icon( resourceId = VectorIcons.Edit, - contentDescription = stringResource(StringR.string.common_editing), + contentDescription = stringResource(CommonStrings.common_editing), tint = MaterialTheme.colorScheme.secondary, modifier = Modifier.size(16.dp), ) Text( - stringResource(StringR.string.common_editing), + stringResource(CommonStrings.common_editing), style = ElementTextStyles.Regular.caption2, textAlign = TextAlign.Start, color = MaterialTheme.colorScheme.secondary,