Fix PR comments

This commit is contained in:
yostyle 2023-08-11 14:07:59 +02:00
parent 01a0175d40
commit 0214ca66a6
4 changed files with 11 additions and 12 deletions

View file

@ -60,9 +60,9 @@ class RoomDetailsPresenter @Inject constructor(
val scope = rememberCoroutineScope()
val leaveRoomState = leaveRoomPresenter.present()
LaunchedEffect(Unit) {
room.updateMembers()
room.updateRoomNotificationSettings()
observeNotificationSettings()
room.updateMembers()
}
val membersState by room.membersStateFlow.collectAsState()

View file

@ -306,7 +306,11 @@ internal fun TopicSection(
@Composable
internal fun NotificationSection(state: RoomDetailsState, openRoomNotificationSettings: () -> Unit, modifier: Modifier = Modifier) {
state.roomNotificationSettings?.let {
val subtitle = if (it.isDefault) "Default" else "Custom"
val subtitle = if (it.isDefault) {
stringResource(R.string.screen_room_details_notification_mode_default)
} else {
stringResource(R.string.screen_room_details_notification_mode_custom)
}
PreferenceCategory(modifier = modifier) {
PreferenceText(
title = stringResource(R.string.screen_room_details_notification_title),

View file

@ -51,7 +51,7 @@ class RoomNotificationSettingsNode @AssistedInject constructor(
RoomNotificationSettingsView(
state = state,
modifier = modifier,
onBackPressed = { navigateUp() },
onBackPressed = this::navigateUp,
)
}
}

View file

@ -26,10 +26,9 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import io.element.android.libraries.designsystem.preview.ElementPreviewDark
import io.element.android.libraries.designsystem.preview.ElementPreviewLight
import io.element.android.libraries.designsystem.preview.DayNightPreviews
import io.element.android.libraries.designsystem.preview.ElementPreview
import io.element.android.libraries.designsystem.theme.components.RadioButton
import io.element.android.libraries.designsystem.theme.components.Text
import io.element.android.libraries.designsystem.toEnabledColor
@ -78,13 +77,9 @@ fun RoomNotificationSettingsOption(
}
}
@Preview
@DayNightPreviews
@Composable
fun RoomPrivacyOptionLightPreview() = ElementPreviewLight { ContentToPreview() }
@Preview
@Composable
fun RoomPrivacyOptionDarkPreview() = ElementPreviewDark { ContentToPreview() }
fun RoomPrivacyOptionLightPreview() = ElementPreview { ContentToPreview() }
@Composable
private fun ContentToPreview() {