Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #983 from vector-im/feature/bma/lintErrors

Browse source 
Update lint rules, remove unused resource and sync strings.
This commit is contained in:
Benoit Marty 2023-07-27 15:59:38 +02:00 • committed by GitHub
commit 036658232b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
38 changed files with 53 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tools/lint/lint.xml
View file

@ -25,7 +25,7 @@
<!-- Resource -->
<issue id="MissingTranslation" severity="ignore" />
<issue id="TypographyEllipsis" severity="error" />
<issue id="ImpliedQuantity" severity="warning" />
<issue id="ImpliedQuantity" severity="error" />
<issue id="MissingQuantity" severity="warning" />
<issue id="UnusedQuantity" severity="error" />
<issue id="IconXmlAndPng" severity="error" />
@ -43,24 +43,11 @@
<ignore path="**/src/debug/**" />
</issue>
<issue id="UnusedResources" severity="warning">
<issue id="UnusedResources" severity="error">
<!-- Ignore unused strings resource from localazy -->
<ignore path="**/localazy.xml" />
<!-- Ignore unused resource in debug build type -->
<ignore path="**/src/debug/**" />
<!-- Following resources are for F-Droid variant only, so ignore for GPlay -->
<ignore regexp="settings_troubleshoot_test_service_boot_*" />
<ignore regexp="settings_troubleshoot_test_bg_restricted_*" />
<ignore regexp="settings_troubleshoot_test_battery_*" />
<!-- Following resources are for GPlay variant only, so ignore for F-Droid -->
<ignore regexp="settings_troubleshoot_test_play_services_" />
<ignore regexp="settings_troubleshoot_test_push_loop_" />
<ignore regexp="settings_troubleshoot_test_token_registration_" />
<ignore regexp="settings_troubleshoot_test_fcm_" />
<ignore regexp="no_valid_google_play_services_apk" />
<ignore regexp="sas_error_unknown" />
</issue>
<!-- UX -->
@ -81,7 +68,6 @@
<issue id="DisableBaselineAlignment" severity="error" />
<issue id="ScrollViewSize" severity="error" />
<issue id="NegativeMargin" severity="error" />
<issue id="UseCompatTextViewDrawableXml" severity="error" />
<!-- RTL -->
<issue id="RtlEnabled" severity="error" />