Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1862 from vector-im/feature/bma/moreTests

Browse source 
Remove lambda default value
This commit is contained in:
Benoit Marty 2023-11-24 11:00:34 +01:00 • committed by GitHub
commit 05ba424e75
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
49 changed files with 436 additions and 230 deletions
Download patch file Download diff file Expand all files Collapse all files

12
features/invitelist/impl/src/main/kotlin/io/element/android/features/invitelist/impl/InviteListView.kt
View file

@ -53,9 +53,9 @@ import io.element.android.libraries.ui.strings.CommonStrings
@Composable
fun InviteListView(
state: InviteListState,
onBackClicked: () -> Unit,
onInviteAccepted: (RoomId) -> Unit,
modifier: Modifier = Modifier,
onBackClicked: () -> Unit = {},
onInviteAccepted: (RoomId) -> Unit = {},
) {
if (state.acceptedAction is Async.Success) {
LaunchedEffect(state.acceptedAction) {
@ -113,8 +113,8 @@ fun InviteListView(
@Composable
private fun InviteListContent(
state: InviteListState,
onBackClicked: () -> Unit,
modifier: Modifier = Modifier,
onBackClicked: () -> Unit = {},
) {
Scaffold(
modifier = modifier,
@ -173,5 +173,9 @@ private fun InviteListContent(
@PreviewsDayNight
@Composable
internal fun InviteListViewPreview(@PreviewParameter(InviteListStateProvider::class) state: InviteListState) = ElementPreview {
InviteListView(state)
InviteListView(
state = state,
onBackClicked = {},
onInviteAccepted = {},
)
}

16
features/invitelist/impl/src/main/kotlin/io/element/android/features/invitelist/impl/components/InviteSummaryRow.kt
View file

@ -45,8 +45,8 @@ import io.element.android.features.invitelist.impl.model.InviteListInviteSummary
import io.element.android.features.invitelist.impl.model.InviteSender
import io.element.android.libraries.designsystem.atomic.atoms.UnreadIndicatorAtom
import io.element.android.libraries.designsystem.components.avatar.Avatar
import io.element.android.libraries.designsystem.preview.PreviewsDayNight
import io.element.android.libraries.designsystem.preview.ElementPreview
import io.element.android.libraries.designsystem.preview.PreviewsDayNight
import io.element.android.libraries.designsystem.theme.components.Button
import io.element.android.libraries.designsystem.theme.components.ButtonSize
import io.element.android.libraries.designsystem.theme.components.OutlinedButton
@ -59,9 +59,9 @@ private val minHeight = 72.dp
@Composable
internal fun InviteSummaryRow(
invite: InviteListInviteSummary,
onAcceptClicked: () -> Unit,
onDeclineClicked: () -> Unit,
modifier: Modifier = Modifier,
onAcceptClicked: () -> Unit = {},
onDeclineClicked: () -> Unit = {},
) {
Box(
modifier = modifier
@ -79,8 +79,8 @@ internal fun InviteSummaryRow(
@Composable
private fun DefaultInviteSummaryRow(
invite: InviteListInviteSummary,
onAcceptClicked: () -> Unit = {},
onDeclineClicked: () -> Unit = {},
onAcceptClicked: () -> Unit,
onDeclineClicked: () -> Unit,
) {
Row(
modifier = Modifier
@ -187,5 +187,9 @@ private fun SenderRow(sender: InviteSender) {
@PreviewsDayNight
@Composable
internal fun InviteSummaryRowPreview(@PreviewParameter(InviteListInviteSummaryProvider::class) data: InviteListInviteSummary) = ElementPreview {
InviteSummaryRow(data)
InviteSummaryRow(
invite = data,
onAcceptClicked = {},
onDeclineClicked = {},
)
}