Code quality

Code quality
This commit is contained in:
Benoit Marty 2022-12-21 15:32:53 +01:00
parent 4c88d8e3c2
commit 0644a5822f
30 changed files with 44 additions and 51 deletions

View file

@ -8,7 +8,6 @@ package io.element.android.x
import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.activity.viewModels
import androidx.compose.animation.AnimatedContentScope
import androidx.compose.animation.ExperimentalAnimationApi
import androidx.compose.animation.core.tween
@ -38,16 +37,12 @@ import androidx.core.view.WindowCompat
import androidx.navigation.NavHostController
import com.airbnb.android.showkase.models.Showkase
import com.airbnb.mvrx.compose.mavericksActivityViewModel
import com.airbnb.mvrx.compose.mavericksViewModel
import com.google.accompanist.navigation.material.ExperimentalMaterialNavigationApi
import com.ramcosta.composedestinations.DestinationsNavHost
import com.ramcosta.composedestinations.animations.defaults.RootNavGraphDefaultAnimations
import com.ramcosta.composedestinations.animations.rememberAnimatedNavHostEngine
import com.ramcosta.composedestinations.manualcomposablecalls.animatedComposable
import com.ramcosta.composedestinations.navigation.dependency
import com.ramcosta.composedestinations.spec.Route
import io.element.android.x.core.compose.OnLifecycleEvent
import io.element.android.x.core.di.DaggerComponentOwner
import io.element.android.x.designsystem.ElementXTheme
import io.element.android.x.destinations.OnBoardingScreenNavigationDestination
import kotlinx.coroutines.runBlocking
@ -160,7 +155,6 @@ class MainActivity : ComponentActivity() {
navGraph = NavGraphs.root,
startRoute = startRoute,
dependenciesContainerBuilder = {
}
)
}

View file

@ -9,4 +9,4 @@ interface AppBindings {
fun coroutineScope(): CoroutineScope
fun matrix(): Matrix
fun sessionComponentsOwner(): SessionComponentsOwner
}
}

View file

@ -8,10 +8,10 @@ import io.element.android.x.core.di.DaggerMavericksBindings
@SingleIn(AppScope::class)
@MergeComponent(AppScope::class)
interface AppComponent: DaggerMavericksBindings {
interface AppComponent : DaggerMavericksBindings {
@Component.Factory
interface Factory {
fun create(@ApplicationContext @BindsInstance context: Context): AppComponent
}
}
}

View file

@ -17,4 +17,4 @@ object AppModule {
fun providesAppCoroutineScope(): CoroutineScope {
return MainScope() + CoroutineName("ElementX Scope")
}
}
}

View file

@ -9,7 +9,7 @@ import io.element.android.x.matrix.MatrixClient
@SingleIn(SessionScope::class)
@MergeSubcomponent(SessionScope::class)
interface SessionComponent: DaggerMavericksBindings {
interface SessionComponent : DaggerMavericksBindings {
fun matrixClient(): MatrixClient

View file

@ -41,5 +41,4 @@ class SessionComponentsOwner @Inject constructor(@ApplicationContext private val
activeSessionComponent = null
}
}
}

View file

@ -35,6 +35,4 @@ private class ElementImageLoaderFactory(
}
.build()
}
}
}

View file

@ -2,7 +2,6 @@ package io.element.android.x.initializer
import android.content.Context
import androidx.startup.Initializer
import com.airbnb.mvrx.Mavericks
import io.element.android.x.matrix.tracing.TracingConfigurations
import io.element.android.x.matrix.tracing.setupTracing
import io.element.android.x.sdk.matrix.BuildConfig
@ -18,6 +17,4 @@ class MatrixInitializer : Initializer<Unit> {
}
override fun dependencies(): List<Class<out Initializer<*>>> = emptyList()
}
}

View file

@ -11,6 +11,4 @@ class MavericksInitializer : Initializer<Unit> {
}
override fun dependencies(): List<Class<out Initializer<*>>> = listOf()
}
}

View file

@ -12,4 +12,4 @@ class TimberInitializer : Initializer<Unit> {
override fun dependencies(): List<Class<out Initializer<*>>> =
listOf(TimberInitializer::class.java)
}
}