Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Danger: don't complain about reviewers (#509)

Browse source 
Now we have a CODEOWNERS file a reviewer is assigned automatically,
so there's no need for this.

It also misfires a bunch (maybe if there are no _pending_ reviewers
because they've already reviewed?), so removing it fixes that noise.
This commit is contained in:
Chris Smith 2023-06-01 15:02:28 +01:00 • committed by GitHub
parent 4d9c08bead
commit 09411f8993
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tools/danger/dangerfile.js
View file

@ -171,11 +171,6 @@ if (hasPngs) {
warn("You seem to have made changes to some images. Please consider using an vector drawable.") warn("You seem to have made changes to some images. Please consider using an vector drawable.")
} }
// Check for reviewers
if (github.requested_reviewers.users.length == 0 && !pr.draft) {
warn("Please add a reviewer to your PR.")
}
// Check that translations have not been modified by developers // Check that translations have not been modified by developers
const translationAllowList = [ const translationAllowList = [
"RiotTranslateBot", "RiotTranslateBot",