Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Cleanup and use indeterminate progress indicator

Browse source
This commit is contained in:
Benoit Marty 2023-03-16 16:31:44 +01:00
parent 35a45f41ea
commit 0ae4b154e9
4 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/bugreport/BugReportView.kt
View file

@ -197,8 +197,8 @@ fun BugReportView(
} }
when (state.sending) { when (state.sending) {
is Async.Loading -> { is Async.Loading -> {
// Indeterminate indicator, to avoid the freeze effect if the connection takes time to initialize.
CircularProgressIndicator( CircularProgressIndicator(
progress = state.sendingProgress,
modifier = Modifier.align(Alignment.Center) modifier = Modifier.align(Alignment.Center)
) )
} }

4
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt
View file

@ -484,9 +484,9 @@ class DefaultBugReporter @Inject constructor(
return compressFile(logCatErrFile) return compressFile(logCatErrFile)
} catch (error: OutOfMemoryError) { } catch (error: OutOfMemoryError) {
Timber.e(error, "## saveLogCat() : fail to write logcat$error") Timber.e(error, "## saveLogCat() : fail to write logcat OOM")
} catch (e: Exception) { } catch (e: Exception) {
Timber.e(e, "## saveLogCat() : fail to write logcat$e") Timber.e(e, "## saveLogCat() : fail to write logcat")
} }
return null return null

4
tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.rageshake.impl.bugreport_null_DefaultGroup_BugReportViewDarkPreview_0_null_2,NEXUS_5,1.0,en].png
View file

@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:5c34404a33be8eb234025442da98fc85e29236769c200bd0e40cc2cf8f9db3e4 oid sha256:9b432f300926890ddc7dcc59051b3b31a2a1185ba1d527d776378547433905d9
size 52604 size 52789

4
tests/uitests/src/test/snapshots/images/io.element.android.tests.uitests_ScreenshotTest_preview_tests[io.element.android.features.rageshake.impl.bugreport_null_DefaultGroup_BugReportViewLightPreview_0_null_2,NEXUS_5,1.0,en].png
View file

@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:e628e65234a8632350cdc9ab014b36f3c2bd9e35977bc6d919314a32c2f8a1cf oid sha256:08cb1e38ee31bf4931d3835d471e61e5cc51d8b6ca5fca3d3044ba85686777ea
size 50965 size 51075