Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Danger: remove "add screenshots" warning (#691)

Browse source 
We have screenshot tests that basically negate the need for this,
and when we're doing more complicated things we tend to use
videos anyway which aren't caught by this check.
This commit is contained in:
Chris Smith 2023-06-27 14:37:44 +01:00 • committed by GitHub
parent 2a82e1b4e4
commit 0eb195560b
1 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tools/danger/dangerfile.js
View file

@ -155,14 +155,6 @@ if (buildFilesWithMissingProcessor.length > 0) {
warn("You have made changes to a file containing a `@Preview` annotated function but its module doesn't include the showkase processor. Missing processor in: " + buildFilesWithMissingProcessor.join(", "))
}
// Check for screenshots on view changes
const hasChangedViews = filesWithPreviews.length > 0
if (hasChangedViews) {
if (!pr.body.includes("user-images")) {
warn("You seem to have made changes to views. Please consider adding screenshots.")
}
}
// Check for pngs on resources
const hasPngs = editedFiles.filter(file => {
file.toLowerCase().endsWith(".png") && !file.includes("snapshots/images/") // Exclude screenshots