Migrate to v2 testing APIs

This commit is contained in:
Benoit Marty 2026-04-30 15:54:33 +02:00
parent da36323006
commit 11b9efa2c9
83 changed files with 2197 additions and 2320 deletions

View file

@ -6,11 +6,14 @@
* Please see LICENSE files in the repository root for full details.
*/
@file:OptIn(ExperimentalTestApi::class)
package io.element.android.features.roommembermoderation.impl
import androidx.activity.ComponentActivity
import androidx.compose.ui.test.junit4.AndroidComposeTestRule
import androidx.compose.ui.test.junit4.createAndroidComposeRule
import androidx.compose.ui.test.AndroidComposeUiTest
import androidx.compose.ui.test.ExperimentalTestApi
import androidx.compose.ui.test.v2.runAndroidComposeUiTest
import androidx.test.ext.junit.runners.AndroidJUnit4
import io.element.android.features.roommembermoderation.api.ModerationAction
import io.element.android.features.roommembermoderation.api.ModerationActionState
@ -24,21 +27,17 @@ import io.element.android.tests.testutils.clickOn
import io.element.android.tests.testutils.ensureCalledOnceWithTwoParams
import io.element.android.tests.testutils.pressTag
import io.element.android.tests.testutils.setSafeContent
import org.junit.Rule
import org.junit.Test
import org.junit.rules.TestRule
import org.junit.runner.RunWith
@RunWith(AndroidJUnit4::class)
class RoomMemberModerationViewTest {
@get:Rule val rule = createAndroidComposeRule<ComponentActivity>()
@Test
fun `clicking on display profile action calls onSelectAction`() {
fun `clicking on display profile action calls onSelectAction`() = runAndroidComposeUiTest {
val user = anAlice()
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>(expectEvents = false)
ensureCalledOnceWithTwoParams<ModerationAction, MatrixUser>(ModerationAction.DisplayProfile, user) { callback ->
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = user,
actions = listOf(
@ -48,16 +47,16 @@ class RoomMemberModerationViewTest {
),
onSelectAction = callback
)
rule.clickOn(R.string.screen_bottom_sheet_manage_room_member_member_user_info)
clickOn(R.string.screen_bottom_sheet_manage_room_member_member_user_info)
}
}
@Test
fun `clicking on kick user action calls onSelectAction`() {
fun `clicking on kick user action calls onSelectAction`() = runAndroidComposeUiTest {
val user = anAlice()
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>(expectEvents = false)
ensureCalledOnceWithTwoParams<ModerationAction, MatrixUser>(ModerationAction.KickUser, user) { callback ->
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = user,
actions = listOf(
@ -67,18 +66,18 @@ class RoomMemberModerationViewTest {
),
onSelectAction = callback
)
rule.clickOn(R.string.screen_bottom_sheet_manage_room_member_remove)
clickOn(R.string.screen_bottom_sheet_manage_room_member_remove)
// Gives time for bottomsheet to hide
rule.mainClock.advanceTimeBy(1_000)
mainClock.advanceTimeBy(1_000)
}
}
@Test
fun `clicking on ban user action calls onSelectAction`() {
fun `clicking on ban user action calls onSelectAction`() = runAndroidComposeUiTest {
val user = anAlice()
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>(expectEvents = false)
ensureCalledOnceWithTwoParams<ModerationAction, MatrixUser>(ModerationAction.BanUser, user) { callback ->
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = user,
actions = listOf(
@ -88,18 +87,18 @@ class RoomMemberModerationViewTest {
),
onSelectAction = callback
)
rule.clickOn(R.string.screen_bottom_sheet_manage_room_member_ban)
clickOn(R.string.screen_bottom_sheet_manage_room_member_ban)
// Gives time for bottomsheet to hide
rule.mainClock.advanceTimeBy(1_000)
mainClock.advanceTimeBy(1_000)
}
}
@Test
fun `clicking on unban user action calls onSelectAction`() {
fun `clicking on unban user action calls onSelectAction`() = runAndroidComposeUiTest {
val user = anAlice()
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>(expectEvents = false)
ensureCalledOnceWithTwoParams<ModerationAction, MatrixUser>(ModerationAction.UnbanUser, user) { callback ->
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = user,
actions = listOf(
@ -109,100 +108,100 @@ class RoomMemberModerationViewTest {
),
onSelectAction = callback
)
rule.clickOn(R.string.screen_bottom_sheet_manage_room_member_unban)
clickOn(R.string.screen_bottom_sheet_manage_room_member_unban)
// Gives time for bottomsheet to hide
rule.mainClock.advanceTimeBy(1_000)
mainClock.advanceTimeBy(1_000)
}
}
@Test
fun `clicking submit on kick confirmation dialog sends DoKickUser event`() {
fun `clicking submit on kick confirmation dialog sends DoKickUser event`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>()
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = anAlice(),
kickUserAsyncAction = AsyncAction.ConfirmingNoParams,
eventSink = eventsRecorder
),
)
rule.pressTag(TestTags.dialogPositive.value)
pressTag(TestTags.dialogPositive.value)
eventsRecorder.assertSingle(InternalRoomMemberModerationEvents.DoKickUser(reason = ""))
}
@Test
fun `clicking dismiss on kick confirmation dialog sends Reset event`() {
fun `clicking dismiss on kick confirmation dialog sends Reset event`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>()
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = anAlice(),
kickUserAsyncAction = AsyncAction.ConfirmingNoParams,
eventSink = eventsRecorder
),
)
rule.pressTag(TestTags.dialogNegative.value)
pressTag(TestTags.dialogNegative.value)
eventsRecorder.assertSingle(InternalRoomMemberModerationEvents.Reset)
}
@Test
fun `clicking submit on ban confirmation dialog sends DoBanUser event`() {
fun `clicking submit on ban confirmation dialog sends DoBanUser event`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>()
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = anAlice(),
banUserAsyncAction = AsyncAction.ConfirmingNoParams,
eventSink = eventsRecorder
),
)
rule.pressTag(TestTags.dialogPositive.value)
pressTag(TestTags.dialogPositive.value)
eventsRecorder.assertSingle(InternalRoomMemberModerationEvents.DoBanUser(reason = ""))
}
@Test
fun `clicking dismiss on ban confirmation dialog sends Reset event`() {
fun `clicking dismiss on ban confirmation dialog sends Reset event`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>()
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = anAlice(),
banUserAsyncAction = AsyncAction.ConfirmingNoParams,
eventSink = eventsRecorder
),
)
rule.pressTag(TestTags.dialogNegative.value)
pressTag(TestTags.dialogNegative.value)
eventsRecorder.assertSingle(InternalRoomMemberModerationEvents.Reset)
}
@Test
fun `clicking confirm on unban confirmation dialog sends DoUnbanUser event`() {
fun `clicking confirm on unban confirmation dialog sends DoUnbanUser event`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>()
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = anAlice(),
unbanUserAsyncAction = AsyncAction.ConfirmingNoParams,
eventSink = eventsRecorder
),
)
rule.pressTag(TestTags.dialogPositive.value)
pressTag(TestTags.dialogPositive.value)
eventsRecorder.assertSingle(InternalRoomMemberModerationEvents.DoUnbanUser(""))
}
@Test
fun `clicking dismiss on unban confirmation dialog sends Reset event`() {
fun `clicking dismiss on unban confirmation dialog sends Reset event`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>()
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = anAlice(),
unbanUserAsyncAction = AsyncAction.ConfirmingNoParams,
eventSink = eventsRecorder
),
)
rule.pressTag(TestTags.dialogNegative.value)
pressTag(TestTags.dialogNegative.value)
eventsRecorder.assertSingle(InternalRoomMemberModerationEvents.Reset)
}
@Test
fun `disabled actions are not clickable`() {
fun `disabled actions are not clickable`() = runAndroidComposeUiTest {
val eventsRecorder = EventsRecorder<RoomMemberModerationEvents>(expectEvents = false)
rule.setRoomMemberModerationView(
setRoomMemberModerationView(
aRoomMembersModerationState(
selectedUser = anAlice(),
actions = listOf(
@ -211,11 +210,11 @@ class RoomMemberModerationViewTest {
eventSink = eventsRecorder
),
)
rule.clickOn(R.string.screen_bottom_sheet_manage_room_member_remove)
clickOn(R.string.screen_bottom_sheet_manage_room_member_remove)
}
}
private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setRoomMemberModerationView(
private fun AndroidComposeUiTest<ComponentActivity>.setRoomMemberModerationView(
state: InternalRoomMemberModerationState,
onSelectAction: (ModerationAction, MatrixUser) -> Unit = EnsureNeverCalledWithTwoParams(),
) {