Iterate design on several screens: update icons, replace PreferenceTexts (#1771)

- Batch import new icons from the design team.
- Rename _september icons since they're just extra icons that need to be integrated in Compound in the future, and it should be ok if we don't distinguish between ic_september_*, ic_november_* etc., so all icons are now simply ic_* in the designsystem module.
- Create a new CompoundIconListPreviewProvider to add chunked lists of icons for previews. Add an exception for it to Konsist.
- Move some icons to use Compound icons.
- Remove most PreferenceText usages, use ListItem instead.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsView.kt

@@ -32,7 +32,6 @@ import androidx.compose.foundation.verticalScroll
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.MoreVert
 import androidx.compose.material.icons.outlined.Add
-import androidx.compose.material.icons.outlined.Person
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
@@ -57,6 +56,7 @@ import io.element.android.libraries.designsystem.components.avatar.AvatarData
 import io.element.android.libraries.designsystem.components.avatar.AvatarSize
 import io.element.android.libraries.designsystem.components.button.BackButton
 import io.element.android.libraries.designsystem.components.button.MainActionButton
+import io.element.android.libraries.designsystem.components.list.ListItemContent
 import io.element.android.libraries.designsystem.components.preferences.PreferenceCategory
 import io.element.android.libraries.designsystem.components.preferences.PreferenceText
 import io.element.android.libraries.designsystem.preview.ElementPreviewDark
@@ -66,6 +66,9 @@ import io.element.android.libraries.designsystem.theme.components.DropdownMenu
 import io.element.android.libraries.designsystem.theme.components.DropdownMenuItem
 import io.element.android.libraries.designsystem.theme.components.Icon
 import io.element.android.libraries.designsystem.theme.components.IconButton
+import io.element.android.libraries.designsystem.theme.components.IconSource
+import io.element.android.libraries.designsystem.theme.components.ListItem
+import io.element.android.libraries.designsystem.theme.components.ListItemStyle
 import io.element.android.libraries.designsystem.theme.components.Scaffold
 import io.element.android.libraries.designsystem.theme.components.Text
 import io.element.android.libraries.designsystem.theme.components.TopAppBar
@@ -324,10 +327,10 @@ private fun NotificationSection(
         stringResource(R.string.screen_room_details_notification_mode_custom)
     }
     PreferenceCategory(modifier = modifier) {
-        PreferenceText(
-            title = stringResource(R.string.screen_room_details_notification_title),
-            subtitle = subtitle,
-            iconResourceId = CommonDrawables.ic_compound_notifications,
+        ListItem(
+            headlineContent = { Text(text = stringResource(R.string.screen_room_details_notification_title)) },
+            supportingContent = { Text(text = subtitle) },
+            leadingContent = ListItemContent.Icon(IconSource.Resource(CommonDrawables.ic_compound_notifications)),
             onClick = openRoomNotificationSettings,
         )
     }
@@ -340,10 +343,10 @@ private fun MembersSection(
     modifier: Modifier = Modifier,
 ) {
     PreferenceCategory(modifier = modifier) {
-        PreferenceText(
-            title = stringResource(CommonStrings.common_people),
-            icon = Icons.Outlined.Person,
-            currentValue = memberCount.toString(),
+        ListItem(
+            headlineContent = { Text(stringResource(CommonStrings.common_people)) },
+            leadingContent = ListItemContent.Icon(IconSource.Resource(CommonDrawables.ic_user)),
+            trailingContent = ListItemContent.Text(memberCount.toString()),
             onClick = openRoomMemberList,
         )
     }
@@ -355,9 +358,9 @@ private fun InviteSection(
     modifier: Modifier = Modifier,
 ) {
     PreferenceCategory(modifier = modifier) {
-        PreferenceText(
-            title = stringResource(R.string.screen_room_details_invite_people_title),
-            iconResourceId = CommonDrawables.ic_compound_user_add,
+        ListItem(
+            headlineContent = { Text(stringResource(R.string.screen_room_details_invite_people_title)) },
+            leadingContent = ListItemContent.Icon(IconSource.Resource(CommonDrawables.ic_user_add)),
             onClick = invitePeople,
         )
     }
@@ -366,10 +369,10 @@ private fun InviteSection(
 @Composable
 private fun SecuritySection(modifier: Modifier = Modifier) {
     PreferenceCategory(title = stringResource(R.string.screen_room_details_security_title), modifier = modifier) {
-        PreferenceText(
-            title = stringResource(R.string.screen_room_details_encryption_enabled_title),
-            subtitle = stringResource(R.string.screen_room_details_encryption_enabled_subtitle),
-            iconResourceId = CommonDrawables.ic_compound_lock,
+        ListItem(
+            headlineContent = { Text(stringResource(R.string.screen_room_details_encryption_enabled_title)) },
+            supportingContent = { Text(stringResource(R.string.screen_room_details_encryption_enabled_subtitle)) },
+            leadingContent = ListItemContent.Icon(IconSource.Resource(CommonDrawables.ic_encryption_enabled)),
         )
     }
 }
@@ -377,10 +380,10 @@ private fun SecuritySection(modifier: Modifier = Modifier) {
 @Composable
 private fun OtherActionsSection(onLeaveRoom: () -> Unit, modifier: Modifier = Modifier) {
     PreferenceCategory(showDivider = false, modifier = modifier) {
-        PreferenceText(
-            title = stringResource(R.string.screen_room_details_leave_room_title),
-            iconResourceId = CommonDrawables.ic_compound_leave,
-            tintColor = MaterialTheme.colorScheme.error,
+        ListItem(
+            headlineContent = { Text(stringResource(R.string.screen_room_details_leave_room_title)) },
+            leadingContent = ListItemContent.Icon(IconSource.Resource(CommonDrawables.ic_compound_leave)),
+            style = ListItemStyle.Destructive,
             onClick = onLeaveRoom,
         )
     }

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/blockuser/BlockUserSection.kt

@@ -16,20 +16,26 @@
 
 package io.element.android.features.roomdetails.impl.blockuser
 
-import androidx.compose.material.icons.Icons
-import androidx.compose.material.icons.outlined.Block
-import androidx.compose.material3.MaterialTheme
+import androidx.compose.foundation.layout.size
+import androidx.compose.foundation.progressSemantics
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.unit.dp
 import io.element.android.features.roomdetails.impl.R
 import io.element.android.features.roomdetails.impl.members.details.RoomMemberDetailsEvents
 import io.element.android.features.roomdetails.impl.members.details.RoomMemberDetailsState
 import io.element.android.libraries.architecture.Async
 import io.element.android.libraries.core.bool.orFalse
 import io.element.android.libraries.designsystem.components.dialogs.RetryDialog
+import io.element.android.libraries.designsystem.components.list.ListItemContent
 import io.element.android.libraries.designsystem.components.preferences.PreferenceCategory
-import io.element.android.libraries.designsystem.components.preferences.PreferenceText
+import io.element.android.libraries.designsystem.theme.components.CircularProgressIndicator
+import io.element.android.libraries.designsystem.theme.components.IconSource
+import io.element.android.libraries.designsystem.theme.components.ListItem
+import io.element.android.libraries.designsystem.theme.components.ListItemStyle
+import io.element.android.libraries.designsystem.theme.components.Text
+import io.element.android.libraries.designsystem.utils.CommonDrawables
 import io.element.android.libraries.ui.strings.CommonStrings
 
 @Composable
@@ -65,21 +71,29 @@ private fun PreferenceBlockUser(
     eventSink: (RoomMemberDetailsEvents) -> Unit,
     modifier: Modifier = Modifier,
 ) {
+    val loadingCurrentValue = @Composable {
+        CircularProgressIndicator(
+            modifier = Modifier
+                .progressSemantics()
+                .size(20.dp),
+            strokeWidth = 2.dp
+        )
+    }
     if (isBlocked.orFalse()) {
-        PreferenceText(
-            title = stringResource(R.string.screen_dm_details_unblock_user),
-            icon = Icons.Outlined.Block,
+        ListItem(
+            headlineContent = { Text(stringResource(R.string.screen_dm_details_unblock_user)) },
+            leadingContent = ListItemContent.Icon(IconSource.Resource(CommonDrawables.ic_compound_block)),
             onClick = { if (!isLoading) eventSink(RoomMemberDetailsEvents.UnblockUser(needsConfirmation = true)) },
-            loadingCurrentValue = isLoading,
+            trailingContent = if (isLoading) ListItemContent.Custom(loadingCurrentValue) else null,
             modifier = modifier,
         )
     } else {
-        PreferenceText(
-            title = stringResource(R.string.screen_dm_details_block_user),
-            icon = Icons.Outlined.Block,
-            tintColor = MaterialTheme.colorScheme.error,
+        ListItem(
+            headlineContent = { Text(stringResource(R.string.screen_dm_details_block_user)) },
+            leadingContent = ListItemContent.Icon(IconSource.Resource(CommonDrawables.ic_compound_block)),
+            style = ListItemStyle.Destructive,
             onClick = { if (!isLoading) eventSink(RoomMemberDetailsEvents.BlockUser(needsConfirmation = true)) },
-            loadingCurrentValue = isLoading,
+            trailingContent = if (isLoading) ListItemContent.Custom(loadingCurrentValue) else null,
             modifier = modifier,
         )
     }

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/UserDefinedRoomNotificationSettingsView.kt

@@ -22,25 +22,22 @@ import androidx.compose.foundation.layout.consumeWindowInsets
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
 import androidx.compose.material3.ExperimentalMaterial3Api
-import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.graphics.vector.ImageVector
 import androidx.compose.ui.res.stringResource
-import androidx.compose.ui.res.vectorResource
 import androidx.compose.ui.tooling.preview.PreviewParameter
 import androidx.compose.ui.unit.dp
 import io.element.android.features.roomdetails.impl.R
 import io.element.android.libraries.core.bool.orTrue
 import io.element.android.libraries.designsystem.components.async.AsyncView
 import io.element.android.libraries.designsystem.components.button.BackButton
-import io.element.android.libraries.designsystem.components.preferences.PreferenceText
 import io.element.android.libraries.designsystem.preview.ElementPreview
 import io.element.android.libraries.designsystem.preview.PreviewsDayNight
+import io.element.android.libraries.designsystem.theme.components.ListItem
+import io.element.android.libraries.designsystem.theme.components.ListItemStyle
 import io.element.android.libraries.designsystem.theme.components.Scaffold
 import io.element.android.libraries.designsystem.theme.components.Text
 import io.element.android.libraries.designsystem.theme.components.TopAppBar
-import io.element.android.libraries.designsystem.utils.CommonDrawables
 
 @Composable
 fun UserDefinedRoomNotificationSettingsView(
@@ -75,10 +72,9 @@ fun UserDefinedRoomNotificationSettingsView(
                 )
             }
 
-            PreferenceText(
-                title = stringResource(R.string.screen_room_notification_settings_edit_remove_setting),
-                icon = ImageVector.vectorResource(CommonDrawables.ic_compound_delete),
-                tintColor = MaterialTheme.colorScheme.error,
+            ListItem(
+                headlineContent = { Text(stringResource(R.string.screen_room_notification_settings_edit_remove_setting)) },
+                style = ListItemStyle.Destructive,
                 onClick = {
                     state.eventSink(RoomNotificationSettingsEvents.DeleteCustomNotification)
                 }