Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Enable detekt rules UnderscoresInNumericLiterals and fix existing issues.

Browse source
This commit is contained in:
Benoit Marty 2023-07-26 11:47:50 +02:00 • committed by Benoit Marty
parent 6fff373613
commit 15ac81d32a
5 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/crash/VectorUncaughtExceptionHandler.kt
View file

@ -62,9 +62,9 @@ class VectorUncaughtExceptionHandler(
totalSize = info.totalMemory() totalSize = info.totalMemory()
usedSize = totalSize - freeSize usedSize = totalSize - freeSize
} }
append("usedSize " + usedSize / 1048576L + " MB\n") append("usedSize " + usedSize / 1_048_576L + " MB\n")
append("freeSize " + freeSize / 1048576L + " MB\n") append("freeSize " + freeSize / 1_048_576L + " MB\n")
append("totalSize " + totalSize / 1048576L + " MB\n") append("totalSize " + totalSize / 1_048_576L + " MB\n")
append("Thread: ") append("Thread: ")
append(thread.name) append(thread.name)
append(", Exception: ") append(", Exception: ")

2
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/previews/DatePickerPreview.kt
View file

@ -44,7 +44,7 @@ internal fun DatePickerPreviewDark() {
@Composable @Composable
private fun ContentToPreview() { private fun ContentToPreview() {
val state = rememberDatePickerState( val state = rememberDatePickerState(
initialSelectedDateMillis = 1672578000000L, initialSelectedDateMillis = 1_672_578_000_000L,
) )
AlertDialogContent( AlertDialogContent(
buttons = { /*TODO*/ }, buttons = { /*TODO*/ },

2
libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/timeline/postprocessor/TimelineEncryptedHistoryPostProcessorTest.kt
View file

@ -27,7 +27,7 @@ import java.util.Date
class TimelineEncryptedHistoryPostProcessorTest { class TimelineEncryptedHistoryPostProcessorTest {
private val defaultLastLoginTimestamp = Date(1689061264L) private val defaultLastLoginTimestamp = Date(1_689_061_264L)
@Test @Test
fun `given an unencrypted room, nothing is done`() { fun `given an unencrypted room, nothing is done`() {

2
libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/notifications/NotificationIdProviderTest.kt
View file

@ -25,7 +25,7 @@ class NotificationIdProviderTest {
@Test @Test
fun `test notification id provider`() { fun `test notification id provider`() {
val sut = NotificationIdProvider() val sut = NotificationIdProvider()
val offsetForASessionId = 305410 val offsetForASessionId = 305_410
assertThat(sut.getSummaryNotificationId(A_SESSION_ID)).isEqualTo(offsetForASessionId + 0) assertThat(sut.getSummaryNotificationId(A_SESSION_ID)).isEqualTo(offsetForASessionId + 0)
assertThat(sut.getRoomMessagesNotificationId(A_SESSION_ID)).isEqualTo(offsetForASessionId + 1) assertThat(sut.getRoomMessagesNotificationId(A_SESSION_ID)).isEqualTo(offsetForASessionId + 1)
assertThat(sut.getRoomEventNotificationId(A_SESSION_ID)).isEqualTo(offsetForASessionId + 2) assertThat(sut.getRoomEventNotificationId(A_SESSION_ID)).isEqualTo(offsetForASessionId + 2)

4
tools/detekt/detekt.yml
View file

@ -56,6 +56,10 @@ style:
active: true active: true
OptionalUnit: OptionalUnit:
active: true active: true
UnderscoresInNumericLiterals:
active: true
acceptableLength: 4
allowNonStandardGrouping: false
coroutines: coroutines:
GlobalCoroutineUsage: GlobalCoroutineUsage: