Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve confusing text in the 'ready to start verification' screen (#1751)

Browse source 
* Improve confusing text in the 'ready to start verification' screen

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
This commit is contained in:
Jorge Martin Espinosa 2023-11-07 14:33:26 +01:00 • committed by GitHub
parent 2de508c6d5
commit 1fe45cde18
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/879.bugfix Normal file
View file

@ -0,0 +1 @@
Improve confusing text in the 'ready to start verification' screen.

3
features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/VerifySelfSessionView.kt
View file

@ -106,7 +106,8 @@ private fun HeaderContent(verificationFlowStep: FlowStep, modifier: Modifier = M
FlowStep.Initial -> R.string.screen_session_verification_open_existing_session_subtitle
FlowStep.Canceled -> R.string.screen_session_verification_cancelled_subtitle
FlowStep.AwaitingOtherDeviceResponse -> R.string.screen_session_verification_waiting_to_accept_subtitle
FlowStep.Ready, is FlowStep.Verifying, FlowStep.Completed -> R.string.screen_session_verification_compare_emojis_subtitle
is FlowStep.Verifying, FlowStep.Completed -> R.string.screen_session_verification_compare_emojis_subtitle
FlowStep.Ready -> R.string.screen_session_verification_ready_subtitle
}
IconTitleSubtitleMolecule(

1
features/verifysession/impl/src/main/res/values/localazy.xml
View file

@ -9,6 +9,7 @@
<string name="screen_session_verification_positive_button_canceled">"Retry verification"</string>
<string name="screen_session_verification_positive_button_initial">"I am ready"</string>
<string name="screen_session_verification_positive_button_verifying_ongoing">"Waiting to match"</string>
<string name="screen_session_verification_ready_subtitle">"Compare a unique set of emojis."</string>
<string name="screen_session_verification_request_accepted_subtitle">"Compare the unique emoji, ensuring they appear in the same order."</string>
<string name="screen_session_verification_they_dont_match">"They don’t match"</string>
<string name="screen_session_verification_they_match">"They match"</string>

2
libraries/ui-strings/src/main/res/values/localazy.xml
View file

@ -171,7 +171,7 @@
<string name="common_video">"Video"</string>
<string name="common_voice_message">"Voice message"</string>
<string name="common_waiting">"Waiting…"</string>
<string name="common_waiting_for_decryption_key">"Waiting for decryption key"</string>
<string name="common_waiting_for_decryption_key">"Waiting for this message"</string>
<string name="common_poll_end_confirmation">"Are you sure you want to end this poll?"</string>
<string name="common_poll_summary">"Poll: %1$s"</string>
<string name="dialog_title_confirmation">"Confirmation"</string>

4
tests/uitests/src/test/snapshots/images/ui_S_t[f.verifysession.impl_VerifySelfSessionView_null_VerifySelfSessionView-Day-0_0_null_5,NEXUS_5,1.0,en].png
View file

@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:d72279090c4eac63216dda487881676e936152e1fb7935a94652ce569867f07b
size 26329
oid sha256:70d489b8ff343e27f95065f4f201b44607837dda177eb1f331a2def661e121c1
size 21009

4
tests/uitests/src/test/snapshots/images/ui_S_t[f.verifysession.impl_VerifySelfSessionView_null_VerifySelfSessionView-Night-0_1_null_5,NEXUS_5,1.0,en].png
View file

@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:3d27a9ad71f9b9e5884e6a3139223df1fb322e993a55f1226a5746a238110879
size 25350
oid sha256:48a8536aa38e0bb678d87b835ace8c5811f97e2311a771ed37b04aabd142f69b
size 19981