Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Handle click on reply navigation.

Browse source
This commit is contained in:
Benoit Marty 2024-04-29 17:55:31 +02:00 • committed by Benoit Marty
parent c89f4d1596
commit 20e376896e
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelineView.kt
View file

@ -108,9 +108,8 @@ fun TimelineView(
accessibilityManager.isTouchExplorationEnabled.not() accessibilityManager.isTouchExplorationEnabled.not()
} }
@Suppress("UNUSED_PARAMETER")
fun inReplyToClicked(eventId: EventId) { fun inReplyToClicked(eventId: EventId) {
// TODO implement this logic once we have support to 'jump to event X' in sliding sync state.eventSink(TimelineEvents.FocusOnEvent(eventId))
} }
// Animate alpha when timeline is first displayed, to avoid flashes or glitching when viewing rooms // Animate alpha when timeline is first displayed, to avoid flashes or glitching when viewing rooms

5
features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/TimelineItemEventRow.kt
View file

@ -417,7 +417,6 @@ private fun MessageSenderInformation(
private fun MessageEventBubbleContent( private fun MessageEventBubbleContent(
event: TimelineItem.Event, event: TimelineItem.Event,
onMessageLongClick: () -> Unit, onMessageLongClick: () -> Unit,
@Suppress("UNUSED_PARAMETER")
inReplyToClick: () -> Unit, inReplyToClick: () -> Unit,
onTimestampClicked: () -> Unit, onTimestampClicked: () -> Unit,
onLinkClicked: (String) -> Unit, onLinkClicked: (String) -> Unit,
@ -568,8 +567,8 @@ private fun MessageEventBubbleContent(
val inReplyToModifier = Modifier val inReplyToModifier = Modifier
.padding(top = topPadding, start = 8.dp, end = 8.dp) .padding(top = topPadding, start = 8.dp, end = 8.dp)
.clip(RoundedCornerShape(6.dp)) .clip(RoundedCornerShape(6.dp))
// FIXME when a node is clickable, its contents won't be added to the semantics tree of its parent // FIXME when a node is clickable, its contents won't be added to the semantics tree of its parent
// .clickable(enabled = true, onClick = inReplyToClick) .clickable(onClick = inReplyToClick)
when (inReplyTo) { when (inReplyTo) {
is InReplyToDetails.Ready -> { is InReplyToDetails.Ready -> {
ReplyToContent( ReplyToContent(