Remove useless Boxes.

This commit is contained in:
Benoit Marty 2024-08-12 10:40:34 +02:00 committed by Benoit Marty
parent 615e75296c
commit 260d3eb39e

View file

@ -71,16 +71,15 @@ fun PinnedMessagesBannerView(
onViewAllClick: () -> Unit, onViewAllClick: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
) { ) {
Box(modifier = modifier) { when (state) {
when (state) { PinnedMessagesBannerState.Hidden -> Unit
PinnedMessagesBannerState.Hidden -> Unit is PinnedMessagesBannerState.Visible -> {
is PinnedMessagesBannerState.Visible -> { PinnedMessagesBannerRow(
PinnedMessagesBannerRow( state = state,
state = state, onClick = onClick,
onClick = onClick, onViewAllClick = onViewAllClick,
onViewAllClick = onViewAllClick, modifier = modifier,
) )
}
} }
} }
} }
@ -136,18 +135,17 @@ private fun ViewAllButton(
onViewAllClick: () -> Unit, onViewAllClick: () -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
) { ) {
Box(modifier = modifier) { val text = if (state is PinnedMessagesBannerState.Loaded) {
val text = if (state is PinnedMessagesBannerState.Loaded) { stringResource(id = CommonStrings.screen_room_pinned_banner_view_all_button_title)
stringResource(id = CommonStrings.screen_room_pinned_banner_view_all_button_title) } else {
} else { ""
""
}
TextButton(
text = text,
showProgress = state is PinnedMessagesBannerState.Loading,
onClick = onViewAllClick
)
} }
TextButton(
text = text,
showProgress = state is PinnedMessagesBannerState.Loading,
onClick = onViewAllClick,
modifier = modifier,
)
} }
private fun Modifier.drawBorder(borderColor: Color): Modifier { private fun Modifier.drawBorder(borderColor: Color): Modifier {