Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove @Inject, not necessary anymore when class is annotated with @ContributesBinding

Browse source
This commit is contained in:
Benoit Marty 2025-10-22 18:37:13 +02:00
parent 27a6e6aa82
commit 263e761907
273 changed files with 1 additions and 545 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultPushGatewayHttpUrlProvider.kt
View file

@ -9,7 +9,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.features.enterprise.api.EnterpriseService
interface DefaultPushGatewayHttpUrlProvider {
@ -17,7 +16,6 @@ interface DefaultPushGatewayHttpUrlProvider {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultDefaultPushGatewayHttpUrlProvider(
private val enterpriseService: EnterpriseService,
) : DefaultPushGatewayHttpUrlProvider {

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/GuardServiceStarter.kt
View file

@ -9,7 +9,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
interface GuardServiceStarter {
fun start() {}
@ -17,5 +16,4 @@ interface GuardServiceStarter {
}
@ContributesBinding(AppScope::class)
@Inject
class NoopGuardServiceStarter : GuardServiceStarter

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/RegisterUnifiedPushUseCase.kt
View file

@ -10,7 +10,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import android.content.Context
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.di.annotations.ApplicationContext
import io.element.android.libraries.pushproviders.api.Distributor
import io.element.android.libraries.pushproviders.unifiedpush.registration.EndpointRegistrationHandler
@ -25,7 +24,6 @@ interface RegisterUnifiedPushUseCase {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultRegisterUnifiedPushUseCase(
@ApplicationContext private val context: Context,
private val endpointRegistrationHandler: EndpointRegistrationHandler,

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushApiFactory.kt
View file

@ -9,7 +9,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.network.RetrofitFactory
import io.element.android.libraries.pushproviders.unifiedpush.network.UnifiedPushApi
@ -18,7 +17,6 @@ interface UnifiedPushApiFactory {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultUnifiedPushApiFactory(
private val retrofitFactory: RetrofitFactory,
) : UnifiedPushApiFactory {

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushCurrentUserPushConfigProvider.kt
View file

@ -9,7 +9,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.pushproviders.api.CurrentUserPushConfig
import io.element.android.libraries.pushstore.api.clientsecret.PushClientSecret
import io.element.android.services.appnavstate.api.AppNavigationStateService
@ -20,7 +19,6 @@ interface UnifiedPushCurrentUserPushConfigProvider {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultUnifiedPushCurrentUserPushConfigProvider(
private val pushClientSecret: PushClientSecret,
private val unifiedPushStore: UnifiedPushStore,

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushDistributorProvider.kt
View file

@ -10,7 +10,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import android.content.Context
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.androidutils.system.getApplicationLabel
import io.element.android.libraries.di.annotations.ApplicationContext
import io.element.android.libraries.pushproviders.api.Distributor
@ -21,7 +20,6 @@ interface UnifiedPushDistributorProvider {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultUnifiedPushDistributorProvider(
@ApplicationContext private val context: Context,
) : UnifiedPushDistributorProvider {

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushGatewayResolver.kt
View file

@ -9,7 +9,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.core.coroutine.CoroutineDispatchers
import io.element.android.libraries.core.data.tryOrNull
import io.element.android.libraries.core.log.logger.LoggerTag
@ -33,7 +32,6 @@ interface UnifiedPushGatewayResolver {
private val loggerTag = LoggerTag("DefaultUnifiedPushGatewayResolver")
@ContributesBinding(AppScope::class)
@Inject
class DefaultUnifiedPushGatewayResolver(
private val unifiedPushApiFactory: UnifiedPushApiFactory,
private val coroutineDispatchers: CoroutineDispatchers,

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushGatewayUrlResolver.kt
View file

@ -9,7 +9,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
interface UnifiedPushGatewayUrlResolver {
fun resolve(
@ -19,7 +18,6 @@ interface UnifiedPushGatewayUrlResolver {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultUnifiedPushGatewayUrlResolver(
private val unifiedPushStore: UnifiedPushStore,
private val defaultPushGatewayHttpUrlProvider: DefaultPushGatewayHttpUrlProvider,

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushNewGatewayHandler.kt
View file

@ -9,7 +9,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.core.extensions.flatMap
import io.element.android.libraries.core.log.logger.LoggerTag
import io.element.android.libraries.matrix.api.MatrixClientProvider
@ -28,7 +27,6 @@ interface UnifiedPushNewGatewayHandler {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultUnifiedPushNewGatewayHandler(
private val pusherSubscriber: PusherSubscriber,
private val userPushStoreFactory: UserPushStoreFactory,

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnifiedPushStore.kt
View file

@ -12,7 +12,6 @@ import android.content.SharedPreferences
import androidx.core.content.edit
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.di.annotations.ApplicationContext
import io.element.android.libraries.matrix.api.core.UserId
@ -26,7 +25,6 @@ interface UnifiedPushStore {
}
@ContributesBinding(AppScope::class)
@Inject
class SharedPreferencesUnifiedPushStore(
@ApplicationContext val context: Context,
private val sharedPreferences: SharedPreferences,

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/UnregisterUnifiedPushUseCase.kt
View file

@ -10,7 +10,6 @@ package io.element.android.libraries.pushproviders.unifiedpush
import android.content.Context
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.di.annotations.ApplicationContext
import io.element.android.libraries.matrix.api.MatrixClient
import io.element.android.libraries.pushproviders.api.PusherSubscriber
@ -30,7 +29,6 @@ interface UnregisterUnifiedPushUseCase {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultUnregisterUnifiedPushUseCase(
@ApplicationContext private val context: Context,
private val unifiedPushStore: UnifiedPushStore,

2
libraries/pushproviders/unifiedpush/src/main/kotlin/io/element/android/libraries/pushproviders/unifiedpush/troubleshoot/OpenDistributorWebPageAction.kt
View file

@ -10,7 +10,6 @@ package io.element.android.libraries.pushproviders.unifiedpush.troubleshoot
import android.content.Context
import dev.zacsweers.metro.AppScope
import dev.zacsweers.metro.ContributesBinding
import dev.zacsweers.metro.Inject
import io.element.android.libraries.androidutils.system.openUrlInExternalApp
import io.element.android.libraries.di.annotations.ApplicationContext
import io.element.android.libraries.pushproviders.unifiedpush.UnifiedPushConfig
@ -20,7 +19,6 @@ interface OpenDistributorWebPageAction {
}
@ContributesBinding(AppScope::class)
@Inject
class DefaultOpenDistributorWebPageAction(
@ApplicationContext private val context: Context,
) : OpenDistributorWebPageAction {