Merge pull request #816 from vector-im/feature/fga/fix_loading_room_node_padding

LoadingRoomNode : fix windowInsets...
This commit is contained in:
ganfra 2023-07-10 15:49:51 +02:00 committed by GitHub
commit 28db48540c

View file

@ -19,13 +19,14 @@ package io.element.android.appnav.room
import androidx.compose.foundation.background import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.ExperimentalLayoutApi
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.WindowInsets import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.consumeWindowInsets
import androidx.compose.foundation.layout.fillMaxSize import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.systemBars
import androidx.compose.foundation.layout.width import androidx.compose.foundation.layout.width
import androidx.compose.foundation.shape.CircleShape import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material3.ExperimentalMaterial3Api import androidx.compose.material3.ExperimentalMaterial3Api
@ -51,6 +52,7 @@ import io.element.android.libraries.designsystem.theme.placeholderBackground
import io.element.android.libraries.theme.ElementTheme import io.element.android.libraries.theme.ElementTheme
import io.element.android.libraries.ui.strings.CommonStrings import io.element.android.libraries.ui.strings.CommonStrings
@OptIn(ExperimentalLayoutApi::class)
@Composable @Composable
fun LoadingRoomNodeView( fun LoadingRoomNodeView(
state: LoadingRoomState, state: LoadingRoomState,
@ -60,7 +62,6 @@ fun LoadingRoomNodeView(
) { ) {
Scaffold( Scaffold(
modifier = modifier, modifier = modifier,
contentWindowInsets = WindowInsets.systemBars,
topBar = { topBar = {
Column { Column {
ConnectivityIndicatorView(isOnline = hasNetworkConnection) ConnectivityIndicatorView(isOnline = hasNetworkConnection)
@ -72,7 +73,9 @@ fun LoadingRoomNodeView(
modifier = Modifier modifier = Modifier
.fillMaxSize() .fillMaxSize()
.padding(padding) .padding(padding)
.padding(16.dp), contentAlignment = Alignment.Center .consumeWindowInsets(padding)
.padding(16.dp),
contentAlignment = Alignment.Center
) { ) {
if (state is LoadingRoomState.Error) { if (state is LoadingRoomState.Error) {
Text( Text(
@ -90,9 +93,12 @@ fun LoadingRoomNodeView(
@OptIn(ExperimentalMaterial3Api::class) @OptIn(ExperimentalMaterial3Api::class)
@Composable @Composable
private fun LoadingRoomTopBar(onBackClicked: () -> Unit) { private fun LoadingRoomTopBar(
onBackClicked: () -> Unit,
modifier: Modifier = Modifier
) {
TopAppBar( TopAppBar(
modifier = Modifier, modifier = modifier,
navigationIcon = { navigationIcon = {
BackButton(onClick = onBackClicked) BackButton(onClick = onBackClicked)
}, },
@ -112,6 +118,7 @@ private fun LoadingRoomTopBar(onBackClicked: () -> Unit) {
PlaceholderAtom(width = 45.dp, height = 7.dp) PlaceholderAtom(width = 45.dp, height = 7.dp)
} }
}, },
windowInsets = WindowInsets(0.dp),
) )
} }