Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Enable detekt rules VariableNaming and cleanup the code.

Browse source
This commit is contained in:
Benoit Marty 2023-07-20 17:50:23 +02:00
parent bd2826da3a
commit 2bd1c75937
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/reporter/DefaultBugReporter.kt
View file

@ -103,7 +103,7 @@ class DefaultBugReporter @Inject constructor(
.adapter<JsonDict>(Types.newParameterizedType(Map::class.java, String::class.java, Any::class.java)) .adapter<JsonDict>(Types.newParameterizedType(Map::class.java, String::class.java, Any::class.java))
*/ */
private val LOGCAT_CMD_ERROR = arrayOf( private val logcatCommandError = arrayOf(
"logcat", // /< Run 'logcat' command "logcat", // /< Run 'logcat' command
"-d", // /< Dump the log rather than continue outputting it "-d", // /< Dump the log rather than continue outputting it
"-v", // formatting "-v", // formatting
@ -114,7 +114,7 @@ class DefaultBugReporter @Inject constructor(
"*:S" // /< Everything else silent, so don't pick it.. "*:S" // /< Everything else silent, so don't pick it..
) )
private val LOGCAT_CMD_DEBUG = arrayOf("logcat", "-d", "-v", "threadtime", "*:*") private val logcatCommandDebug = arrayOf("logcat", "-d", "-v", "threadtime", "*:*")
/** /**
* Send a bug report. * Send a bug report.
@ -500,7 +500,7 @@ class DefaultBugReporter @Inject constructor(
val logcatProc: Process val logcatProc: Process
try { try {
logcatProc = Runtime.getRuntime().exec(if (isErrorLogCat) LOGCAT_CMD_ERROR else LOGCAT_CMD_DEBUG) logcatProc = Runtime.getRuntime().exec(if (isErrorLogCat) logcatCommandError else logcatCommandDebug)
} catch (e1: IOException) { } catch (e1: IOException) {
return return
} }

3
tools/detekt/detekt.yml
View file

@ -69,8 +69,7 @@ complexity:
naming: naming:
VariableNaming: VariableNaming:
# TODO Enable it active: true
active: false
TopLevelPropertyNaming: TopLevelPropertyNaming:
# TODO Enable it # TODO Enable it
active: false active: false