Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

PinUnlock tests: do not use awaitLastSequentialItem...

Browse source
This commit is contained in:
ganfra 2024-02-27 20:31:09 +01:00
parent 26607761a1
commit 2c2a2abd10
1 changed files with 22 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

34
features/lockscreen/impl/src/test/kotlin/io/element/android/features/lockscreen/impl/unlock/PinUnlockPresenterTest.kt
View file

@ -30,7 +30,6 @@ import io.element.android.features.lockscreen.impl.pin.model.assertText
import io.element.android.features.lockscreen.impl.unlock.keypad.PinKeypadModel import io.element.android.features.lockscreen.impl.unlock.keypad.PinKeypadModel
import io.element.android.libraries.architecture.AsyncData import io.element.android.libraries.architecture.AsyncData
import io.element.android.libraries.matrix.test.FakeMatrixClient import io.element.android.libraries.matrix.test.FakeMatrixClient
import io.element.android.tests.testutils.awaitLastSequentialItem
import io.element.android.tests.testutils.consumeItemsUntilPredicate import io.element.android.tests.testutils.consumeItemsUntilPredicate
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.test.runTest import kotlinx.coroutines.test.runTest
@ -60,15 +59,18 @@ class PinUnlockPresenterTest {
state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('1'))) state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('1')))
state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('2'))) state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('2')))
} }
awaitLastSequentialItem().also { state -> consumeItemsUntilPredicate { state ->
state.pinEntry.assertText(halfCompletePin) state.pinEntry.equalsTo(halfCompletePin)
}.last().also { state ->
state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('3'))) state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('3')))
state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Back)) state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Back))
state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Empty)) state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Empty))
state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('3'))) state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('3')))
state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('5'))) state.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('5')))
} }
awaitLastSequentialItem().also { state -> consumeItemsUntilPredicate { state ->
state.pinEntry.equalsTo(completePin) && state.isUnlocked
}.last().also { state ->
state.pinEntry.assertText(completePin) state.pinEntry.assertText(completePin)
assertThat(state.isUnlocked).isTrue() assertThat(state.isUnlocked).isTrue()
} }
@ -91,7 +93,9 @@ class PinUnlockPresenterTest {
initialState.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('3'))) initialState.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('3')))
initialState.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('4'))) initialState.eventSink(PinUnlockEvents.OnPinKeypadPressed(PinKeypadModel.Number('4')))
} }
awaitLastSequentialItem().also { state -> consumeItemsUntilPredicate { state ->
state.remainingAttempts.dataOrNull() == 0
}.last().also { state ->
assertThat(state.remainingAttempts.dataOrNull()).isEqualTo(0) assertThat(state.remainingAttempts.dataOrNull()).isEqualTo(0)
assertThat(state.showSignOutPrompt).isTrue() assertThat(state.showSignOutPrompt).isTrue()
assertThat(state.isSignOutPromptCancellable).isFalse() assertThat(state.isSignOutPromptCancellable).isFalse()
@ -110,17 +114,19 @@ class PinUnlockPresenterTest {
}.last().also { state -> }.last().also { state ->
state.eventSink(PinUnlockEvents.OnForgetPin) state.eventSink(PinUnlockEvents.OnForgetPin)
} }
awaitLastSequentialItem().also { state -> consumeItemsUntilPredicate { state ->
assertThat(state.showSignOutPrompt).isTrue() state.showSignOutPrompt && state.isSignOutPromptCancellable
assertThat(state.isSignOutPromptCancellable).isTrue() }.last().also { state ->
state.eventSink(PinUnlockEvents.ClearSignOutPrompt) state.eventSink(PinUnlockEvents.ClearSignOutPrompt)
} }
awaitLastSequentialItem().also { state -> consumeItemsUntilPredicate { state ->
assertThat(state.showSignOutPrompt).isFalse() !state.showSignOutPrompt
}.last().also { state ->
state.eventSink(PinUnlockEvents.OnForgetPin) state.eventSink(PinUnlockEvents.OnForgetPin)
} }
awaitLastSequentialItem().also { state -> consumeItemsUntilPredicate { state ->
assertThat(state.showSignOutPrompt).isTrue() state.showSignOutPrompt
}.last().also { state ->
state.eventSink(PinUnlockEvents.SignOut) state.eventSink(PinUnlockEvents.SignOut)
} }
consumeItemsUntilPredicate { state -> consumeItemsUntilPredicate { state ->
@ -133,6 +139,10 @@ class PinUnlockPresenterTest {
dataOrNull()?.assertText(text) dataOrNull()?.assertText(text)
} }
private fun AsyncData<PinEntry>.equalsTo(text: String): Boolean {
return dataOrNull()?.toText() == text
}
private suspend fun createPinUnlockPresenter( private suspend fun createPinUnlockPresenter(
scope: CoroutineScope, scope: CoroutineScope,
biometricUnlockManager: BiometricUnlockManager = FakeBiometricUnlockManager(), biometricUnlockManager: BiometricUnlockManager = FakeBiometricUnlockManager(),