Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Improve the code.

Browse source
This commit is contained in:
Benoit Marty 2026-01-19 18:17:13 +01:00
parent 60cb0806fa
commit 31fc60f40e
1 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

30
features/rageshake/impl/src/main/kotlin/io/element/android/features/rageshake/impl/detection/DefaultRageshakeDetectionPresenter.kt
View file

@ -12,7 +12,6 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.MutableState import androidx.compose.runtime.MutableState
import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.saveable.rememberSaveable import androidx.compose.runtime.saveable.rememberSaveable
import dev.zacsweers.metro.AppScope import dev.zacsweers.metro.AppScope
@ -62,16 +61,6 @@ class DefaultRageshakeDetectionPresenter(
} }
} }
val state = remember(preferencesState, isStarted.value, takeScreenshot.value, showDialog.value) {
RageshakeDetectionState(
isStarted = isStarted.value,
takeScreenshot = takeScreenshot.value,
showDialog = showDialog.value,
preferenceState = preferencesState,
eventSink = ::handleEvent,
)
}
LaunchedEffect(preferencesState.sensitivity) { LaunchedEffect(preferencesState.sensitivity) {
rageShake.setSensitivity(preferencesState.sensitivity) rageShake.setSensitivity(preferencesState.sensitivity)
} }
@ -83,14 +72,25 @@ class DefaultRageshakeDetectionPresenter(
!showDialog.value !showDialog.value
LaunchedEffect(shouldStart) { LaunchedEffect(shouldStart) {
handleRageShake(shouldStart, state, takeScreenshot) handleRageShake(
start = shouldStart,
sensitivity = preferencesState.sensitivity,
takeScreenshot = takeScreenshot,
)
} }
return state
return RageshakeDetectionState(
isStarted = isStarted.value,
takeScreenshot = takeScreenshot.value,
showDialog = showDialog.value,
preferenceState = preferencesState,
eventSink = ::handleEvent,
)
} }
private fun handleRageShake(start: Boolean, state: RageshakeDetectionState, takeScreenshot: MutableState<Boolean>) { private fun handleRageShake(start: Boolean, sensitivity: Float, takeScreenshot: MutableState<Boolean>) {
if (start) { if (start) {
rageShake.start(state.preferenceState.sensitivity) rageShake.start(sensitivity)
rageShake.setInterceptor { rageShake.setInterceptor {
takeScreenshot.value = true takeScreenshot.value = true
} }