Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Suppress Detekt false positive (?)

Browse source
This commit is contained in:
Benoit Marty 2025-01-17 11:49:54 +01:00 • committed by Benoit Marty
parent a06607f530
commit 32db42aebb
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenter.kt
View file

@ -127,12 +127,18 @@ class MediaViewerPresenter @AssistedInject constructor(
fun handleEvents(event: MediaViewerEvents) { fun handleEvents(event: MediaViewerEvents) {
when (event) { when (event) {
is MediaViewerEvents.LoadMedia -> coroutineScope.downloadMedia( is MediaViewerEvents.LoadMedia -> {
data = event.data, // It's OK to suppress the warning since mediaFile and localMedia are remembered
mediaFile = mediaFile.getOrPut(event.data.eventId) { mutableStateOf(null) }, @Suppress("RememberMissing")
localMedia = localMedia.getOrPut(event.data.eventId) { mutableStateOf(AsyncData.Uninitialized) }, coroutineScope.downloadMedia(
) data = event.data,
mediaFile = mediaFile.getOrPut(event.data.eventId) { mutableStateOf(null) },
localMedia = localMedia.getOrPut(event.data.eventId) { mutableStateOf(AsyncData.Uninitialized) },
)
}
is MediaViewerEvents.ClearLoadingError -> { is MediaViewerEvents.ClearLoadingError -> {
// It's OK to suppress the warning since localMedia is remembered
@Suppress("RememberMissing")
localMedia.getOrPut(event.eventId) { mutableStateOf(AsyncData.Uninitialized) }.value = AsyncData.Uninitialized localMedia.getOrPut(event.eventId) { mutableStateOf(AsyncData.Uninitialized) }.value = AsyncData.Uninitialized
} }
is MediaViewerEvents.SaveOnDisk -> { is MediaViewerEvents.SaveOnDisk -> {