Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Faster member list by avoiding many FFI calls (#2322)

Browse source 
* Faster member list by avoiding many FFI calls
This commit is contained in:
Timo Kösters 2024-03-05 10:41:51 +01:00 • committed by GitHub
parent bd85def8fa
commit 3386ee5178
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/2322.misc Normal file
View file

@ -0,0 +1 @@
Improve room member list loading times, increase chunk size

3
libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/member/RoomMemberListFetcher.kt
View file

@ -40,7 +40,7 @@ import kotlin.coroutines.coroutineContext
internal class RoomMemberListFetcher( internal class RoomMemberListFetcher(
private val room: RoomInterface, private val room: RoomInterface,
private val dispatcher: CoroutineDispatcher, private val dispatcher: CoroutineDispatcher,
private val pageSize: Int = 1000, private val pageSize: Int = 10_000,
) { ) {
private val updatedRoomMemberMutex = Mutex() private val updatedRoomMemberMutex = Mutex()
private val roomId = room.id() private val roomId = room.id()
@ -108,6 +108,7 @@ internal class RoomMemberListFetcher(
// We should probably implement some sort of paging in the future. // We should probably implement some sort of paging in the future.
coroutineContext.ensureActive() coroutineContext.ensureActive()
val chunk = iterator.nextChunk(pageSize.toUInt()) val chunk = iterator.nextChunk(pageSize.toUInt())
// Load next chunk. If null (no more items), exit the loop
val members = chunk?.parallelMap(RoomMemberMapper::map) ?: break val members = chunk?.parallelMap(RoomMemberMapper::map) ?: break
addAll(members) addAll(members)
Timber.i("Emitting first $size members for room $roomId") Timber.i("Emitting first $size members for room $roomId")