Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

ListItem: Update the preview so that they all contain both enabled and disabled rendering.

Browse source
This commit is contained in:
Benoit Marty 2024-10-18 12:19:26 +02:00 • committed by Benoit Marty
parent 3cdf533c33
commit 35aefedc41
1 changed files with 21 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

41
libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/ListItem.kt
View file

@ -8,6 +8,7 @@
package io.element.android.libraries.designsystem.theme.components package io.element.android.libraries.designsystem.theme.components
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Column
import androidx.compose.material3.ListItemColors import androidx.compose.material3.ListItemColors
import androidx.compose.material3.ListItemDefaults import androidx.compose.material3.ListItemDefaults
import androidx.compose.material3.LocalContentColor import androidx.compose.material3.LocalContentColor
@ -146,8 +147,8 @@ fun ListItem(
headlineContent = decoratedHeadlineContent, headlineContent = decoratedHeadlineContent,
modifier = if (onClick != null) { modifier = if (onClick != null) {
Modifier Modifier
.clickable(enabled = enabled, onClick = onClick) .clickable(enabled = enabled, onClick = onClick)
.then(modifier) .then(modifier)
} else { } else {
modifier modifier
}, },
@ -388,21 +389,20 @@ internal fun ListItemErrorWithIconPreview() = PreviewItems.OneLineListItemPrevie
) )
// endregion // endregion
// region: Disabled state
@Preview(name = "List item - Disabled", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemDisabledPreview() = PreviewItems.OneLineListItemPreview(enabled = false)
@Preview(name = "List item - Disabled & Icon", group = PreviewGroup.ListItems)
@Composable
internal fun ListItemDisabledWithIconPreview() = PreviewItems.OneLineListItemPreview(
enabled = false,
leadingContent = PreviewItems.icon(),
)
// endregion
@Suppress("ModifierMissing") @Suppress("ModifierMissing")
private object PreviewItems { private object PreviewItems {
@Composable
private fun EnabledDisabledElementThemedPreview(
content: @Composable (Boolean) -> Unit,
) = ElementThemedPreview {
Column {
sequenceOf(true, false).forEach {
content(it)
}
}
}
@Composable @Composable
fun ThreeLinesListItemPreview( fun ThreeLinesListItemPreview(
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
@ -410,12 +410,13 @@ private object PreviewItems {
leadingContent: ListItemContent? = null, leadingContent: ListItemContent? = null,
trailingContent: ListItemContent? = null, trailingContent: ListItemContent? = null,
) { ) {
ElementThemedPreview { EnabledDisabledElementThemedPreview {
ListItem( ListItem(
headlineContent = headline(), headlineContent = headline(),
supportingContent = text(), supportingContent = text(),
leadingContent = leadingContent, leadingContent = leadingContent,
trailingContent = trailingContent, trailingContent = trailingContent,
enabled = it,
style = style, style = style,
modifier = modifier, modifier = modifier,
) )
@ -429,12 +430,13 @@ private object PreviewItems {
leadingContent: ListItemContent? = null, leadingContent: ListItemContent? = null,
trailingContent: ListItemContent? = null, trailingContent: ListItemContent? = null,
) { ) {
ElementThemedPreview { EnabledDisabledElementThemedPreview {
ListItem( ListItem(
headlineContent = headline(), headlineContent = headline(),
supportingContent = textSingleLine(), supportingContent = textSingleLine(),
leadingContent = leadingContent, leadingContent = leadingContent,
trailingContent = trailingContent, trailingContent = trailingContent,
enabled = it,
style = style, style = style,
modifier = modifier, modifier = modifier,
) )
@ -447,14 +449,13 @@ private object PreviewItems {
style: ListItemStyle = ListItemStyle.Default, style: ListItemStyle = ListItemStyle.Default,
leadingContent: ListItemContent? = null, leadingContent: ListItemContent? = null,
trailingContent: ListItemContent? = null, trailingContent: ListItemContent? = null,
enabled: Boolean = true,
) { ) {
ElementThemedPreview { EnabledDisabledElementThemedPreview {
ListItem( ListItem(
headlineContent = headline(), headlineContent = headline(),
leadingContent = leadingContent, leadingContent = leadingContent,
trailingContent = trailingContent, trailingContent = trailingContent,
enabled = enabled, enabled = it,
style = style, style = style,
modifier = modifier, modifier = modifier,
) )