Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Log the push resolving failure reason if available (#4835)

Browse source
This commit is contained in:
Jorge Martin Espinosa 2025-06-06 18:06:46 +02:00 • committed by GitHub
parent e7f4d1268f
commit 35ecbd9324
1 changed files with 23 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

33
libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/push/DefaultPushHandler.kt
View file

@ -75,21 +75,34 @@ class DefaultPushHandler @Inject constructor(
for (request in requests) { for (request in requests) {
// Log the result of the push notification event // Log the result of the push notification event
val result = resolvedEvents[request] val result = resolvedEvents[request]
if (result?.isSuccess == true) { if (result == null) {
pushHistoryService.onSuccess(
providerInfo = request.providerInfo,
eventId = request.eventId,
roomId = request.roomId,
sessionId = request.sessionId,
comment = "Push handled successfully",
)
} else {
pushHistoryService.onUnableToResolveEvent( pushHistoryService.onUnableToResolveEvent(
providerInfo = request.providerInfo, providerInfo = request.providerInfo,
eventId = request.eventId, eventId = request.eventId,
roomId = request.roomId, roomId = request.roomId,
sessionId = request.sessionId, sessionId = request.sessionId,
reason = "Push not handled", reason = "Push not handled: no result found for request",
)
} else {
result.fold(
onSuccess = {
pushHistoryService.onSuccess(
providerInfo = request.providerInfo,
eventId = request.eventId,
roomId = request.roomId,
sessionId = request.sessionId,
comment = "Push handled successfully",
)
},
onFailure = { exception ->
pushHistoryService.onUnableToResolveEvent(
providerInfo = request.providerInfo,
eventId = request.eventId,
roomId = request.roomId,
sessionId = request.sessionId,
reason = exception.message ?: exception.javaClass.simpleName,
)
}
) )
} }
} }