Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Create VoiceMessageConfig in appconfig module.

Browse source
This commit is contained in:
Benoit Marty 2023-11-14 10:31:25 +01:00
parent f073e51a84
commit 3628a0359c
4 changed files with 30 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
libraries/voicerecorder/impl/build.gradle.kts
View file

@ -31,6 +31,7 @@ dependencies {
api(libs.opusencoder)
implementation(libs.dagger)
implementation(projects.appconfig)
implementation(projects.libraries.matrix.api)
implementation(projects.libraries.core)
implementation(projects.libraries.di)

3
libraries/voicerecorder/impl/src/main/kotlin/io/element/android/libraries/voicerecorder/impl/VoiceRecorderImpl.kt
View file

@ -19,6 +19,7 @@ package io.element.android.libraries.voicerecorder.impl
import android.Manifest
import androidx.annotation.RequiresPermission
import com.squareup.anvil.annotations.ContributesBinding
import io.element.android.appconfig.VoiceMessageConfig
import io.element.android.libraries.core.coroutine.CoroutineDispatchers
import io.element.android.libraries.core.coroutine.childScope
import io.element.android.libraries.di.RoomScope
@ -94,7 +95,7 @@ class VoiceRecorderImpl @Inject constructor(
val elapsedTime = startedAt.elapsedNow()
if (elapsedTime > 30.minutes) {
if (elapsedTime > VoiceMessageConfig.maxVoiceMessageDuration) {
Timber.w("Voice message time limit reached")
stopRecord(false)
return@record

7
libraries/voicerecorder/impl/src/test/kotlin/io/element/android/libraries/voicerecorder/impl/VoiceRecorderImplTest.kt
View file

@ -20,6 +20,7 @@ import android.media.AudioFormat
import android.media.MediaRecorder
import app.cash.turbine.test
import com.google.common.truth.Truth.assertThat
import io.element.android.appconfig.VoiceMessageConfig
import io.element.android.libraries.voicerecorder.api.VoiceRecorderState
import io.element.android.libraries.voicerecorder.impl.audio.Audio
import io.element.android.libraries.voicerecorder.impl.audio.AudioConfig
@ -77,8 +78,8 @@ class VoiceRecorderImplTest {
voiceRecorder.startRecord()
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Recording(0.minutes, listOf(1.0f)))
timeSource += 30.minutes
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Recording(30.minutes, listOf()))
timeSource += VoiceMessageConfig.maxVoiceMessageDuration
assertThat(awaitItem()).isEqualTo(VoiceRecorderState.Recording(VoiceMessageConfig.maxVoiceMessageDuration, listOf()))
timeSource += 1.milliseconds
assertThat(awaitItem()).isEqualTo(
@ -86,7 +87,7 @@ class VoiceRecorderImplTest {
file = File(FILE_PATH),
mimeType = "audio/ogg",
waveform = List(100) { 1f },
duration = 30.minutes,
duration = VoiceMessageConfig.maxVoiceMessageDuration,
)
)
}