Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Lambda parameters in a composable function should be in present tense, not past tense.

Browse source 
https://mrmans0n.github.io/compose-rules/rules/#naming-parameters-properly
This commit is contained in:
Benoit Marty 2024-05-29 10:48:29 +02:00
parent 0ba5537082
commit 37d9a9f5a9
250 changed files with 1698 additions and 1698 deletions
Download patch file Download diff file Expand all files Collapse all files

30
features/poll/api/src/main/kotlin/io/element/android/features/poll/api/pollcontent/PollContentView.kt
View file

@ -52,7 +52,7 @@ import kotlinx.collections.immutable.ImmutableList
@Composable
fun PollContentView(
state: PollContentState,
onAnswerSelected: (pollStartId: EventId, answerId: String) -> Unit,
onSelectAnswer: (pollStartId: EventId, answerId: String) -> Unit,
onPollEdit: (pollStartId: EventId) -> Unit,
onPollEnd: (pollStartId: EventId) -> Unit,
modifier: Modifier = Modifier,
@ -66,7 +66,7 @@ fun PollContentView(
isPollEnded = state.isPollEnded,
isMine = state.isMine,
onPollEdit = onPollEdit,
onAnswerSelected = onAnswerSelected,
onSelectAnswer = onSelectAnswer,
onPollEnd = onPollEnd,
modifier = modifier,
)
@ -81,15 +81,15 @@ fun PollContentView(
isPollEditable: Boolean,
isPollEnded: Boolean,
isMine: Boolean,
onAnswerSelected: (pollStartId: EventId, answerId: String) -> Unit,
onSelectAnswer: (pollStartId: EventId, answerId: String) -> Unit,
onPollEdit: (pollStartId: EventId) -> Unit,
onPollEnd: (pollStartId: EventId) -> Unit,
modifier: Modifier = Modifier,
) {
val votesCount = remember(answerItems) { answerItems.sumOf { it.votesCount } }
fun onAnswerSelected(pollAnswer: PollAnswer) {
eventId?.let { onAnswerSelected(it, pollAnswer.id) }
fun onSelectAnswer(pollAnswer: PollAnswer) {
eventId?.let { onSelectAnswer(it, pollAnswer.id) }
}
fun onPollEdit() {
@ -105,7 +105,7 @@ fun PollContentView(
if (showConfirmation) {
ConfirmationDialog(
content = stringResource(id = CommonStrings.common_poll_end_confirmation),
onSubmitClicked = {
onSubmitClick = {
onPollEnd()
showConfirmation = false
},
@ -119,7 +119,7 @@ fun PollContentView(
) {
PollTitle(title = question, isPollEnded = isPollEnded)
PollAnswers(answerItems = answerItems, onAnswerSelected = ::onAnswerSelected)
PollAnswers(answerItems = answerItems, onSelectAnswer = ::onSelectAnswer)
if (isPollEnded || pollKind == PollKind.Disclosed) {
DisclosedPollBottomNotice(votesCount = votesCount)
@ -170,7 +170,7 @@ private fun PollTitle(
@Composable
private fun PollAnswers(
answerItems: ImmutableList<PollAnswerItem>,
onAnswerSelected: (PollAnswer) -> Unit,
onSelectAnswer: (PollAnswer) -> Unit,
) {
Column(
modifier = Modifier.selectableGroup(),
@ -183,7 +183,7 @@ private fun PollAnswers(
.selectable(
selected = it.isSelected,
enabled = it.isEnabled,
onClick = { onAnswerSelected(it.answer) },
onClick = { onSelectAnswer(it.answer) },
role = Role.RadioButton,
),
)
@ -250,7 +250,7 @@ internal fun PollContentViewUndisclosedPreview() = ElementPreview {
isPollEnded = false,
isPollEditable = false,
isMine = false,
onAnswerSelected = { _, _ -> },
onSelectAnswer = { _, _ -> },
onPollEdit = {},
onPollEnd = {},
)
@ -267,7 +267,7 @@ internal fun PollContentViewDisclosedPreview() = ElementPreview {
isPollEnded = false,
isPollEditable = false,
isMine = false,
onAnswerSelected = { _, _ -> },
onSelectAnswer = { _, _ -> },
onPollEdit = {},
onPollEnd = {},
)
@ -284,7 +284,7 @@ internal fun PollContentViewEndedPreview() = ElementPreview {
isPollEnded = true,
isPollEditable = false,
isMine = false,
onAnswerSelected = { _, _ -> },
onSelectAnswer = { _, _ -> },
onPollEdit = {},
onPollEnd = {},
)
@ -301,7 +301,7 @@ internal fun PollContentViewCreatorEditablePreview() = ElementPreview {
isPollEnded = false,
isPollEditable = true,
isMine = true,
onAnswerSelected = { _, _ -> },
onSelectAnswer = { _, _ -> },
onPollEdit = {},
onPollEnd = {},
)
@ -318,7 +318,7 @@ internal fun PollContentViewCreatorPreview() = ElementPreview {
isPollEnded = false,
isPollEditable = false,
isMine = true,
onAnswerSelected = { _, _ -> },
onSelectAnswer = { _, _ -> },
onPollEdit = {},
onPollEnd = {},
)
@ -335,7 +335,7 @@ internal fun PollContentViewCreatorEndedPreview() = ElementPreview {
isPollEnded = true,
isPollEditable = false,
isMine = true,
onAnswerSelected = { _, _ -> },
onSelectAnswer = { _, _ -> },
onPollEdit = {},
onPollEnd = {},
)