Sulkta-OSS/element-x-ada
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Dagger: makes sure to not remove an active component when navigating

Browse source
This commit is contained in:
ganfra 2023-06-09 23:04:33 +02:00
parent ba44ff32c1
commit 3ba219c975
4 changed files with 16 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/kotlin/io/element/android/x/MainNode.kt
View file

@ -68,13 +68,13 @@ class MainNode(
}
private val roomFlowNodeCallback = object : RoomFlowNode.LifecycleCallback {
override fun onFlowCreated(room: MatrixRoom) {
override fun onFlowCreated(owner: String, room: MatrixRoom) {
val component = bindings<RoomComponent.ParentBindings>().roomComponentBuilder().room(room).build()
mainDaggerComponentOwner.addComponent(room.roomId.value, component)
mainDaggerComponentOwner.addComponent(owner, component)
}
override fun onFlowReleased(room: MatrixRoom) {
mainDaggerComponentOwner.removeComponent(room.roomId.value)
override fun onFlowReleased(owner: String, room: MatrixRoom) {
mainDaggerComponentOwner.removeComponent(owner)
}
}

4
app/src/main/kotlin/io/element/android/x/di/MainDaggerComponentsOwner.kt
View file

@ -38,6 +38,10 @@ class MainDaggerComponentsOwner @Inject constructor(@ApplicationContext context:
daggerComponents.remove(identifier)
}
/**
* We expose the dagger components in the opposite order they arrived.
* So we pick the most recent component when searching with the [io.element.android.libraries.architecture.bindings] methods.
*/
override val daggerComponent: Any
get() = daggerComponents.values.reversed()
}