feat(join by alias) : format code

This commit is contained in:
ganfra 2025-02-25 15:38:23 +01:00
parent 13c49f184e
commit 3bb61757ca
15 changed files with 3 additions and 20 deletions

View file

@ -28,7 +28,6 @@ class DefaultCreateRoomNavigator(
private val overlay: Overlay<NavTarget>, private val overlay: Overlay<NavTarget>,
private val openRoom: (RoomIdOrAlias, List<String>) -> Unit, private val openRoom: (RoomIdOrAlias, List<String>) -> Unit,
) : CreateRoomNavigator { ) : CreateRoomNavigator {
override fun onOpenRoom(roomIdOrAlias: RoomIdOrAlias, serverNames: List<String>) = openRoom(roomIdOrAlias, serverNames) override fun onOpenRoom(roomIdOrAlias: RoomIdOrAlias, serverNames: List<String>) = openRoom(roomIdOrAlias, serverNames)
override fun onCreateNewRoom() { override fun onCreateNewRoom() {

View file

@ -60,7 +60,6 @@ class ConfigureRoomFlowNode @AssistedInject constructor(
data object ConfigureRoom : NavTarget data object ConfigureRoom : NavTarget
} }
override fun resolve(navTarget: NavTarget, buildContext: BuildContext): Node { override fun resolve(navTarget: NavTarget, buildContext: BuildContext): Node {
return when (navTarget) { return when (navTarget) {
NavTarget.Root -> { NavTarget.Root -> {

View file

@ -30,8 +30,6 @@ import io.element.android.libraries.architecture.BaseFlowNode
import io.element.android.libraries.architecture.OverlayView import io.element.android.libraries.architecture.OverlayView
import io.element.android.libraries.architecture.createNode import io.element.android.libraries.architecture.createNode
import io.element.android.libraries.di.SessionScope import io.element.android.libraries.di.SessionScope
import io.element.android.libraries.matrix.api.core.RoomId
import io.element.android.libraries.matrix.api.core.RoomIdOrAlias
import kotlinx.parcelize.Parcelize import kotlinx.parcelize.Parcelize
@ContributesNode(SessionScope::class) @ContributesNode(SessionScope::class)

View file

@ -30,7 +30,6 @@ class ConfigureRoomNode @AssistedInject constructor(
private val presenter: ConfigureRoomPresenter, private val presenter: ConfigureRoomPresenter,
private val analyticsService: AnalyticsService, private val analyticsService: AnalyticsService,
) : Node(buildContext, plugins = plugins) { ) : Node(buildContext, plugins = plugins) {
private val navigator = plugins<CreateRoomNavigator>().first() private val navigator = plugins<CreateRoomNavigator>().first()
init { init {

View file

@ -9,6 +9,6 @@ package io.element.android.features.createroom.impl.joinbyaddress
sealed interface JoinRoomByAddressEvents { sealed interface JoinRoomByAddressEvents {
data object Dismiss : JoinRoomByAddressEvents data object Dismiss : JoinRoomByAddressEvents
data object Continue: JoinRoomByAddressEvents data object Continue : JoinRoomByAddressEvents
data class UpdateAddress(val address: String) : JoinRoomByAddressEvents data class UpdateAddress(val address: String) : JoinRoomByAddressEvents
} }

View file

@ -25,7 +25,6 @@ class JoinRoomByAddressNode @AssistedInject constructor(
@Assisted plugins: List<Plugin>, @Assisted plugins: List<Plugin>,
presenterFactory: JoinRoomByAddressPresenter.Factory, presenterFactory: JoinRoomByAddressPresenter.Factory,
) : Node(buildContext, plugins = plugins) { ) : Node(buildContext, plugins = plugins) {
private val navigator = plugins<CreateRoomNavigator>().first() private val navigator = plugins<CreateRoomNavigator>().first()
private val presenter = presenterFactory.create(navigator) private val presenter = presenterFactory.create(navigator)

View file

@ -36,7 +36,6 @@ class JoinRoomByAddressPresenter @AssistedInject constructor(
private val client: MatrixClient, private val client: MatrixClient,
private val roomAliasHelper: RoomAliasHelper, private val roomAliasHelper: RoomAliasHelper,
) : Presenter<JoinRoomByAddressState> { ) : Presenter<JoinRoomByAddressState> {
@AssistedFactory @AssistedFactory
interface Factory { interface Factory {
fun create(navigator: CreateRoomNavigator): JoinRoomByAddressPresenter fun create(navigator: CreateRoomNavigator): JoinRoomByAddressPresenter
@ -137,6 +136,3 @@ class JoinRoomByAddressPresenter @AssistedInject constructor(
} ?: RoomAddressState.RoomNotFound } ?: RoomAddressState.RoomNotFound
} }
} }

View file

@ -132,4 +132,3 @@ internal fun JoinRoomByAddressViewPreview(
) = ElementPreview { ) = ElementPreview {
JoinRoomByAddressView(state = state) JoinRoomByAddressView(state = state)
} }

View file

@ -34,7 +34,6 @@ class CreateRoomRootNode @AssistedInject constructor(
private val analyticsService: AnalyticsService, private val analyticsService: AnalyticsService,
private val inviteFriendsUseCase: InviteFriendsUseCase, private val inviteFriendsUseCase: InviteFriendsUseCase,
) : Node(buildContext, plugins = plugins) { ) : Node(buildContext, plugins = plugins) {
private val navigator = plugins<CreateRoomNavigator>().first() private val navigator = plugins<CreateRoomNavigator>().first()
init { init {

View file

@ -15,7 +15,6 @@ class FakeCreateRoomNavigator(
private val createNewRoomLambda: () -> Unit = {}, private val createNewRoomLambda: () -> Unit = {},
private val showJoinRoomByAddressLambda: () -> Unit = {}, private val showJoinRoomByAddressLambda: () -> Unit = {},
private val dismissJoinRoomByAddressLambda: () -> Unit = {}, private val dismissJoinRoomByAddressLambda: () -> Unit = {},
) : CreateRoomNavigator { ) : CreateRoomNavigator {
override fun onOpenRoom(roomIdOrAlias: RoomIdOrAlias, serverNames: List<String>) { override fun onOpenRoom(roomIdOrAlias: RoomIdOrAlias, serverNames: List<String>) {
openRoomLambda(roomIdOrAlias, serverNames) openRoomLambda(roomIdOrAlias, serverNames)

View file

@ -22,7 +22,6 @@ import kotlinx.coroutines.test.runTest
import org.junit.Test import org.junit.Test
class JoinRoomByAddressPresenterTest { class JoinRoomByAddressPresenterTest {
@Test @Test
fun `present - initial state`() = runTest { fun `present - initial state`() = runTest {
val presenter = createJoinRoomByAddressPresenter() val presenter = createJoinRoomByAddressPresenter()

View file

@ -24,7 +24,6 @@ import org.junit.runner.RunWith
@RunWith(AndroidJUnit4::class) @RunWith(AndroidJUnit4::class)
class JoinRoomByAddressViewTest { class JoinRoomByAddressViewTest {
@get:Rule @get:Rule
val rule = createAndroidComposeRule<ComponentActivity>() val rule = createAndroidComposeRule<ComponentActivity>()
@ -52,7 +51,6 @@ class JoinRoomByAddressViewTest {
rule.clickOn(CommonStrings.action_continue) rule.clickOn(CommonStrings.action_continue)
eventsRecorder.assertSingle(JoinRoomByAddressEvents.Continue) eventsRecorder.assertSingle(JoinRoomByAddressEvents.Continue)
} }
} }
private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setJoinRoomByAddressView( private fun <R : TestRule> AndroidComposeTestRule<R, ComponentActivity>.setJoinRoomByAddressView(

View file

@ -91,7 +91,7 @@ fun BugReportView(
keyboardController?.hide() keyboardController?.hide()
}), }),
minLines = 3, minLines = 3,
validity = if(state.isDescriptionInError) TextFieldValidity.Invalid else null, validity = if (state.isDescriptionInError) TextFieldValidity.Invalid else null,
) )
} }
Spacer(modifier = Modifier.height(16.dp)) Spacer(modifier = Modifier.height(16.dp))

View file

@ -321,7 +321,7 @@ private fun ContentToPreview() {
TextField( TextField(
onValueChange = {}, onValueChange = {},
label = "Label", label = "Label",
value = "Hello val=${validity}, en=${enabled.asInt()}, ro=${readonly.asInt()}", value = "Hello val=$validity, en=${enabled.asInt()}, ro=${readonly.asInt()}",
supportingText = "Supporting text", supportingText = "Supporting text",
validity = validity, validity = validity,
enabled = enabled, enabled = enabled,

View file

@ -8,7 +8,6 @@
package io.element.android.libraries.matrix.ui.room.address package io.element.android.libraries.matrix.ui.room.address
import androidx.compose.runtime.Immutable import androidx.compose.runtime.Immutable
import io.element.android.libraries.designsystem.theme.components.TextFieldValidity
/** /**
* Represents the validity state of a room address. * Represents the validity state of a room address.