From 3bf51ba11400490083ca1c79eef8ae2f68c28562 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 16 Jun 2025 14:18:52 +0200 Subject: [PATCH] a11y: improve reaction behavior on message action list. --- .../messages/impl/actionlist/ActionListView.kt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt index f849effb1a..c3ab8c91d5 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListView.kt @@ -39,7 +39,7 @@ import androidx.compose.ui.graphics.Color import androidx.compose.ui.platform.LocalContext import androidx.compose.ui.res.stringResource import androidx.compose.ui.semantics.clearAndSetSemantics -import androidx.compose.ui.semantics.contentDescription +import androidx.compose.ui.semantics.onClick import androidx.compose.ui.semantics.semantics import androidx.compose.ui.semantics.traversalIndex import androidx.compose.ui.text.style.TextAlign @@ -438,7 +438,7 @@ private fun EmojiButton( } else { Color.Transparent } - val description = if (isHighlighted) { + val a11yClickLabel = if (isHighlighted) { stringResource(id = CommonStrings.a11y_remove_reaction_with, emoji) } else { stringResource(id = CommonStrings.a11y_react_with, emoji) @@ -454,7 +454,12 @@ private fun EmojiButton( interactionSource = remember { MutableInteractionSource() } ) .semantics { - contentDescription = description + onClick( + label = a11yClickLabel, + ) { + onClick(emoji) + true + } }, contentAlignment = Alignment.Center ) {