Sulkta-OSS/element-x-ada
3
0
Fork 0
Code Issues 1 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Improve test names and perform more test.

Browse source
This commit is contained in:
Benoit Marty 2025-11-20 12:54:06 +01:00
parent 502fd472ed
commit 3eccb5c15d
1 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/workmanager/WorkerDataConverterTest.kt
View file

@ -48,7 +48,7 @@ class WorkerDataConverterTest {
} }
@Test @Test
fun `serializing lots of data leads to several work data generated`() { fun `serializing lots of data leads to several work data generated - one room - 100 events should be split in 5 chunks`() {
val data = List(100) { val data = List(100) {
NotificationEventRequest( NotificationEventRequest(
sessionId = A_SESSION_ID, sessionId = A_SESSION_ID,
@ -67,7 +67,7 @@ class WorkerDataConverterTest {
} }
@Test @Test
fun `serializing lots of data leads to several work data generated case 2`() { fun `serializing lots of data leads to several work data generated - one room - 101 events should be split in 6 chunks`() {
val data = List(101) { val data = List(101) {
NotificationEventRequest( NotificationEventRequest(
sessionId = A_SESSION_ID, sessionId = A_SESSION_ID,
@ -86,7 +86,7 @@ class WorkerDataConverterTest {
} }
@Test @Test
fun `serializing lots of data leads to several work data generated case 3`() { fun `serializing lots of data leads to several work data generated - 3 rooms - 25 events should be split in 2 chunks and room not mixed`() {
val data1 = List(15) { val data1 = List(15) {
NotificationEventRequest( NotificationEventRequest(
sessionId = A_SESSION_ID, sessionId = A_SESSION_ID,
@ -118,6 +118,18 @@ class WorkerDataConverterTest {
// All the items are present // All the items are present
val deserialized = serialized.getOrNull()?.flatMap { sut.deserialize(it)!! } val deserialized = serialized.getOrNull()?.flatMap { sut.deserialize(it)!! }
assertThat(deserialized).containsExactlyElementsIn(data) assertThat(deserialized).containsExactlyElementsIn(data)
// Rooms are not mixed between the chunks
val setsOfRooms = serialized.getOrNull()!!
.map { workData -> sut.deserialize(workData)!! }
.map {
it.map { request -> request.roomId }.toSet()
}
// Ensure that all sets are distinct
assertThat(setsOfRooms.size).isEqualTo(2)
// 3 roomId are present
assertThat(setsOfRooms.flatten().toSet()).containsExactly(A_ROOM_ID, A_ROOM_ID_2, A_ROOM_ID_3)
// No intersection between sets
assertThat(setsOfRooms[0].intersect(setsOfRooms[1])).isEmpty()
} }
private fun testIdentity(data: List<NotificationEventRequest>) { private fun testIdentity(data: List<NotificationEventRequest>) {